Re: [fossil-users] Confusing highlighting in side-by-side ignore-whitespace diff
2014-04-03 3:53 GMT+02:00 Andy Bradford amb-fos...@bradfords.org: It looks like a bug to me. For example, line 45 seems to correctly show the purple #define on the left being replaced with a purple space on the right. But the tail end shows a red G at the end of the macro being replaced with nothing on the right but doesn't do anything with the characters following the G to the end of the line. Yes, this is definitely a bug, and from your example I can see what's the problem. I will try to have a look at it today. The reason is that specifying w the calculation of the hash-value of the line changed, and apparently the highlighting algorithm makes an assumption on it which is no longer trunk. Thanks! Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Confusing highlighting in side-by-side ignore-whitespace diff
2014-04-03 8:56 GMT+02:00 Jan Nijtmans jan.nijtm...@gmail.com: Yes, this is definitely a bug, and from your example I can see what's the problem. Fixed here: www.fossil-scm.org/index.html/info/c23190a61d Thanks! Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Confusing highlighting in side-by-side ignore-whitespace diff
2014-04-03 9:06 GMT+02:00 Jan Nijtmans jan.nijtm...@gmail.com: 2014-04-03 8:56 GMT+02:00 Jan Nijtmans jan.nijtm...@gmail.com: Yes, this is definitely a bug, and from your example I can see what's the problem. Fixed here: www.fossil-scm.org/index.html/info/c23190a61d The effect of this fix can be seen on fossil-scm.org now, as Richard put the latest fossil binary there. The diff looks as expteded now: http://www.fossil-scm.org/index.html/fdiff?v1=ff3ce7fdb65c5501v2=f897c6fc3888f9easbs=1w Since there are no white-space-only changes in this diff, the w option should have no effect at all. The Ignore Whitespace button should only have effect when the diff contains white-space-only changes, e.g.: http://www.fossil-scm.org/index.html/fdiff?v1=624bb79c74v2=976db410b0sbs=1 Thanks, Richard! Waiting for a new fossil on the Tcl/Tk repositories now;-) Regards, Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Confusing highlighting in side-by-side ignore-whitespace diff
Thus said Jan Nijtmans on Thu, 03 Apr 2014 09:06:30 +0200: Fixed here: www.fossil-scm.org/index.html/info/c23190a61d Looks good! Thanks, Andy -- TAI64 timestamp: 4000533d73db ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
[fossil-users] Confusing highlighting in side-by-side ignore-whitespace diff
http://www.fossil-scm.org/index.html/fdiff?v1=ff3ce7fdb65c5501v2=f897c6fc3888f9easbs=1w The highlighting in most lines of this diff is confusing, and I don't think I can explain it fully. You'll just have to see for yourself. Indeed, there are numerous cases of something being highlighted as a change even though it's not a change at all. The show-whitespace diff looks good. (Fossil version 5fdad9bd8c) -- Andy Goth | andrew.m.goth/at/gmail/dot/com ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Confusing highlighting in side-by-side ignore-whitespace diff
Thus said Andy Goth on Wed, 02 Apr 2014 18:05:24 -0500: The highlighting in most lines of this diff is confusing, and I don't think I can explain it fully. You'll just have to see for yourself. Indeed, there are numerous cases of something being highlighted as a change even though it's not a change at all. It looks like a bug to me. For example, line 45 seems to correctly show the purple #define on the left being replaced with a purple space on the right. But the tail end shows a red G at the end of the macro being replaced with nothing on the right but doesn't do anything with the characters following the G to the end of the line. I definitely prefer the page that doesn't try to hide the whitespace. Andy -- TAI64 timestamp: 4000533cbf3b ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Confusing highlighting in side-by-side ignore-whitespace diff
On 4/2/2014 8:53 PM, Andy Bradford wrote: It looks like a bug to me. For example, line 45 If you think that's bad, check (new) lines 105 through 108 and 112. Only when ignoring whitespace, they have non-changes highlighted as additions. -- Andy Goth | andrew.m.goth/at/gmail/dot/com ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
