Re: [fossil-users] TH1: set v 0; unset v; info exists v;

2014-01-13 Thread Sergei Gavrikov
On Mon, 13 Jan 2014, Joe Mistachkin wrote: > > Sergei Gavrikov wrote: > > > > It looks like the same check is needed for Th_UnsetVar() too. > > > > Actually, the issue with Th_UnsetVar was slightly different; > however, it should be fixed now: > > http://www.fossil-scm.org/index.html/info

Re: [fossil-users] TH1: set v 0; unset v; info exists v;

2014-01-13 Thread Joe Mistachkin
Sergei Gavrikov wrote: > > It looks like the same check is needed for Th_UnsetVar() too. > Actually, the issue with Th_UnsetVar was slightly different; however, it should be fixed now: http://www.fossil-scm.org/index.html/info/1ebe4b02e4 Thanks again. -- Joe Mistachkin ___

Re: [fossil-users] TH1: set v 0; unset v; info exists v;

2014-01-13 Thread Sergei Gavrikov
> > Sergei Gavrikov wrote: > > > As I could see Th_ExistsVar() does miss a test for pValue->zData > > > as Th_GetVar() does > > http://fossil-scm.org/index.html/artifact/a561c58c237b3eb43eaf55e6f9cc6a9b8a26e5d1?ln=1142-1149. It looks like the same check is needed for Th_UnsetVar() too. # Expect

Re: [fossil-users] TH1: set v 0; unset v; info exists v;

2014-01-09 Thread Sergei Gavrikov
On Thu, 9 Jan 2014, Joe Mistachkin wrote: > > Sergei Gavrikov wrote: > > > > Thank you for the fixes! I'm sorry, but, I found yet another issue with > > Th_ExistsVar(). If a variable is not exists, Th_ExistsVar() does clear > > TH stack trace: > > > > Thanks again, fixed here: > > https://ww

Re: [fossil-users] TH1: set v 0; unset v; info exists v;

2014-01-09 Thread Joe Mistachkin
Sergei Gavrikov wrote: > > Thank you for the fixes! I'm sorry, but, I found yet another issue with > Th_ExistsVar(). If a variable is not exists, Th_ExistsVar() does clear > TH stack trace: > Thanks again, fixed here: https://www.fossil-scm.org/index.html/info/9765b03759 -- Joe Mista

Re: [fossil-users] TH1: set v 0; unset v; info exists v;

2014-01-09 Thread Sergei Gavrikov
On Sun, 5 Jan 2014, Joe Mistachkin wrote: > Sergei Gavrikov wrote: > > > > It seems this was introduced with Th_ExistsVar() > > > http://fossil-scm.org/index.html/artifact/a561c58c237b3eb43eaf55e6f9cc6a9b8a > 26e5d1?ln=1154-1159 > > (check-in http://fossil-scm.org/index.html/info/4f8c8975bc). As I

Re: [fossil-users] TH1: set v 0; unset v; info exists v;

2014-01-05 Thread Joe Mistachkin
Sergei Gavrikov wrote: > > It seems this was introduced with Th_ExistsVar() > http://fossil-scm.org/index.html/artifact/a561c58c237b3eb43eaf55e6f9cc6a9b8a 26e5d1?ln=1154-1159 > (check-in http://fossil-scm.org/index.html/info/4f8c8975bc). As I could > see Th_ExistsVar() does miss a test for pValue-

Re: [fossil-users] TH1: set v 0; unset v; info exists v;

2014-01-05 Thread Sergei Gavrikov
On Sun, 5 Jan 2014, Sergei Gavrikov wrote: [no lyrics] > % ./fossil version > This is fossil version 1.28 [da90bbe591] 2014-01-04 16:17:47 UTC > % ./fossil test-th-eval 'set v 1; unset v; info exists v' > 1 > > We expect 0. No issues with unset > > % ./fossil test-th-eval 'set v 1; unse