Re: [fossil-users] Tree view and browser back button
I may have missed something, but this is not showing up on the main fossil timeline anymore. Has the new tree view been pulled out of trunk for now? On Tue, Jan 14, 2014 at 6:55 PM, Richard Hipp d...@sqlite.org wrote: On Tue, Jan 14, 2014 at 8:42 PM, Joel Bruick j...@joelface.com wrote: Joel Bruick wrote: Sorry, I shouldn't have committed it to trunk in the first place. I'll let you know when I've got it working better. Should be working properly now. Tested on Firefox, Chrome, and IE10/11. Brilliant! Thanks, Joel. The latest code has been merged to trunk and is now in the server. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users -- D. Richard Hipp d...@sqlite.org ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tree view and browser back button
On Fri, Jan 24, 2014 at 6:53 PM, Sam philosopher@gmail.com wrote: I may have missed something, but this is not showing up on the main fossil timeline anymore. Has the new tree view been pulled out of trunk for now? The website is running Fossil version [64096c7269] 2014-01-22 18:32:05 the tree works there. And I don't see any changes on trunk since then that might have broken it. ( http://www.fossil-scm.org/fossil/timeline?t=trunka=64096c7269v). Are you *sure* you have the latest trunk? Have you tried make clean fossil maybe? -- D. Richard Hipp d...@sqlite.org ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tree view and browser back button
Joel - thanks for trying to fix this problem. But your patch doesn't work. On Chrome Version 31.0.1650.63 (the default on Ubuntu 13.10) pressing the back button returns to a collapsed tree. And on IE10, it no longer expands when clicking on a directory. (Firefox and Safari work in all cases that I tested, but they worked before too, so no change there.) I've moved your changes into a branch until we can get them working. -- D. Richard Hipp d...@sqlite.org ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tree view and browser back button
Richard Hipp wrote: Joel - thanks for trying to fix this problem. But your patch doesn't work. On ChromeVersion 31.0.1650.63 (the default on Ubuntu 13.10) pressing the back button returns to a collapsed tree. And on IE10, it no longer expands when clicking on a directory. (Firefox and Safari work in all cases that I tested, but they worked before too, so no change there.) I've moved your changes into a branch until we can get them working. Sorry, I shouldn't have committed it to trunk in the first place. I'll let you know when I've got it working better. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tree view and browser back button
Joel Bruick wrote: Sorry, I shouldn't have committed it to trunk in the first place. I'll let you know when I've got it working better. Should be working properly now. Tested on Firefox, Chrome, and IE10/11. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tree view and browser back button
On Tue, Jan 14, 2014 at 8:42 PM, Joel Bruick j...@joelface.com wrote: Joel Bruick wrote: Sorry, I shouldn't have committed it to trunk in the first place. I'll let you know when I've got it working better. Should be working properly now. Tested on Firefox, Chrome, and IE10/11. Brilliant! Thanks, Joel. The latest code has been merged to trunk and is now in the server. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users -- D. Richard Hipp d...@sqlite.org ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tree view and browser back button
On Mon, Jan 13, 2014 at 3:51 PM, Martin Gagnon eme...@gmail.com wrote: I like very much the new tree view but there's one thing that I found a bit annoying. After clicking on a file that is deep in the directory structure, the tree become all collapsed again after pressing the back button. Chrome does that. Firefox, otoh, keeps the tree expanded. I don't know why and don't know if there is anything we can do about it in Javascript/CSS. -- D. Richard Hipp d...@sqlite.org ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tree view and browser back button
On Mon, Jan 13, 2014 at 03:54:34PM -0500, Richard Hipp wrote: On Mon, Jan 13, 2014 at 3:51 PM, Martin Gagnon eme...@gmail.com wrote: I like very much the new tree view but there's one thing that I found a bit annoying. After clicking on a file that is deep in the directory structure, the tree become all collapsed again after pressing the back button. Chrome does that. Firefox, otoh, keeps the tree expanded. I don't know why and don't know if there is anything we can do about it in Javascript/CSS. -- D. Richard Hipp d...@sqlite.org The easiest way would probably be to manipulate the url has as you expand folders. So as an example if you expand ajax the url would become: /index.html/tree?ci=trunk#ajax then another level in it would be /index.html/tree?ci=trunk#ajax/cgi-bin. Then based on the hash in js you could expand the folder structure on load. -- James Turner ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tree view and browser back button
On Mon, Jan 13, 2014 at 04:03:14PM -0500, James Turner wrote: On Mon, Jan 13, 2014 at 03:54:34PM -0500, Richard Hipp wrote: On Mon, Jan 13, 2014 at 3:51 PM, Martin Gagnon eme...@gmail.com wrote: I like very much the new tree view but there's one thing that I found a bit annoying. After clicking on a file that is deep in the directory structure, the tree become all collapsed again after pressing the back button. Chrome does that. Firefox, otoh, keeps the tree expanded. I don't know why and don't know if there is anything we can do about it in Javascript/CSS. -- D. Richard Hipp d...@sqlite.org The easiest way would probably be to manipulate the url has as you expand folders. Should read: The easiest way would probably be to manipulate the url hash as you expand folders. So as an example if you expand ajax the url would become: /index.html/tree?ci=trunk#ajax then another level in it would be /index.html/tree?ci=trunk#ajax/cgi-bin. Then based on the hash in js you could expand the folder structure on load. -- James Turner ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users -- James Turner ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tree view and browser back button
On Mon, Jan 13, 2014 at 03:54:34PM -0500, Richard Hipp wrote: On Mon, Jan 13, 2014 at 3:51 PM, Martin Gagnon eme...@gmail.com wrote: I like very much the new tree view but there's one thing that I found a bit annoying. After clicking on a file that is deep in the directory structure, the tree become all collapsed again after pressing the back button. Chrome does that. Firefox, otoh, keeps the tree expanded. I don't know why and don't know if there is anything we can do about it in Javascript/CSS. True, I didn't think it was be a browser issue. So it works in Firefox here I give a try with Internet Explorer 11 and I get same result as in Chrome. So I it's not only a Chrome issue. -- Martin G. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
