Re: [fpc-devel] Less global variables

2010-10-11 Thread Marco van de Voort
In our previous episode, Andrew Brunner said: > LOL. I was talking about another way similar to c# namespaces. Do you have some proposal somewhere? I never understood how this can be added to FPC (or Delphi) in a workable way. ___ fpc-devel maillist -

Re: [fpc-devel] Less global variables

2010-10-10 Thread Florian Klämpfl
Am 10.10.2010 15:41, schrieb Hans-Peter Diettrich: > Florian Klämpfl schrieb: > > What do you feel a need for sorting out? Splitting the patch in understandable parts which can be committed separately with appropriate commit messages, >>> I.e. one patch for every single moved variabl

Re: [fpc-devel] Less global variables

2010-10-10 Thread Hans-Peter Diettrich
Florian Klämpfl schrieb: What do you feel a need for sorting out? Splitting the patch in understandable parts which can be committed separately with appropriate commit messages, I.e. one patch for every single moved variable??? If needed, yes. If one variable is moved and it involves more fi

Re: [fpc-devel] Less global variables

2010-10-10 Thread Florian Klämpfl
Am 10.10.2010 06:56, schrieb Hans-Peter Diettrich: > Florian Klämpfl schrieb: >> Am 10.10.2010 00:32, schrieb Hans-Peter Diettrich: >>> Florian Klämpfl schrieb: >>> > Now I hope that this patch will be applied to the trunk soon. No. It's a mess and I won't sort it out. >>> What do you feel

Re: [fpc-devel] Less global variables

2010-10-09 Thread Hans-Peter Diettrich
Florian Klämpfl schrieb: Am 10.10.2010 00:32, schrieb Hans-Peter Diettrich: Florian Klämpfl schrieb: Now I hope that this patch will be applied to the trunk soon. No. It's a mess and I won't sort it out. What do you feel a need for sorting out? Splitting the patch in understandable parts w

Re: [fpc-devel] Less global variables

2010-10-09 Thread Florian Klämpfl
Am 10.10.2010 00:32, schrieb Hans-Peter Diettrich: > Florian Klämpfl schrieb: > >>> Now I hope that this patch will be applied to the trunk soon. >> >> No. It's a mess and I won't sort it out. > > What do you feel a need for sorting out? Splitting the patch in understandable parts which can be c

Re: [fpc-devel] Less global variables

2010-10-09 Thread Hans-Peter Diettrich
Adem schrieb: On 2010-10-09 16:22, Hans-Peter Diettrich wrote: The variables have been replaced by (getter) functions, with some added procedures for updating their values - this is where getter/setter pairs are inapplicable for structured types, or require too many consequential changes for

Re: [fpc-devel] Less global variables

2010-10-09 Thread Hans-Peter Diettrich
Andrew Brunner schrieb: 2010/10/9 Adem : Would you consider turning those structured types into objects? Properties with getter/setter pairs would make tracing (placing a breakpoint in the getter/sertter would help identify the caller) easier. The only problem with that line of thinking is th

Re: [fpc-devel] Less global variables

2010-10-09 Thread Hans-Peter Diettrich
Florian Klämpfl schrieb: Now I hope that this patch will be applied to the trunk soon. No. It's a mess and I won't sort it out. What do you feel a need for sorting out? Not to mention the indentation style not following the style used in the surrounding code, The new or changed parts can

Re: [fpc-devel] Less global variables

2010-10-09 Thread Andrew Brunner
LOL. I was talking about another way similar to c# namespaces. On Oct 9, 2010, at 9:59 AM, Michael Van Canneyt wrote: > > > On Sat, 9 Oct 2010, Andrew Brunner wrote: > >> 2010/10/9 Adem : >>> Would you consider turning those structured types into objects? >>> >>> Properties with getter/set

Re: [fpc-devel] Less global variables

2010-10-09 Thread Adem
On 2010-10-09 17:50, Andrew Brunner wrote: 2010/10/9 Adem: Would you consider turning those structured types into objects? Properties with getter/setter pairs would make tracing (placing a breakpoint in the getter/sertter would help identify the caller) easier. The only problem with that line

Re: [fpc-devel] Less global variables

2010-10-09 Thread Michael Van Canneyt
On Sat, 9 Oct 2010, Andrew Brunner wrote: 2010/10/9 Adem : Would you consider turning those structured types into objects? Properties with getter/setter pairs would make tracing (placing a breakpoint in the getter/sertter would help identify the caller) easier. The only problem with that l

Re: [fpc-devel] Less global variables

2010-10-09 Thread Andrew Brunner
2010/10/9 Adem : > Would you consider turning those structured types into objects? > > Properties with getter/setter pairs would make tracing (placing a breakpoint > in the getter/sertter would help identify the caller) easier. The only problem with that line of thinking is that every time your ar

Re: [fpc-devel] Less global variables

2010-10-09 Thread Adem
On 2010-10-09 16:22, Hans-Peter Diettrich wrote: The variables have been replaced by (getter) functions, with some added procedures for updating their values - this is where getter/setter pairs are inapplicable for structured types, or require too many consequential changes for using pointers

Re: [fpc-devel] Less global variables

2010-10-09 Thread Florian Klämpfl
Am 09.10.2010 15:22, schrieb Hans-Peter Diettrich: > Now I hope that this patch will be applied to the trunk soon. No. It's a mess and I won't sort it out. Not to mention the indentation style not following the style used in the surrounding code, comments I made about the older patch are ignored,

[fpc-devel] Less global variables

2010-10-09 Thread Hans-Peter Diettrich
In this new approach I moved some global variables into classes, omitting variables that require to many consequential changes to the remaining compiler code - see patch #17584. This patch will allow for easier implementation of parallel processing in the compiler, or for multiple front-ends.