Re: [fpc-devel] missed ddk window hints

2008-08-07 Thread Michael Van Canneyt
On Thu, 7 Aug 2008, Paul Ishenin wrote: > Hello, FPC developers' list > > Please apply this patch and merge into fixes if possible. Patched and merged. It's not in 2.2.2, though. Michael. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org htt

Re: [fpc-devel] missed ddk window hints

2008-08-07 Thread Paul Ishenin
Michael Van Canneyt wrote: On Thu, 7 Aug 2008, Paul Ishenin wrote: Hello, FPC developers' list Please apply this patch and merge into fixes if possible. Patched and merged. It's not in 2.2.2, though. Thanks. Best regards, Paul Ishenin. ___

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety, fcl-xml(DOM) is also concerned.

2008-08-07 Thread Burkhard Carstens
Am Mittwoch, 6. August 2008 21:37 schrieb Sergei Gorelkin: > Mattias Gaertner wrote: > > On Wed, 6 Aug 2008 19:41:27 +0100 > > > > "Inoussa OUEDRAOGO" <[EMAIL PROTECTED]> wrote: > >> Hi, > >> > >> TAVLTree in avl_tree.pp is not thread safe due to the node > >> allocation and de-allocation done thro

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety, fcl-xml(DOM) is also concerned.

2008-08-07 Thread Mattias Gärtner
Zitat von Burkhard Carstens <[EMAIL PROTECTED]>: > Am Mittwoch, 6. August 2008 21:37 schrieb Sergei Gorelkin: > > Since this topic is touched, I would like to vote for removing > > avl_tree dependency from the DOM altogether. The reason is that the > > avl tree of child nodes is useless for any re

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety, fcl-xml(DOM) is also concerned.

2008-08-07 Thread Burkhard Carstens
Am Mittwoch, 6. August 2008 20:41 schrieb Inoussa OUEDRAOGO: > Hi, > > TAVLTree in avl_tree.pp is not thread safe due to the node > allocation and de-allocation done through the global > declared "NodeMemManager" variable. TAVLTreeNodeMemManager > implementation is cleary not thread safe, which btw

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety, fcl-xml(DOM) is also concerned.

2008-08-07 Thread Marco van de Voort
> Am Mittwoch, 6. August 2008 20:41 schrieb Inoussa OUEDRAOGO: > What about this: > * let TAVLTree access the node manager using a local reference > (TAVLTree.FNodeMemManager) > * in TAVLTree.create: > if IsMultiThread then > FNodeMemManager:=TAVLTreeNodeMemManager.create > else > FN

[fpc-devel] Bug in GetAppConfigDir(True) on unix systems!

2008-08-07 Thread Graeme Geldenhuys
Hi, Calling GetAppConfigDir(True) returns the wrong results... In my application I expected /etc// but instead it returned /etc/ Note the missing directory separator! ---[ rtl/unix/sysutils.pp ]--- Function GetAppConfigDir(Global : Boolean) : String;

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety, fcl-xml(DOM) is also concerned.

2008-08-07 Thread Burkhard Carstens
Am Donnerstag, 7. August 2008 11:15 schrieb Burkhard Carstens: [...] > > What about this: > * let TAVLTree access the node manager using a local reference > (TAVLTree.FNodeMemManager) > * in TAVLTree.create: > if IsMultiThread then > FNodeMemManager:=TAVLTreeNodeMemManager.create > else >

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety, fcl-xml(DOM) is also concerned.

2008-08-07 Thread Burkhard Carstens
Am Donnerstag, 7. August 2008 11:28 schrieb Marco van de Voort: > > Am Mittwoch, 6. August 2008 20:41 schrieb Inoussa OUEDRAOGO: > > What about this: > > * let TAVLTree access the node manager using a local reference > > (TAVLTree.FNodeMemManager) > > * in TAVLTree.create: > > if IsMultiThread

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety, fcl-xml(DOM) is also concerned.

2008-08-07 Thread Marco van de Voort
> Am Donnerstag, 7. August 2008 11:28 schrieb Marco van de Voort: > > > > I would add nodemgr as parameter to create, but with a default value > > of nil. If not NIL then just grab the default nodemanager. > > You mean "if nodemgr = nil" then grab the global one ? > This wouldn't help much for the

[fpc-devel] Re: Bug in GetAppConfigDir(True) on unix systems!

2008-08-07 Thread Graeme Geldenhuys
GetAppConfigFile() has the same issue. On Thu, Aug 7, 2008 at 11:30 AM, Graeme Geldenhuys <[EMAIL PROTECTED]> wrote: > Hi, > > Calling GetAppConfigDir(True) returns the wrong results... > > In my application I expected > > /etc// > > but instead it returned > > /etc/ > > > Note the missin

Re: [fpc-devel] Re: Bug in GetAppConfigDir(True) on unix systems!

2008-08-07 Thread Joost van der Sluis
This is fixed in fpc-trunk a few weeks ago. I'll morge it to fixes. Joost Op donderdag 07-08-2008 om 12:01 uur [tijdzone +0200], schreef Graeme Geldenhuys: > GetAppConfigFile() has the same issue. > > > > On Thu, Aug 7, 2008 at 11:30 AM, Graeme Geldenhuys > <[EMAIL PROTECTED]> wrote: > > Hi, >

[fpc-devel] TAVLTree(avl_tree.pp) thread safety : second proposition

2008-08-07 Thread Inoussa OUEDRAOGO
Second proposition : Another proposition is to introduce a base avl class say TBaseAVLTree that defines two abstract virtual methods "NewNode()" and "FreeNode()" and then define : - TAVLTree : that _do not_ use a node mem manager, then thread safe. - TAVLManagedTree that uses a node mem manager

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety, fcl-xml(DOM) is also concerned.

2008-08-07 Thread Sergei Gorelkin
Mattias Gärtner wrote: Zitat von Burkhard Carstens <[EMAIL PROTECTED]>: Am Mittwoch, 6. August 2008 21:37 schrieb Sergei Gorelkin: Since this topic is touched, I would like to vote for removing avl_tree dependency from the DOM altogether. The reason is that the avl tree of child nodes is usele

Re: [fpc-devel] Re: Bug in GetAppConfigDir(True) on unix systems!

2008-08-07 Thread Graeme Geldenhuys
On 8/7/08, Joost van der Sluis <[EMAIL PROTECTED]> wrote: > This is fixed in fpc-trunk a few weeks ago. I'll morge it to fixes. Umm, I knew I had to fix the tiOPF unit tests ages ago, that way I would have detected the bug much earlier. :) I'll get another update of Fixes branch, thanks Joost!

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety : second proposition

2008-08-07 Thread Micha Nelissen
Inoussa OUEDRAOGO wrote: - TAVLManagedTree that uses a node mem manager provided in the constructor. The developer using this one is _aware_ of the thread safety issue and can then provide a thread safe node mem manager for an instance exposed What is exactly the add-on value for the nod

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety : second proposition

2008-08-07 Thread Inoussa OUEDRAOGO
2008/8/7 Micha Nelissen <[EMAIL PROTECTED]>: > Inoussa OUEDRAOGO wrote: >> >> - TAVLManagedTree that uses a node mem manager provided in the >> constructor. >> The developer using this one is _aware_ of the thread safety issue and >> can >> then provide a thread safe node mem manager for an in

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety : second proposition

2008-08-07 Thread Mattias Gaertner
On Thu, 07 Aug 2008 18:04:32 +0200 Micha Nelissen <[EMAIL PROTECTED]> wrote: > Inoussa OUEDRAOGO wrote: > > - TAVLManagedTree that uses a node mem manager provided in the > > constructor. The developer using this one is _aware_ of the thread > > safety issue and can then provide a thread safe nod

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety : second proposition

2008-08-07 Thread Marco van de Voort
> Inoussa OUEDRAOGO wrote: > > - TAVLManagedTree that uses a node mem manager provided in the constructor. > >The developer using this one is _aware_ of the thread safety issue and > > can > >then provide a thread safe node mem manager for an instance exposed > > What is exactly the add-

Re: [fpc-devel] TAVLTree(avl_tree.pp) thread safety : second proposition

2008-08-07 Thread Micha Nelissen
Marco van de Voort wrote: Inoussa OUEDRAOGO wrote: - TAVLManagedTree that uses a node mem manager provided in the constructor. The developer using this one is _aware_ of the thread safety issue and can then provide a thread safe node mem manager for an instance exposed What is exactly th