Re: [fpc-devel] multi-line strings

2019-10-07 Thread Ben Grasset
On Mon, Oct 7, 2019 at 1:51 PM Sven Barth via fpc-devel < fpc-devel@lists.freepascal.org> wrote: > The code changes themselves are okay and that was all I promised to > review. The problem is I personally don't care about the feature, so other > core devs should give their okay for the feature its

Re: [fpc-devel] multi-line strings

2019-10-07 Thread Sven Barth via fpc-devel
Michael Van Canneyt schrieb am Mo., 7. Okt. 2019, 17:21: > > > On Mon, 7 Oct 2019, Ben Grasset wrote: > > > On Sat, Oct 5, 2019 at 1:37 PM Ryan Joseph wrote: > > > >> I can’t remember what Bens patch did using compiler directives but I > like > >> the Java idea of using the column of the opening

Re: [fpc-devel] multi-line strings

2019-10-07 Thread Ryan Joseph
> On Oct 7, 2019, at 11:10 AM, Ben Grasset wrote: > > As far as "approval", if I recall correctly Sven said he intended to review > it eventually. > Excellent. I’ve already had multiple times I could have used this. Who can we bribe? ;) Regards, Ryan Joseph __

Re: [fpc-devel] multi-line strings

2019-10-07 Thread Michael Van Canneyt
On Mon, 7 Oct 2019, Ben Grasset wrote: On Sat, Oct 5, 2019 at 1:37 PM Ryan Joseph wrote: I can’t remember what Bens patch did using compiler directives but I like the Java idea of using the column of the opening string character as the reference point for indentation. Seems easier. Did the

Re: [fpc-devel] multi-line strings

2019-10-07 Thread Ben Grasset
On Sat, Oct 5, 2019 at 1:37 PM Ryan Joseph wrote: > I can’t remember what Bens patch did using compiler directives but I like > the Java idea of using the column of the opening string character as the > reference point for indentation. Seems easier. > > Did the FPC team even approve this idea yet

Re: [fpc-devel] multi-line strings

2019-10-05 Thread Ryan Joseph
I can’t remember what Bens patch did using compiler directives but I like the Java idea of using the column of the opening string character as the reference point for indentation. Seems easier. Did the FPC team even approve this idea yet? It’s such a simple patch but I fear it’s going to be wai