Re: [fpc-pascal] Default properties first draft

2018-10-22 Thread Ryan Joseph
I just fixed the bug you mentioned ([] default properties getting into my code paths) so feel free to test again. https://github.com/genericptr/freepascal/tree/defaultprops I also temporarily added some test units so you can see how far I’ve gotten testing them.

Re: [fpc-pascal] Default properties first draft

2018-10-20 Thread Ryan Joseph
Thanks Ben. I didn't want to submit a patch file yet (not that I know how anyways) because I don’t think it’s complete and perhaps it’s not even on the right track in terms of implementation. The compiler team seems busy now anyways so I guess this will just have to wait. I didn’t do any

Re: [fpc-pascal] Default properties first draft

2018-10-20 Thread Ben Grasset
AFAIK you need to submit a ".patch" file with your changes against the most recent trunk revision to the bugtracker (with the category set to "patch", obviously.) I doubt it'll get considered seriously or looked at at all otherwise. For what it's worth, I did do a checkout of your branch and then

[fpc-pascal] Default properties first draft

2018-10-19 Thread Ryan Joseph
I finally finished what I think is first draft of default properties. Since it already took me so much time to just get the basics of the compiler figured out I thought I’d post this commit from GitHub and ask if I did anything seriously wrong or stupid. There are multiple ways I could approach