On Feb 5, 2009, at 10:44 PM, Hanno Schlichting wrote:
Andreas Zeidler wrote:
in short: i'm +1 for merging, but PLT has an error which needs to be
fixed before the next release. it's not related to the changes,
though.
Can you add a ticket for the bug you encountered? From the review
note
On Feb 5, 2009, at 10:41 PM, Hanno Schlichting wrote:
I haven't looked at the code, but why restrict this to those container
interfaces alone? Isn't some IContainer or OFS-level interface all
that
is required? Once the Plone site root is supported, the code likely
doesn't rely on any of the AT
Andreas Zeidler wrote:
> On Jan 18, 2009, at 2:44 PM, Hanno Schlichting wrote:
>> I'm somewhat late with creating the review buildout for PLIP 237 (Minor
>> i18n upgrades) at:
>> https://svn.plone.org/svn/plone/review/plip237-minor-i18n-upgrades/
>>
>> The review notes and detailed explanation is f
Andreas Zeidler wrote:
> On Feb 5, 2009, at 9:48 PM, Andreas Zeidler wrote:
>> This however, resulted in a 404. It turned out, that the view was only
>> registered for IATFolder and IPloneSiteRoot, but not for `Large Plone
>> Folder`
>> a.ka. IATBTreeFolder. I took the liberty of `fixing this mysel
On Feb 5, 2009, at 10:06 PM, Wichert Akkerman wrote:
Interesting, that is not how I interpret a +1 at all. To me there
are two possible outcomes right now: declare a PLIP ready for
merging, or declare it unready for merging for a number of reasons.
perhaps to clarify a bit: my +1 actually m
On Feb 5, 2009, at 9:48 PM, Andreas Zeidler wrote:
[...] otoh, all reviewers should have informed the PLIP authors via
cc (or at least i hope so!?) so they know about these (minor) issues.
as for 246, i'm especially +1 and will comment on your review notes
in the next mail... :)
heh, gotch
On 2/5/09 9:45 AM, Raphael Ritz wrote:
Andreas Zeidler wrote:
hi wichert,
On Feb 4, 2009, at 10:11 AM, Wichert Akkerman wrote:
The deadline for the PLIP review report was four days ago. From what I
can see not all reviews are in, and no report has been written yet.
Can I please get a prop
On Feb 5, 2009, at 9:45 AM, Raphael Ritz wrote:
I don't know how other reviewers see this but
at least I didn't consider my positive responses
in all cases to mean "ready for merge" as we are
entering a second round now: authors picking up
on reviewer comments.
+1
Example:
http://svn.plone.or
On Feb 5, 2009, at 9:29 PM, Andreas Zeidler wrote:
[...snip...]
yes, that works. in any case this should be documented, though.
[...snip again...]
Perhaps z3c.autoinclude could check if
`os.environ.has_key('Z3C_AUTOINCLUDE_DISABLED')` and the test
runner and/or a buildout option could set
On Feb 5, 2009, at 6:35 PM, Ethan Jucovy wrote:
Hey Andi,
hi ethan,
Thanks for the review.
thanks for the quick reply! :)
Again I'll have to be a bit brief, this time because I'm about to
get on a plane. :) But I figured I may as well give some quick
replies to keep the conversation g
Hey Andi,
Thanks for the review. Again I'll have to be a bit brief, this time because
I'm about to get on a plane. :) But I figured I may as well give some quick
replies to keep the conversation going. Let me know if I should be putting
these comments in SVN or on
http://plone.org/products/plon
On Jan 17, 2009, at 2:37 AM, Ethan Jucovy wrote:
Hello,
hi ethan,
I've implemented PLIP #247, Automate ZCML Loading for Plone Plugins (http://plone.org/products/plone/roadmap/247
) and committed a review buildout here:
https://svn.plone.org/svn/plone/review/plip247-automate-plugin-zcml
for
Andreas Zeidler wrote:
hi wichert,
On Feb 4, 2009, at 10:11 AM, Wichert Akkerman wrote:
The deadline for the PLIP review report was four days ago. From what I
can see not all reviews are in, and no report has been written yet.
Can I please get a proper report which covers the PLIPs tha
13 matches
Mail list logo
