Re: [Framework-Team] PLIP #241 ready for review

2009-01-27 Thread Andreas Zeidler
On Jan 21, 2009, at 12:37 PM, Martijn Pieters wrote: On Sun, Jan 18, 2009 at 01:20, Andreas Zeidler a...@zitc.de wrote: the review bundle for PLIP 241 (Clean up auto-sort, auto-order code) is ready for review. you can get it from

Re: [Framework-Team] Re: PLIP review deadline has passed - time to review!

2009-01-27 Thread Andreas Zeidler
On Jan 20, 2009, at 6:03 PM, Florian Schulze wrote: I just realized that my mails never made it to this list. I worked on this PLIP last week and forgot about the review bundle. I did the review bundle on the same day I was informed by Andi about this and replied to Andis mail, but my mails

Re: [Framework-Team] Re: NuPlone and Plone 3.2

2009-01-27 Thread Andreas Zeidler
On Jan 13, 2009, at 12:01 AM, Martin Aspeli wrote: Martin Aspeli wrote: Why on earth is Products.NuPlone not in the Plone 3.2 egg? Is this in purpose or just a gross oversight? Ok, I've released Products.NuPlone 1.0b3. you got the release year wrong, but that's just a minor detail... apart

Re: [Framework-Team] Re: NuPlone and Plone 3.2

2009-01-27 Thread Wichert Akkerman
On 1/27/09 1:28 PM, Andreas Zeidler wrote: On Jan 13, 2009, at 12:01 AM, Martin Aspeli wrote: Martin Aspeli wrote: Why on earth is Products.NuPlone not in the Plone 3.2 egg? Is this in purpose or just a gross oversight? Ok, I've released Products.NuPlone 1.0b3. you got the release year

Re: [Framework-Team] Re: PLIP review deadline has passed - time to review!

2009-01-27 Thread Danny Bloemendaal
On 20 jan 2009, at 23:08, Martijn Pieters wrote: On Tue, Jan 20, 2009 at 21:43, Andreas Zeidler a...@zitc.de wrote: Do whatever you feel is right considering that I missed the deadline. personally i think it'd be stupid to not consider changes that were ready for a while now. i mean,

Re: [Framework-Team] PLIP Tallies

2009-01-27 Thread Andreas Zeidler
On Jan 27, 2009, at 1:35 PM, Danny Bloemendaal wrote: On 19 jan 2009, at 15:28, Tom Lazar wrote: @danny: could you mark which tickets you will review for UI impact? perhaps by making an X for those where you will and an explicit - for those which don't have any. Yes, I will. I'm already

Re: [Framework-Team] PLIP #240 ready for review

2009-01-27 Thread Erik Rose
I actually first implemented it exactly that way (even called it IRefreshableLockable), then wondered if the complexity was worth it. I can go either way, but would like to hear some other opinions of best practice in a case like this. For what a non-3.x-FWT opinion is worth, I'd rather

Re: [Framework-Team] PLIP #240 ready for review

2009-01-27 Thread Martijn Pieters
On Tue, Jan 27, 2009 at 18:12, Erik Rose psuc...@grinchcentral.com wrote: I actually first implemented it exactly that way (even called it IRefreshableLockable), then wondered if the complexity was worth it. I can go either way, but would like to hear some other opinions of best practice in a

Re: [Framework-Team] PLIP #126 ready for review

2009-01-27 Thread Danny Bloemendaal
Ok, I reviewed this plip and these are my findings: PLIP 126 framework review #3 by Danny Bloemendaal, 2009-01-27 = review steps the bundle was reviewed on OSX 10.5.6 doing the following: * bundle checkout, buildout

Re: [Framework-Team] PLIP #126 ready for review

2009-01-27 Thread Danny Bloemendaal
On 27 jan 2009, at 20:19, Danny Bloemendaal wrote: As admin I also visited the folder and the navtree links me to the Link object while the folder listing redirects me to the target url. An additional remark. I notice the consideration in the readme for not adapting the various views that

Re: [Framework-Team] PLIP #126 ready for review

2009-01-27 Thread David Glick
On Jan 27, 2009, at 11:19 AM, Danny Bloemendaal wrote: notes and observations -- I reviewed this plip from a UI perspective of course. So I started by creating a folder as admin with a Link in there. Published both items. In another browser I visited as an anonymous

Re: [Framework-Team] PLIP #234 ready for initial review

2009-01-27 Thread Andreas Zeidler
hi calvin, On Dec 5, 2008, at 11:58 PM, Calvin Hendryx-Parker wrote: On Dec 5, 2008, at 5:41 PM, Andreas Zeidler wrote: a short discussion with calvin and hanno resulted in a sample buildout[*], which PLIP authors can use as a starting point for their plone 3.3 review bundles (and probably

Re: [Framework-Team] PLIP #126 ready for review

2009-01-27 Thread Danny Bloemendaal
On 27 jan 2009, at 21:07, David Glick wrote: On Jan 27, 2009, at 11:19 AM, Danny Bloemendaal wrote: notes and observations -- I reviewed this plip from a UI perspective of course. So I started by creating a folder as admin with a Link in there. Published both items. In

Re: [Framework-Team] PLIP #240 ready for review

2009-01-27 Thread Danny Bloemendaal
Ok, I reviewed this plip and did some tests with ttw locking and indeed it seems to work. I leave all the technical review stuff to people with brains. I have a remark for the help text below Enable locking for through- the-web edits though. I think that the line Disabling locking here will