Re: [Framework-Team] PLIP #240 ready for review

2009-01-25 Thread Martijn Pieters
On Sat, Jan 17, 2009 at 00:04, Andrew Burkhalter wrote: > PLIP 240 (Improve locking configurability) has been implemented. You > can get the review buildout from: > https://svn.plone.org/svn/plone/review/plip240-locking-improvements/ This PLIP gets a +1 from me. I've looked at the code changes

Re: [Framework-Team] PLIP #239 ready for review

2009-01-25 Thread Martijn Pieters
On Sun, Jan 11, 2009 at 18:56, Martin Aspeli wrote: > I've just finished the base implementation of PLIP #239, adapterise the > ExtensibleIndexableObjectWrapper, for your review. This PLIP gets my +1. As usual, Martin delivers. Great implementation, great documentation. I did add one sentence to

Re: [Framework-Team] PLIP #240 ready for review

2009-01-25 Thread David Glick
On Jan 25, 2009, at 4:09 AM, Martijn Pieters wrote: On Sat, Jan 17, 2009 at 00:04, Andrew Burkhalter wrote: PLIP 240 (Improve locking configurability) has been implemented. You can get the review buildout from: https://svn.plone.org/svn/plone/review/plip240-locking-improvements/ This PLIP g

Re: [Framework-Team] PLIP #247 ready for review (I think)

2009-01-25 Thread Martijn Pieters
On Sat, Jan 17, 2009 at 02:37, Ethan Jucovy wrote: > I've implemented PLIP #247, Automate ZCML Loading for Plone Plugins > (http://plone.org/products/plone/roadmap/247) and committed a review > buildout here: > https://svn.plone.org/svn/plone/review/plip247-automate-plugin-zcml > for your review.

Re: [Framework-Team] PLIP #247 ready for review (I think)

2009-01-25 Thread Martijn Pieters
On Sat, Jan 17, 2009 at 02:37, Ethan Jucovy wrote: > I've implemented PLIP #247, Automate ZCML Loading for Plone Plugins > (http://plone.org/products/plone/roadmap/247) and committed a review > buildout here: > https://svn.plone.org/svn/plone/review/plip247-automate-plugin-zcml > for your review.

Re: [Framework-Team] PLIP #126 ready for review

2009-01-25 Thread Andreas Zeidler
On Jan 13, 2009, at 1:37 AM, David Glick wrote: PLIP 126 (Link type should automatically redirect when accessed directly) has been implemented. i've added my review notes in http://dev.plone.org/plone/changeset/24687 in short: very nice, +1 for merging. thanks david and andrew! cheers, an