On Feb 10, 2009, at 6:55 AM, Calvin Hendryx-Parker wrote:
Hi Team,
hi calvin,
I just committed my revisions based on the initial review of PLIP 234.
thanks!
I believe I have addressed all of the concerns brought up by the
reviewers.
unfortunately i won't have enough time left to look a
On Feb 12, 2009, at 1:05 PM, Andreas Zeidler wrote:
[...] i did notice that test (which is why i added "almost" in
"almost none of the changes are actually tested" ;)), but found that
one was far from enough. anyway, tom will make sure there are
enough now... ;)
that said i couldn't resis
On Feb 12, 2009, at 1:19 PM, Andreas Zeidler wrote:
of course the other case, i.e. having the nav-root _at_ the site
root like it is the default in plone, is already well-tested and not
the scope of this PLIP anyway. but i don't think many people have
actually used this feature before (as i
On Feb 7, 2009, at 12:56 AM, Ethan Jucovy wrote:
On Thu, Feb 5, 2009 at 3:37 PM, Andreas Zeidler wrote:
On Feb 5, 2009, at 9:29 PM, Andreas Zeidler wrote:
i noticed that. in fact, i was trying to figure out how the
assigned value ("plone") ended up in `module_name`. i
ended up looked at the
hi,
i've just had a look at the updates for all the PLIPs i originally
reviewed and sent some comments. i won't be available for any further
discussion as well as the ultimate counting etc, though, as we're
leaving for vacation tomorrow. i'd appreciate if someone from the
team could tak
On Feb 12, 2009, at 7:19 AM, Andreas Zeidler wrote:
of course the other case, i.e. having the nav-root _at_ the site
root like it is the default in plone, is already well-tested and not
the scope of this PLIP anyway. but i don't think many people have
actually used this feature before (as
Andreas Zeidler wrote:
hi,
i've just had a look at the updates for all the PLIPs i originally
reviewed and sent some comments. i won't be available for any further
discussion as well as the ultimate counting etc, though, as we're
leaving for vacation tomorrow. i'd appreciate if someone f
Calvin Hendryx-Parker wrote:
I'd be open for suggestions for other tests. A majority of the fixes
were templates and they were to use an already existing bit of code
functionality that I didn't add like you said. The viewlets were
modified to support this and I have the test to confirm it
Martin Aspeli wrote:
[..]
FWIW, I think much of Calvin's work could've gone into a 3.2.x release
as bug fixes. If he doesn't break tests, and writes a few tests for
truly new code, then I think that's probably sufficient in most places.
Personally, I agree with the sentiment that this is most
On Feb 12, 2009, at 3:10 PM, Raphael Ritz wrote:
Martin Aspeli wrote:
[..]
FWIW, I think much of Calvin's work could've gone into a 3.2.x
release as bug fixes. If he doesn't break tests, and writes a few
tests for truly new code, then I think that's probably sufficient
in most places.
Pe
Andreas Zeidler wrote:
[..]
i didn't mean to imply that not having more tests is a strict
showstopper. please don't get me wrong here. i do appreciate
calvin's work and all the fixes he put in to finally make this feature
work. hunting the bug must have been cumbersome enough... however,
On 12.02.2009, at 13:19, Andreas Zeidler wrote:
On Feb 12, 2009, at 1:05 PM, Andreas Zeidler wrote:
[...] i did notice that test (which is why i added "almost" in
"almost none of the changes are actually tested" ;)), but found
that one was far from enough. anyway, tom will make sure there a
On Feb 12, 2009, at 11:24 PM, Tom Lazar wrote:
Can I guarantee that it absolutely won't break anything? No. Am I
convinced that Plone is better
with this PLIP than without it? Yes :-)
:)
andi
--
zeidler it consulting - http://zitc.de/ - i...@zitc.de
friedelstraße 31 - 12047 berlin - telefo
13 matches
Mail list logo
