Re: [Framework-Team] Re: PLIP: Template overrides
> I'd like to see some more detail on this PLIP. Currently, it seems to > assume the reader is familiar with z3c.jbot, or requires the reviewer > to exaimine the jbot code/docs (which is an burden better left for the > code review phase). Of course my opinion is irrelevant. Also, I'm > very much in favor of easier template customization, provided it's > still relatively easy to figure out where a particular template/view > is coming from. I added some descriptive paragraphs the PLIP on how the approach works. You might also want to see the original post for reference: http://mockit.blogspot.com/2007/11/viewlets-are-simple-again.html \malthe ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: PLIP: Template overrides
I tot On 14 dec 2007, at 18:52, Alec Mitchell wrote: On Dec 14, 2007 7:56 AM, Malthe Borch <[EMAIL PROTECTED]> wrote: so, while i also like the idea, i'm not too sure if plone should ship with it. i'd agree with martin we should discuss and think this through a little further. nevertheless, i don't see why the plip wouldn't be acceptable, so +1 on that. True. I say, let's think of z3c.jbot as inspiration and then accept the PLIP that we need some easy way of customizing the default plone skin. I'd like to see some more detail on this PLIP. Currently, it seems to assume the reader is familiar with z3c.jbot, or requires the reviewer to exaimine the jbot code/docs (which is an burden better left for the code review phase). Of course my opinion is irrelevant. Also, I'm very much in favor of easier template customization, provided it's still relatively easy to figure out where a particular template/view is coming from. Alec I totally agree with Alec here. Since my acquired middle name these days is Customize, i'm very curious about what this plip means. Could someone elaborate a bit on this please? Danny Customize Bloemendaal ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: PLIP: Template overrides
On 14/12/2007, Alec Mitchell <[EMAIL PROTECTED]> wrote: > On Dec 14, 2007 7:56 AM, Malthe Borch <[EMAIL PROTECTED]> wrote: > > > so, while i also like the idea, i'm not too sure if plone should ship > > > with it. i'd agree with martin we should discuss and think this through > > > a little further. nevertheless, i don't see why the plip wouldn't be > > > acceptable, so +1 on that. > > > > True. I say, let's think of z3c.jbot as inspiration and then accept the > > PLIP that we need some easy way of customizing the default plone skin. > > I'd like to see some more detail on this PLIP. Currently, it seems to > assume the reader is familiar with z3c.jbot, or requires the reviewer > to exaimine the jbot code/docs (which is an burden better left for the > code review phase). Of course my opinion is irrelevant. Also, I'm > very much in favor of easier template customization, provided it's > still relatively easy to figure out where a particular template/view > is coming from. IMHO, a very useful secondary element to this PLIP would be some improved discovery mechanisms, e.g. a view that you could use to discover which templates were being used and where they were registered in a given context. Martin ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: PLIP: Template overrides
On Dec 14, 2007 7:56 AM, Malthe Borch <[EMAIL PROTECTED]> wrote: > > so, while i also like the idea, i'm not too sure if plone should ship > > with it. i'd agree with martin we should discuss and think this through > > a little further. nevertheless, i don't see why the plip wouldn't be > > acceptable, so +1 on that. > > True. I say, let's think of z3c.jbot as inspiration and then accept the > PLIP that we need some easy way of customizing the default plone skin. I'd like to see some more detail on this PLIP. Currently, it seems to assume the reader is familiar with z3c.jbot, or requires the reviewer to exaimine the jbot code/docs (which is an burden better left for the code review phase). Of course my opinion is irrelevant. Also, I'm very much in favor of easier template customization, provided it's still relatively easy to figure out where a particular template/view is coming from. Alec ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: PLIP: Template overrides
so, while i also like the idea, i'm not too sure if plone should ship with it. i'd agree with martin we should discuss and think this through a little further. nevertheless, i don't see why the plip wouldn't be acceptable, so +1 on that. True. I say, let's think of z3c.jbot as inspiration and then accept the PLIP that we need some easy way of customizing the default plone skin. \malthe ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: PLIP: Template overrides
On Dec 14, 2007 1:50 AM, Martin Aspeli <[EMAIL PROTECTED]> wrote: > Malthe Borch wrote: > > If this belongs in Plone, then it's pretty much ready for inclusion. > > > >http://plone.org/products/plone/roadmap/216 > > I do quite like this approach. I think it brings back some of the > "convention over configuration" we've been moving away from. > Does this conflict in any way with CacheFu? I say that because IIRC it > monkey patches pt_render() and IIRC so does CacheFu. Not a criticism, > just something to watch out for. By the looks of it it wraps the pt_render that's there. As long as CacheFu does the same thing, they can co-exist just fine. Only when one or the other discards the original method and replaces it completely do we have a problem, but only if the ordering is out. */me checks*. At a quick glance CacheSetup does store the old method for calling, but only calls it when caching is disabled. In other words, it wraps the pt_render it finds there, but ignores it when caching is enabled. Could the PLIP address this and make sure it's patch is not going to get botched by CacheFu? Pre-emptively import CacheFu's patches would already work around this, for example. > My only concern would be whether this ties us into an implementation > that we could want to solve differently in the future, e.g. using named > template adapters. Again, not a criticism, it just needs to be thought > through. I don't see any reason why the two approaches can't compliment each other. -- Martijn Pieters ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: PLIP: Template overrides
On Dec 14, 2007, at 1:50 AM, Martin Aspeli wrote: Malthe Borch wrote: If this belongs in Plone, then it's pretty much ready for inclusion. http://plone.org/products/plone/roadmap/216 customerize on the fs, so to say, nice! :) My only concern would be whether this ties us into an implementation that we could want to solve differently in the future, e.g. using named template adapters. Again, not a criticism, it just needs to be thought through. while named template adapters would immensely simplify things for customerize among other things, and i'd therefore be much in favour of them, i guess this way of customizing could also be adapted to work with them, should they be introduced later on. right, malthe? otoh, as malthe points out, it might cause even more confusion about where to start with all that new stuff ever since 3.0... so, while i also like the idea, i'm not too sure if plone should ship with it. i'd agree with martin we should discuss and think this through a little further. nevertheless, i don't see why the plip wouldn't be acceptable, so +1 on that. andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.4 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: PLIP: Template overrides
Malthe Borch wrote: If this belongs in Plone, then it's pretty much ready for inclusion. http://plone.org/products/plone/roadmap/216 I do quite like this approach. I think it brings back some of the "convention over configuration" we've been moving away from. Does this conflict in any way with CacheFu? I say that because IIRC it monkey patches pt_render() and IIRC so does CacheFu. Not a criticism, just something to watch out for. My only concern would be whether this ties us into an implementation that we could want to solve differently in the future, e.g. using named template adapters. Again, not a criticism, it just needs to be thought through. Martin -- Author of `Professional Plone Development`, a book for developers who want to work with Plone. See http://martinaspeli.net/plone-book ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
