Re: improve cx_lowest logic

2012-09-05 Thread Kevin Oberman
On Tue, Sep 4, 2012 at 11:28 PM, Andriy Gapon a...@freebsd.org wrote: on 25/08/2012 13:52 Vitaly Magerya said the following: On 08/07/2012, Andriy Gapon a...@freebsd.org wrote: I would like to propose the following change for review and testing:

Re: improve cx_lowest logic

2012-09-05 Thread Kevin Oberman
On Wed, Sep 5, 2012 at 9:12 AM, Andriy Gapon a...@freebsd.org wrote: on 05/09/2012 18:17 Kevin Oberman said the following: Thanks so much! This should finally make Cx states work on my ThinkPad! I really appreciate it. Guess it's time to do my weekly upgrade of this system. I haven't sneaked

Re: improve cx_lowest logic

2012-09-05 Thread Andriy Gapon
on 05/09/2012 19:23 Kevin Oberman said the following: On Wed, Sep 5, 2012 at 9:12 AM, Andriy Gapon a...@freebsd.org wrote: on 05/09/2012 18:17 Kevin Oberman said the following: Thanks so much! This should finally make Cx states work on my ThinkPad! I really appreciate it. Guess it's time to do

Re: improve cx_lowest logic

2012-09-05 Thread Kevin Oberman
On Wed, Sep 5, 2012 at 9:32 AM, Andriy Gapon a...@freebsd.org wrote: on 05/09/2012 19:23 Kevin Oberman said the following: On Wed, Sep 5, 2012 at 9:12 AM, Andriy Gapon a...@freebsd.org wrote: on 05/09/2012 18:17 Kevin Oberman said the following: Thanks so much! This should finally make Cx

Re: improve cx_lowest logic

2012-09-05 Thread Andriy Gapon
on 05/09/2012 20:41 Kevin Oberman said the following: On Wed, Sep 5, 2012 at 9:32 AM, Andriy Gapon a...@freebsd.org wrote: on 05/09/2012 19:23 Kevin Oberman said the following: On Wed, Sep 5, 2012 at 9:12 AM, Andriy Gapon a...@freebsd.org wrote: on 05/09/2012 18:17 Kevin Oberman said the

Re: improve cx_lowest logic

2012-07-13 Thread Andriy Gapon
on 10/07/2012 18:49 Sean Bruno said the following: On Sun, 2012-07-08 at 03:22 -0700, Andriy Gapon wrote: I would like to propose the following change for review and testing: http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff Very nice. After a review I went ahead and applied it for

Re: improve cx_lowest logic

2012-07-11 Thread Ian Smith
On Tue, 10 Jul 2012 09:31:26 -0700, Sean Bruno wrote: On Tue, 2012-07-10 at 07:27 -0700, Ian Smith wrote: I wonder if that explains why setting C3 on aforesaid T23 has no effect (in terms of dev.cpu.0.cx_usage indicating any time spent in C3) unless the machine happened to be

Re: improve cx_lowest logic

2012-07-10 Thread Ian Smith
On Sun, 8 Jul 2012 13:22:49 +0300, Andriy Gapon wrote: I would like to propose the following change for review and testing: http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff The idea is to separate effective cx_lowest (the limit that the idling code should not currently exceed)

Re: improve cx_lowest logic

2012-07-10 Thread Sean Bruno
On Sun, 2012-07-08 at 03:22 -0700, Andriy Gapon wrote: I would like to propose the following change for review and testing: http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff Very nice. After a review I went ahead and applied it for testing. All seems to be well on battery and A/C on my

Re: improve cx_lowest logic

2012-07-10 Thread Sean Bruno
On Tue, 2012-07-10 at 07:27 -0700, Ian Smith wrote: I wonder if that explains why setting C3 on aforesaid T23 has no effect (in terms of dev.cpu.0.cx_usage indicating any time spent in C3) unless the machine happened to be booted up on battery, in which case C3 is shown as working

Re: improve cx_lowest logic

2012-07-09 Thread Giovanni Trematerra
On Sun, Jul 8, 2012 at 12:22 PM, Andriy Gapon a...@freebsd.org wrote: I would like to propose the following change for review and testing: http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff It seems good to me. -- Gianni ___