On Sun, 30 Dec 2001, Poul-Henning Kamp wrote:
In message [EMAIL PROTECTED], Maxim Konovalov wr
ites:
Ohh and I forgot: Thanks for the patch! Tested Committed :-)
Junior committer task: fix style bugs in submitted patches before committing.
Bruce
To Unsubscribe: send mail to [EMAIL
On Sun, 30 Dec 2001, Maxim Konovalov wrote:
On 15:04+0200, Dec 30, 2001, Sheldon Hearn wrote:
Note that you don't need to (and shouldn't as per style(9)) initialize
tmppath to NULL.
Do you mean:
: Be careful to not obfuscate the code by initializing variables
: in the
Hello,
On 12:23+0100, Dec 30, 2001, Poul-Henning Kamp wrote:
sys/dev/ccd/ccd.c:ccdinit() has a couple of very large items on
the stack.
Rewrite ccdinit() to allocate them with MALLOC(9) instead.
tmppath is a rather big one but I can't find the second item. What
about this patch:
Index:
[Chad David copied for last comment in message.]
On Sun, 30 Dec 2001 15:28:23 +0300, Maxim Konovalov wrote:
sys/dev/ccd/ccd.c:ccdinit() has a couple of very large items on
the stack.
Rewrite ccdinit() to allocate them with MALLOC(9) instead.
tmppath is a rather big one but I can't
On Sun, 30 Dec 2001 16:45:31 +0300, Maxim Konovalov wrote:
struct partinfo holds only two pointers, ccg is a pointer too.
I got confused with partinfo and disklabel, and didn't actually check
ccg. *blush*
Note that you don't need to (and shouldn't as per style(9)) initialize
tmppath to
In message [EMAIL PROTECTED], Maxim Konovalov wr
ites:
tmppath is a rather big one but I can't find the second item. What
about this patch:
I think the others are the partinfo and ccdgeom structures.
struct partinfo holds only two pointers, ccg is a pointer too.
I meant partinfo, but I
In message [EMAIL PROTECTED], Maxim Konovalov wr
ites:
Ohh and I forgot: Thanks for the patch! Tested Committed :-)
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
[EMAIL PROTECTED] | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to
