t; > > While this is indeed a good thing to do, this is completely
> > > > unrelated to the above mentioned problem, and should be done
> > > > separately. Here's the list of src/ files that do not check the
> > > > return value of initgroups(3), and m
> unrelated to the above mentioned problem, and should be done
> > > separately. Here's the list of src/ files that do not check the
> > > return value of initgroups(3), and may need to be fixed, but some
> > > of them explicitly ignore the result to indicate the fa
> this PR) and he said that src/ must be audited also -- he said that
> > > some initgroups() callers do not print error message because
> > > initgroups() did this previously.
> > >
> > > I'll try to do this before this weekend and I will post combin
On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote:
> On Mon, Nov 19, 2001 at 10:28:55PM +0600, Max Khon wrote:
> > I asked tobez (he is an originator and he took responsibility on
> > this PR) and he said that src/ must be audited also -- he said that
> > some
===
> > RCS file: /home/ncvs/src/lib/libc/gen/initgroups.c,v
> > retrieving revision 1.4
> > diff -u -p -r1.4 initgroups.c
> > --- initgroups.c2001/08/29 13:52:26 1.4
> > +++ initgroups.c2001/11/19 16:16:11
> > @@ -56,1
--- initgroups.c 2001/08/29 13:52:26 1.4
> +++ initgroups.c 2001/11/19 16:16:11
> @@ -56,12 +56,6 @@ initgroups(uname, agroup)
> int groups[NGROUPS], ngroups;
>
> ngroups = NGROUPS;
> - if (getgrouplist(uname, agroup, groups, &ngroups) < 0)
g revision 1.4
diff -u -p -r1.4 initgroups.c
--- initgroups.c2001/08/29 13:52:26 1.4
+++ initgroups.c2001/11/19 16:16:11
@@ -56,12 +56,6 @@ initgroups(uname, agroup)
int groups[NGROUPS], ngroups;
ngroups = NGROUPS;
- if (getgrouplist(uname, agroup, groups, &
On 13-Nov-01 Terry Lambert wrote:
> John Baldwin wrote:
>> >> return (setgruops(ngroups, groups));
>> > return (setgroups(ngroups, groups));
>> >
>> > (avoiding cut-and-paste error).
>>
>> Yes, my mailer eats tabs and sucks as is well documented, the point was the
>> ()'s. :)
>
John Baldwin wrote:
> >> return (setgruops(ngroups, groups));
> > return (setgroups(ngroups, groups));
> >
> > (avoiding cut-and-paste error).
>
> Yes, my mailer eats tabs and sucks as is well documented, the point was the
> ()'s. :)
I didn't fix the tabs; I fixed the typo; I li
On 13-Nov-01 Terry Lambert wrote:
> John Baldwin wrote:
>> > + return setgroups(ngroups, groups);
>> > }
>>
>> Style nit:
>>
>> return (setgruops(ngroups, groups));
>
>
> return (setgroups(ngroups, groups));
>
> (avoiding cut-and-paste error).
Yes, my mailer eats tabs a
John Baldwin wrote:
> > + return setgroups(ngroups, groups);
> > }
>
> Style nit:
>
> return (setgruops(ngroups, groups));
return (setgroups(ngroups, groups));
(avoiding cut-and-paste error).
-- Terry
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe free
Max Khon wrote:
>
> hi, there!
>
> Any objections if I will commit the following patch (see PR/15421)?
Can setgroups return a positive number? If so, you've just changed
the semantics of the funtion; before, it used to return 0 on 0 or a
positive number.
Also, is removing the _warn() really t
On Wed, Nov 14, 2001 at 02:19:56AM +0600, Max Khon wrote:
> Any objections if I will commit the following patch (see PR/15421)?
Does the man page need a note about setting errno?
David.
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the
On 13-Nov-01 Max Khon wrote:
> hi, there!
>
> Any objections if I will commit the following patch (see PR/15421)?
>
> Index: initgroups.c
> ===
> RCS file: /home/ncvs/src/lib/libc/gen/initgroups.c,v
> retrieving revision 1.4
> diff
hi, there!
Any objections if I will commit the following patch (see PR/15421)?
Index: initgroups.c
===
RCS file: /home/ncvs/src/lib/libc/gen/initgroups.c,v
retrieving revision 1.4
diff -u -r1.4 initgroups.c
--- initgroups.c2
15 matches
Mail list logo
