Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-22 Thread John Baldwin
On Tuesday, August 21, 2012 7:16:30 pm Slawa Olhovchenkov wrote: On Tue, Aug 21, 2012 at 05:25:23PM -0400, John Baldwin wrote: On Tuesday, August 21, 2012 9:34:31 am John Baldwin wrote: On Tuesday, August 21, 2012 7:53:08 am Lev Serebryakov wrote: Hello, Garrett. You wrote 21

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-22 Thread Slawa Olhovchenkov
On Wed, Aug 22, 2012 at 08:43:52AM -0400, John Baldwin wrote: On Tuesday, August 21, 2012 7:16:30 pm Slawa Olhovchenkov wrote: On Tue, Aug 21, 2012 at 05:25:23PM -0400, John Baldwin wrote: On Tuesday, August 21, 2012 9:34:31 am John Baldwin wrote: On Tuesday, August 21, 2012 7:53:08

r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, Garrett. You wrote 21 августа 2012 г., 15:18:05: GC Try reverting r239356 -- if that works, then please let jhb@ know. I'm confused by this commit, because it seems (from comment alone), that dhclient will not work without devd anymore (with synchronous dhcp option in rc.conf). Am I

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, Lev. You wrote 21 августа 2012 г., 15:40:35: GC Try reverting r239356 -- if that works, then please let jhb@ know. LS I'm confused by this commit, because it seems (from comment alone), LS that dhclient will not work without devd anymore (with synchronous LS dhcp option in rc.conf).

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, Garrett. You wrote 21 августа 2012 г., 15:40:35: GC Try reverting r239356 -- if that works, then please let jhb@ know. LS I'm confused by this commit, because it seems (from comment alone), LS that dhclient will not work without devd anymore (with synchronous LS dhcp option in

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Slawa Olhovchenkov
On Tue, Aug 21, 2012 at 03:45:48PM +0400, Lev Serebryakov wrote: Hello, Lev. You wrote 21 августа 2012 г., 15:40:35: GC Try reverting r239356 -- if that works, then please let jhb@ know. LS I'm confused by this commit, because it seems (from comment alone), LS that dhclient will not

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread John Baldwin
On Tuesday, August 21, 2012 7:53:08 am Lev Serebryakov wrote: Hello, Garrett. You wrote 21 августа 2012 г., 15:40:35: GC Try reverting r239356 -- if that works, then please let jhb@ know. LS I'm confused by this commit, because it seems (from comment alone), LS that dhclient will not

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, John. You wrote 21 августа 2012 г., 17:34:31: JB Humm. devd is the more common case, and we explicitly don't use devd to start JB dhclient on boot even when devd is enabled (so out of the box dhcp would first JB be started by rc, but would be restarted by devd). It is strange, and,

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Ian Lepore
On Tue, 2012-08-21 at 19:04 +0400, Lev Serebryakov wrote: Hello, John. You wrote 21 августа 2012 г., 17:34:31: JB Humm. devd is the more common case, and we explicitly don't use devd to start JB dhclient on boot even when devd is enabled (so out of the box dhcp would first JB be

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, Ian. You wrote 21 августа 2012 г., 19:16:03: IL It has worked this way for me for years. Does it somehow not work this IL way for everyone? Please, read comment to r239356. Starting from this revision dhclient exists on interface down and _remiove_ IP address from interface. Removal

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Ian Lepore
On Tue, 2012-08-21 at 19:26 +0400, Lev Serebryakov wrote: Hello, Ian. You wrote 21 августа 2012 г., 19:16:03: IL It has worked this way for me for years. Does it somehow not work this IL way for everyone? Please, read comment to r239356. Starting from this revision dhclient exists on

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, Ian. You wrote 21 августа 2012 г., 19:55:07: IL I don't know what teardown the configured lease in that comment means, IL but it doesn't mean that the interface loses its current configuration, IL or that any existing connections are perturbed. Sorry, but comment in PR:

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread olli hauer
On 2012-08-21 13:45, Lev Serebryakov wrote: Hello, Lev. You wrote 21 августа 2012 г., 15:40:35: GC Try reverting r239356 -- if that works, then please let jhb@ know. LS I'm confused by this commit, because it seems (from comment alone), LS that dhclient will not work without devd

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Ian Lepore
On Tue, 2012-08-21 at 21:01 +0400, Lev Serebryakov wrote: IL The important point is that if you unplug the cable then plug it into a IL different network, now the right thing will happen -- you will acquire IL an address on the new network. That's the reason that this change is an IL

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, Ian. You wrote 21 августа 2012 г., 21:36:30: IL Perhaps the right solution is to add a dhclient command line option to IL operate in the historical buggy mode: it doesn't exit on link status IL changes, and fails to work properly if those link status changes are IL happening because the

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, Ian. You wrote 21 августа 2012 г., 21:36:30: IL I think it's funny how people have this knee-jerk reaction against C++ IL apps. The devd executable is not exactly an example of bloatware: 374k IL statically linked (so it already includes this C++ runtime that you IL think is large).We

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Slawa Olhovchenkov
On Tue, Aug 21, 2012 at 09:40:27PM +0400, Lev Serebryakov wrote: Hello, Ian. You wrote 21 августа 2012 г., 21:36:30: IL Perhaps the right solution is to add a dhclient command line option to IL operate in the historical buggy mode: it doesn't exit on link status IL changes, and fails to

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Doug Barton
On 8/21/2012 6:34 AM, John Baldwin wrote: Humm. devd is the more common case, and we explicitly don't use devd to start dhclient on boot even when devd is enabled (so out of the box dhcp would first be started by rc, but would be restarted by devd). That sounds reasonable. People who

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, Slawa. You wrote 21 августа 2012 г., 21:47:46: SO Not re-request lease, simple renew. Sorry, I'm not very strong in exact terms here. -- // Black Lion AKA Lev Serebryakov l...@freebsd.org ___ freebsd-current@freebsd.org mailing list

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Slawa Olhovchenkov
On Tue, Aug 21, 2012 at 10:18:15PM +0400, Lev Serebryakov wrote: SO Not re-request lease, simple renew. Sorry, I'm not very strong in exact terms here. dhcp client can sent different requests: DHCPDISCOVER from 0.0.0.0 to 255.255.255.255 DHCPREQUEST from 0.0.0.0 to SERVER_IP (from

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Warner Losh
On Aug 21, 2012, at 6:46 AM, Slawa Olhovchenkov wrote: On Tue, Aug 21, 2012 at 03:45:48PM +0400, Lev Serebryakov wrote: Hello, Lev. You wrote 21 августа 2012 г., 15:40:35: GC Try reverting r239356 -- if that works, then please let jhb@ know. LS I'm confused by this commit, because it

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Warner Losh
On Aug 21, 2012, at 11:36 AM, Ian Lepore wrote: On Tue, 2012-08-21 at 21:01 +0400, Lev Serebryakov wrote: IL The important point is that if you unplug the cable then plug it into a IL different network, now the right thing will happen -- you will acquire IL an address on the new network.

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Warner Losh
On Aug 21, 2012, at 11:42 AM, Lev Serebryakov wrote: Hello, Ian. You wrote 21 августа 2012 г., 21:36:30: IL I think it's funny how people have this knee-jerk reaction against C++ IL apps. The devd executable is not exactly an example of bloatware: 374k IL statically linked (so it already

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, Warner. You wrote 22 августа 2012 г., 0:02:18: WL Haven't looked at the dhclient issues surrounding this tread, but WL C++ size and bloat of devd is an argument not supported by the objective facts. Ok, lets leave C++ alone, but intended address removal (See PR comments) is POLA

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, Warner. You wrote 22 августа 2012 г., 0:04:41: BTW, typical MIPS SoC-based router has only 16MiB of flash. And, yes, FreeBSD doesn't fit well in this size now, but why add another mandatory program, only role of which is to monitor network cable and re-run the same program every

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, Warner. You wrote 21 августа 2012 г., 23:56:11: WL mosh helps. And what helps in case of on-line backup? Not every network protocol and protocol implementation, unfortunately, supports automatic resume :( -- // Black Lion AKA Lev Serebryakov l...@freebsd.org

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread John Baldwin
On Tuesday, August 21, 2012 9:34:31 am John Baldwin wrote: On Tuesday, August 21, 2012 7:53:08 am Lev Serebryakov wrote: Hello, Garrett. You wrote 21 августа 2012 г., 15:40:35: GC Try reverting r239356 -- if that works, then please let jhb@ know. LS I'm confused by this commit,

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Ian Lepore
On Tue, 2012-08-21 at 14:04 -0600, Warner Losh wrote: On Aug 21, 2012, at 11:42 AM, Lev Serebryakov wrote: Hello, Ian. You wrote 21 августа 2012 г., 21:36:30: IL I think it's funny how people have this knee-jerk reaction against C++ IL apps. The devd executable is not exactly an

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Slawa Olhovchenkov
On Tue, Aug 21, 2012 at 01:56:11PM -0600, Warner Losh wrote: On Aug 21, 2012, at 6:46 AM, Slawa Olhovchenkov wrote: On Tue, Aug 21, 2012 at 03:45:48PM +0400, Lev Serebryakov wrote: Hello, Lev. You wrote 21 августа 2012 г., 15:40:35: GC Try reverting r239356 -- if that works,

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, Ian. You wrote 22 августа 2012 г., 1:38:04: IL For example, this script can replace devd as a daemon that restarts IL dhclient when any link comes back up... IL Of course the right thing to do is invoke the proper rc scripts rather IL than dhclient directly... this is just to illustrate

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Lev Serebryakov
Hello, John. You wrote 22 августа 2012 г., 1:25:23: JB Ok, this is what I came up with, somewhat loosely based on OpenBSD's dhclient. JB I tested that it survives the following: JB - Unplugging/replugging does not kill an existing ssh session JB - Using ifconfig down/up does not kill an

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Slawa Olhovchenkov
On Wed, Aug 22, 2012 at 02:36:23AM +0400, Lev Serebryakov wrote: Hello, Ian. You wrote 22 августа 2012 г., 1:38:04: IL For example, this script can replace devd as a daemon that restarts IL dhclient when any link comes back up... IL Of course the right thing to do is invoke the proper rc

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Peter Jeremy
On 2012-Aug-21 17:25:23 -0400, John Baldwin j...@freebsd.org wrote: Ok, this is what I came up with, somewhat loosely based on OpenBSD's dhclient. I tested that it survives the following: I've also done some limited testing on both bge and fxp NICs and haven't run into any problems. In

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Slawa Olhovchenkov
On Tue, Aug 21, 2012 at 05:25:23PM -0400, John Baldwin wrote: On Tuesday, August 21, 2012 9:34:31 am John Baldwin wrote: On Tuesday, August 21, 2012 7:53:08 am Lev Serebryakov wrote: Hello, Garrett. You wrote 21 августа 2012 г., 15:40:35: GC Try reverting r239356 -- if that works,

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Warner Losh
On Aug 21, 2012, at 4:15 PM, Slawa Olhovchenkov wrote: On Tue, Aug 21, 2012 at 01:56:11PM -0600, Warner Losh wrote: On Aug 21, 2012, at 6:46 AM, Slawa Olhovchenkov wrote: On Tue, Aug 21, 2012 at 03:45:48PM +0400, Lev Serebryakov wrote: Hello, Lev. You wrote 21 августа 2012 г.,

Re: r239356: does it mean, that synchronous dhcp and dhcplcinet with disabled devd gone?

2012-08-21 Thread Warner Losh
On Aug 21, 2012, at 5:00 PM, Slawa Olhovchenkov wrote: On Wed, Aug 22, 2012 at 02:36:23AM +0400, Lev Serebryakov wrote: Hello, Ian. You wrote 22 августа 2012 г., 1:38:04: IL For example, this script can replace devd as a daemon that restarts IL dhclient when any link comes back up...