Re: Questions and *little* bugs in new vt(9)

2014-05-11 Thread 小野寛生
Hello,

2014-05-09 18:48 GMT+09:00 David Demelier demelier.da...@gmail.com:
 On 08/05/2014 17:09, Ed Maste wrote:

 On 8 May 2014 04:16, David Demelier demelier.da...@gmail.com wrote:

 Hi there,

 I'm currently trying vt(9) on a CURRENT kernel (only the kernel not the
 base). I have very small bugs, not really serious. I'm currently using
 the
 radeon KMS driver.

 * When I don't use the native resolution (i.e the radeon firmwares are
 not
 loaded) switching from a tty to another results sometimes in a black
 screen
 when only some colors are displayed. This does not seems to appear when
 the
 native resolution is set.

 Can you describe the corruption in some more detail, or share a
 picture of it?  I haven't observed something like this with stock vt,
 and the vt_vga driver.

I also have similar display corruption when I switch between ttys.
The monitor sometime become black screen with only cursor displayed,
or sometimes get messed like this picture:
https://dl.dropboxusercontent.com/u/16075585/FreeBSD/vt_20140509.jpg

Toggling between ttys a few times get things normal, so it is not
really a problem.
I see it on current r265145 and stable/10 r265146.

the (head of) dmesg for the PC running stable/10 is:

Copyright (c) 1992-2014 The FreeBSD Project.
Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994
The Regents of the University of California. All rights reserved.
FreeBSD is a registered trademark of The FreeBSD Foundation.
FreeBSD 10.0-STABLE #28 r265146: Thu May  8 00:46:23 JST 2014
root@:/usr/obj/usr/src/sys/OIKUMENE i386
FreeBSD clang version 3.4 (tags/RELEASE_34/final 197956) 20140216
CPU: Intel(R) Atom(TM) CPU N270   @ 1.60GHz (1608.03-MHz 686-class CPU)
  Origin = GenuineIntel  Id = 0x106c2  Family = 0x6  Model = 0x1c
Stepping = 2
  
Features=0xbfe9fbffFPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,CLFLUSH,DTS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE
  Features2=0x40c39dSSE3,DTES64,MON,DS_CPL,EST,TM2,SSSE3,xTPR,PDCM,MOVBE
  AMD Features=0x10NX
  AMD Features2=0x1LAHF
  TSC: P-state invariant, performance statistics
real memory  = 2147483648 (2048 MB)
avail memory = 2081185792 (1984 MB)
Event timer LAPIC quality 400
ACPI APIC Table: A_M_I_ OEMAPIC 
FreeBSD/SMP: Multiprocessor System Detected: 2 CPUs
FreeBSD/SMP: 1 package(s) x 1 core(s) x 2 HTT threads
 cpu0 (BSP): APIC ID:  0
 cpu1 (AP/HT): APIC ID:  1
WARNING: VIMAGE (virtualized network stack) is a highly experimental feature.
ACPI BIOS Warning (bug): Optional FADT field Pm2ControlBlock has zero
address or length: 0x0820/0x0 (20130823/tbfadt-630)
ACPI BIOS Warning (bug): Invalid length for FADT/Pm2ControlBlock: 0,
using default 8 (20130823/tbfadt-682)
ioapic0: Changing APIC ID to 2
ioapic0 Version 2.0 irqs 0-23 on motherboard
random: Software, Yarrow initialized
kbd0 at kbdmux0
acpi0: A_M_I_ OEMXSDT on motherboard
acpi0: Power Button (fixed)
acpi0: reservation of 0, a (3) failed
acpi0: reservation of 10, 7f70 (3) failed
cpu0: ACPI CPU on acpi0
cpu1: ACPI CPU on acpi0
attimer0: AT timer port 0x40-0x43 irq 0 on acpi0
Timecounter i8254 frequency 1193182 Hz quality 0
Event timer i8254 frequency 1193182 Hz quality 100
atrtc0: AT realtime clock port 0x70-0x71 irq 8 on acpi0
Event timer RTC frequency 32768 Hz quality 0
hpet0: High Precision Event Timer iomem 0xfed0-0xfed003ff on acpi0
Timecounter HPET frequency 14318180 Hz quality 950
Event timer HPET frequency 14318180 Hz quality 450
Event timer HPET1 frequency 14318180 Hz quality 440
Event timer HPET2 frequency 14318180 Hz quality 440
Timecounter ACPI-fast frequency 3579545 Hz quality 900
acpi_timer0: 24-bit timer at 3.579545MHz port 0x808-0x80b on acpi0
pcib0: ACPI Host-PCI bridge port 0xcf8-0xcff on acpi0
pci0: ACPI PCI bus on pcib0
vgapci0: VGA-compatible display port 0xec80-0xec87 mem
0xfeb8-0xfebf,0xd000-0xdfff,0xfeb4-0xfeb7 irq
16 at device 2.0 on pci0
agp0: Intel 945GME SVGA controller on vgapci0
agp0: aperture size is 256M, detected 7932k stolen memory
vgapci0: Boot video device
vgapci1: VGA-compatible display mem 0xfea8-0xfeaf at device
2.1 on pci0
hdac0: Intel 82801G HDA Controller mem 0xfeb38000-0xfeb3bfff irq 16
at device 27.0 on pci0
pcib1: ACPI PCI-PCI bridge irq 16 at device 28.0 on pci0
pci4: ACPI PCI bus on pcib1
re0: RealTek 8168/8111 B/C/CP/D/DP/E/F/G PCIe Gigabit Ethernet port
0xdc00-0xdcff mem 0xfe8ff000-0xfe8f,0xbfef-0xbfef irq 16
at device 0.0 on pci4
re0: Using 1 MSI-X message
re0: Chip rev. 0x3c00
re0: MAC rev. 0x0040
miibus0: MII bus on re0
rgephy0: RTL8169S/8110S/8211 1000BASE-T media interface PHY 1 on miibus0
rgephy0:  none, 10baseT, 10baseT-FDX, 10baseT-FDX-flow, 100baseTX,
100baseTX-FDX, 100baseTX-FDX-flow, 1000baseT, 1000baseT-master,
1000baseT-FDX, 1000baseT-FDX-master, 1000baseT-FDX-flow,
1000baseT-FDX-flow-master, auto, auto-flow
re0: Ethernet address: 00:23:54:c6:c1:12
pcib2: ACPI PCI-PCI bridge irq 17 at device 28.1 on pci0
pci3: 

Build failed in Jenkins: FreeBSD_HEAD-modules #395

2014-05-11 Thread jenkins-admin
See https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/395/changes

Changes:

[ian] Add cpu_l2cache_drain_writebuf(), use it to implement 
generic_bs_barrier().

On modern ARM SoCs the L2 cache controller sits between the CPU and the
AXI bus, and most on-chip memory-mapped devices are on the AXI bus.  We
map the device registers using the 'Device' memory attribute, which means
the memory is not cached, but writes to it are buffered.  Ensuring that a
write has made it all the way to a device may require that the L2
controller take some action.

There is currently only one implementation of the new function, for the
PL310 cache controller.  It invokes a function that the controller
manual calls cache sync but it actually has nothing to do with cache at
all, it triggers a drain of all pending store buffer writes and it blocks
until they complete.

The sheeva and xscale L2 controllers (which predate the concept of Device
memory) don't seem to have a corresponding function.  It appears that the
standard armv5 drain_writebuf function includes draining all the way
through the L2 controller.

[grehan] Enable SMP for Exynos-based platforms (i.e. Chromebook)

Reviewed by:br

[nwhitehorn] Use vt(4) by default on 32-bit PowerPC now that it is fully 
functional and
fast. 64-bit PowerPC will follow along once the PS3 framebuffer driver is
adapted.

[nwhitehorn] Port over mmap routine from syscons. This lets X11 work on PowerPC 
with vt.
The last obstacle to switching PowerPC entirely to vt is that the Playstation 3
framebuffer driver needs to be ported over. This only applies for powerpc64,
however.

[nwhitehorn] Make ofwfb not be painfully slow. This reduces the time for a 
verbose boot
on my G4 iBook by more than half. Still 10% slower than syscons, but that's
much better than a factor of 2.

The slowness had to do with pathological write performance on 8-bit
framebuffers, which are almost universally used on Open Firmware systems.
Writing 1 byte at a time, potentially nonconsecutively, resulted in many
extra PCI write cycles. This patch, in the common case where it's writing
one or several characters in an 8x8 font, gangs the writes together into
a set of 32-bit writes. This is a port of r143830 to vt(4).

The EFI framebuffer is also extremely slow, probably for the same reason,
and the same patch will likely help there.

--
Started by upstream project FreeBSD_HEAD build number 645
originally caused by:
 Started by an SCM change
Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/
Updating svn://svn.freebsd.org/base/head/sys at revision 
'2014-05-11T04:47:43.849 +'
U arm/arm/cpufunc.c
U arm/arm/pl310.c
U arm/arm/bus_space_generic.c
U arm/include/cpufunc.h
U arm/conf/EXYNOS5250.common
U powerpc/conf/GENERIC
U dev/vt/hw/ofwfb/ofwfb.c
At revision 265870
Updating svn://svn.freebsd.org/base/head/share/mk at revision 
'2014-05-11T04:47:43.849 +'
At revision 265870
no change for svn://svn.freebsd.org/base/head/share/mk since the previous build
[FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson8143550771314082790.sh
+ export JFLAG=-j4
+ export 
MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
+ cd 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
+ echo '=== make cleandir ==='
=== make cleandir ===
+ make cleandir
=== aac (cleandir)
make[1]: 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.opts.mk;
 line 24: Could not find ../../share/mk/bsd.mkopt.mk
make[1]: 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.mk;
 line 38: Malformed conditional (${MK_FORMAT_EXTENSIONS} == no)
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac
*** Error code 1

Stop.
make: stopped in 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
Build step 'Execute shell' marked build as failure
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Makefile Problem of FreeBSD-Current

2014-05-11 Thread bycn82

As you can see below . it still did not find the src.opts.mk


root@FB10Head:/usr/src/sbin/ipfw # make
make: /usr/src/sbin/ipfw/Makefile line 3: Could not find src.opts.mk
make: /usr/src/sbin/ipfw/Makefile line 9: Malformed conditional 
(${MK_PF} != no)
make: /usr/src/sbin/ipfw/../Makefile.inc line 4: Could not find 
src.opts.mk
make: /usr/src/sbin/ipfw/../Makefile.inc line 9: Malformed conditional 
(${MK_DYNAMICROOT} == no)

make: Fatal errors encountered -- cannot continue
make: stopped in /usr/src/sbin/ipfw
root@FB10Head:/usr/src/sbin/ipfw # uname -a
FreeBSD FB10Head 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r265868: Sun May 
11 11:44:35 UTC 2014 root@FB10Head:/usr/obj/usr/src/sys/GENERIC  amd64

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Makefile Problem of FreeBSD-Current

2014-05-11 Thread Sean Bruno
On Sun, 2014-05-11 at 20:49 +0800, bycn82 wrote:
 As you can see below . it still did not find the src.opts.mk
 
 
 root@FB10Head:/usr/src/sbin/ipfw # make
 make: /usr/src/sbin/ipfw/Makefile line 3: Could not find src.opts.mk
 make: /usr/src/sbin/ipfw/Makefile line 9: Malformed conditional 
 (${MK_PF} != no)
 make: /usr/src/sbin/ipfw/../Makefile.inc line 4: Could not find 
 src.opts.mk
 make: /usr/src/sbin/ipfw/../Makefile.inc line 9: Malformed conditional 
 (${MK_DYNAMICROOT} == no)
 make: Fatal errors encountered -- cannot continue
 make: stopped in /usr/src/sbin/ipfw
 root@FB10Head:/usr/src/sbin/ipfw # uname -a
 FreeBSD FB10Head 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r265868: Sun May 
 11 11:44:35 UTC 2014 root@FB10Head:/usr/obj/usr/src/sys/GENERIC  amd64
 ___
 freebsd-current@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-current
 To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


I suspect you are seeing the same issue as described in the thread
delete-old issue with src.opts.mk on -current.

sean

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Makefile Problem of FreeBSD-Current

2014-05-11 Thread Thomas Hoffmann
On Sun, May 11, 2014 at 9:39 AM, Sean Bruno sbr...@ignoranthack.me wrote:

 On Sun, 2014-05-11 at 20:49 +0800, bycn82 wrote:
  As you can see below . it still did not find the src.opts.mk
 
 
  root@FB10Head:/usr/src/sbin/ipfw # make
  make: /usr/src/sbin/ipfw/Makefile line 3: Could not find src.opts.mk
  make: /usr/src/sbin/ipfw/Makefile line 9: Malformed conditional
  (${MK_PF} != no)
  make: /usr/src/sbin/ipfw/../Makefile.inc line 4: Could not find
  src.opts.mk
  make: /usr/src/sbin/ipfw/../Makefile.inc line 9: Malformed conditional
  (${MK_DYNAMICROOT} == no)
  make: Fatal errors encountered -- cannot continue
  make: stopped in /usr/src/sbin/ipfw
  root@FB10Head:/usr/src/sbin/ipfw # uname -a
  FreeBSD FB10Head 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r265868: Sun May
  11 11:44:35 UTC 2014 root@FB10Head:/usr/obj/usr/src/sys/GENERIC
  amd64
  ___
  freebsd-current@freebsd.org mailing list
  http://lists.freebsd.org/mailman/listinfo/freebsd-current
  To unsubscribe, send any mail to 
 freebsd-current-unsubscr...@freebsd.org


 I suspect you are seeing the same issue as described in the thread
 delete-old issue with src.opts.mk on -current.


I successfully built -CURRENT 265866 last night and did not run into this
problem. However, I ran -DNO_CLEAN and had no need to rebuild ipfw from my
previous build(s). If I now go into the /usr/src/sbin/ipfw directory and
simply do a 'make', I can duplicate this error.

The /usr/src/sbin/ipfw/Makefile includes an .include for src.opts.mk:

# $FreeBSD: head/sbin/ipfw/Makefile 265420 2014-05-06 04:22:01Z imp $

.include src.opts.mk

PROG= ipfw
SRCS= ipfw2.c dummynet.c ipv6.c main.c nat.c
WARNS?= 2
...

Maybe it should not?

-Tom
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Makefile Problem of FreeBSD-Current

2014-05-11 Thread Warner Losh

On May 11, 2014, at 6:49 AM, bycn82 byc...@gmail.com wrote:

 As you can see below . it still did not find the src.opts.mk
 
 
 root@FB10Head:/usr/src/sbin/ipfw # make
 make: /usr/src/sbin/ipfw/Makefile line 3: Could not find src.opts.mk
 make: /usr/src/sbin/ipfw/Makefile line 9: Malformed conditional (${MK_PF} 
 != no)
 make: /usr/src/sbin/ipfw/../Makefile.inc line 4: Could not find src.opts.mk
 make: /usr/src/sbin/ipfw/../Makefile.inc line 9: Malformed conditional 
 (${MK_DYNAMICROOT} == no)
 make: Fatal errors encountered -- cannot continue
 make: stopped in /usr/src/sbin/ipfw
 root@FB10Head:/usr/src/sbin/ipfw # uname -a
 FreeBSD FB10Head 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r265868: Sun May 11 
 11:44:35 UTC 2014 root@FB10Head:/usr/obj/usr/src/sys/GENERIC  amd64

From UPDATING:

20140505:
/etc/src.conf now affects only builds of the FreeBSD src tree. In the
past, it affected all builds that used the bsd.*.mk files. The old
behavior was a bug, but people may have relied upon it. To get this
behavior back, you can .include /etc/src.conf fro20140505:
/etc/src.conf now affects only builds of the FreeBSD src tree. In the
past, it affected all builds that used the bsd.*.mk files. The old
behavior was a bug, but people may have relied upon it. To get this
behavior back, you can .include /etc/src.conf from /etc/make.conf
(which is still global and isn't changed). This also changes the
behavior of incremental builds inside the tree of individual
directories. Set MAKESYSPATH to .../share/mk to do that.
Although this has survived make universe and some upgrade scenarios,
other upgrade scenarios may have broken. At least one form of
temporary breakage was fixed with MAKESYSPATH settings for buildworld
as well...

Since you are building inside the tree, did you set MAKESYSPATH as outlined in 
UPDATING?

Warner

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Makefile Problem of FreeBSD-Current

2014-05-11 Thread Thomas Hoffmann
On Sun, May 11, 2014 at 11:14 AM, Warner Losh i...@bsdimp.com wrote:


 From UPDATING:

 20140505:
 /etc/src.conf now affects only builds of the FreeBSD src tree. In
 the
 past, it affected all builds that used the bsd.*.mk files. The old
 behavior was a bug, but people may have relied upon it. To get this
 behavior back, you can .include /etc/src.conf from /etc/make.conf
 (which is still global and isn't changed). This also changes the
 behavior of incremental builds inside the tree of individual
 directories. Set MAKESYSPATH to .../share/mk to do that.
 Although this has survived make universe and some upgrade
 scenarios,
 other upgrade scenarios may have broken. At least one form of
 temporary breakage was fixed with MAKESYSPATH settings for
 buildworld
 as well...

 Since you are building inside the tree, did you set MAKESYSPATH as
 outlined in UPDATING?


Thanks for this clarification. Setting MAKESYSPATH resolves the issue. I am
indeed guilty of _not_ regularly checking /usr/src/UPDATING. My bad.

-Tom
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Build failed in Jenkins: FreeBSD_HEAD-modules #395

2014-05-11 Thread Warner Losh

On May 10, 2014, at 10:48 PM, jenkins-ad...@freebsd.org wrote:
 + export 
 MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk

This is wrong. This makes the testing invalid. It should be fixed to include 
…/ws/share/mk. Until that’s fixed, you can ignore these whining emails.

Warner




signature.asc
Description: Message signed with OpenPGP using GPGMail


Build failed in Jenkins: FreeBSD_HEAD-modules #396

2014-05-11 Thread jenkins-admin
See https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/396/changes

Changes:

[nwhitehorn] Move the PS3 framebuffer console to use vt instead of syscons and 
adjust
GENERIC64 for PowerPC to use vt with it.

Much to my chagrin, PS3 support seems to have bitrotted somewhat since the
last time I tried it. ehci panics on attach and interrupt handling seems
to be faulty. This should be fixed soon...

--
Started by upstream project FreeBSD_HEAD build number 646
originally caused by:
 Started by an SCM change
Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/
Updating svn://svn.freebsd.org/base/head/sys at revision 
'2014-05-11T07:38:47.895 +'
U conf/files.powerpc
U powerpc/ps3/ps3_syscons.c
U powerpc/conf/GENERIC64
At revision 265871
Updating svn://svn.freebsd.org/base/head/share/mk at revision 
'2014-05-11T07:38:47.895 +'
At revision 265871
no change for svn://svn.freebsd.org/base/head/share/mk since the previous build
[FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson5464838906561688434.sh
+ export JFLAG=-j4
+ export 
MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
+ cd 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
+ echo '=== make cleandir ==='
=== make cleandir ===
+ make cleandir
=== aac (cleandir)
make[1]: 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.opts.mk;
 line 24: Could not find ../../share/mk/bsd.mkopt.mk
make[1]: 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.mk;
 line 38: Malformed conditional (${MK_FORMAT_EXTENSIONS} == no)
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac
*** Error code 1

Stop.
make: stopped in 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
Build step 'Execute shell' marked build as failure
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Build failed in Jenkins: FreeBSD_HEAD-modules #397

2014-05-11 Thread jenkins-admin
See https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/397/changes

Changes:

[cperciva] In cf_get_method, when we don't already know what clock speed the 
CPU is
running at, guess the nearest value instead of looking for a value within
25 MHz of the observed frequency.

Prior to this change, if a system booted with Intel Turbo Boost enabled,
the dev.cpu.0.freq sysctl is nonfunctional, since the ACPI-reported
frequency for Turbo Boost states does not match the actual clock frequency
(and thus no levels are within 25 MHz of the observed frequency) and the
current performance level is read before a new level is set.

MFC after:  3 days
Relnotes:   Bug fix in power management on CPUs with Intel Turbo Boost

[hselasky] Optimise host mode data roundtrip time. When BULK data is submitted 
to
the main processing queue, clear the NAK counter for any associated
BULK or CONTROL transfers and poll the endpoint(s) for 1 millisecond
at 125us rate interval, before going into slow, 10ms, NAK polling mode
again.  This has the effect that typical ping-ping protocols respond
quicker when initiated from the USB host.

MFC after:  2 weeks

--
Started by upstream project FreeBSD_HEAD build number 647
originally caused by:
 Started by an SCM change
Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/
Updating svn://svn.freebsd.org/base/head/sys at revision 
'2014-05-11T10:39:51.794 +'
U kern/kern_cpu.c
U dev/usb/controller/dwc_otg.c
U dev/usb/controller/dwc_otg.h
At revision 265876
Updating svn://svn.freebsd.org/base/head/share/mk at revision 
'2014-05-11T10:39:51.794 +'
At revision 265876
no change for svn://svn.freebsd.org/base/head/share/mk since the previous build
[FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson1951992605594906963.sh
+ export JFLAG=-j4
+ export 
MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
+ cd 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
+ echo '=== make cleandir ==='
=== make cleandir ===
+ make cleandir
=== aac (cleandir)
make[1]: 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.opts.mk;
 line 24: Could not find ../../share/mk/bsd.mkopt.mk
make[1]: 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.mk;
 line 38: Malformed conditional (${MK_FORMAT_EXTENSIONS} == no)
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac
*** Error code 1

Stop.
make: stopped in 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
Build step 'Execute shell' marked build as failure
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Build failed in Jenkins: FreeBSD_HEAD-modules #399

2014-05-11 Thread jenkins-admin
See https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/399/

--
Started by user lwhsu
Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/
Updating svn://svn.freebsd.org/base/head/sys at revision 
'2014-05-11T15:22:36.455 +'
At revision 265880
Updating svn://svn.freebsd.org/base/head/share/mk at revision 
'2014-05-11T15:22:36.455 +'
At revision 265880
no change for svn://svn.freebsd.org/base/head/sys since the previous build
no change for svn://svn.freebsd.org/base/head/share/mk since the previous build
[FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson6719633895621215726.sh
+ export JFLAG=-j4
+ export 
MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/share/mk
+ cd 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
+ echo '=== make cleandir ==='
=== make cleandir ===
+ make cleandir
make: no system rules (sys.mk).

make: stopped in 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
Build step 'Execute shell' marked build as failure
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Build failed in Jenkins: FreeBSD_HEAD-modules #398

2014-05-11 Thread jenkins-admin
See https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/398/changes

Changes:

[jilles] include: Remove checks for __BSD_VISIBLE where redundant with 
__XSI_VISIBLE
or __POSIX_VISIBLE.

Whenever sys/cdefs.h sets __BSD_VISIBLE to non-zero, it also sets
__POSIX_VISIBLE and __XSI_VISIBLE to the newest version supported.

No functional change is intended.

[ian] Revert accidental commit of SUBDIR_PARALLEL for sys/modules.  (It hasn't
been tested sufficiently).

--
Started by upstream project FreeBSD_HEAD build number 648
originally caused by:
 Started by an SCM change
Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/
Updating svn://svn.freebsd.org/base/head/sys at revision 
'2014-05-11T13:54:37.069 +'
U modules/Makefile
U sys/stat.h
At revision 265878
Updating svn://svn.freebsd.org/base/head/share/mk at revision 
'2014-05-11T13:54:37.069 +'
At revision 265878
no change for svn://svn.freebsd.org/base/head/share/mk since the previous build
[FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson8704331225077297218.sh
+ export JFLAG=-j4
+ export 
MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
+ cd 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
+ echo '=== make cleandir ==='
=== make cleandir ===
+ make cleandir
=== aac (cleandir)
make[1]: 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.opts.mk;
 line 24: Could not find ../../share/mk/bsd.mkopt.mk
make[1]: 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.mk;
 line 38: Malformed conditional (${MK_FORMAT_EXTENSIONS} == no)
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac
*** Error code 1

Stop.
make: stopped in 
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
Build step 'Execute shell' marked build as failure
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Build failed in Jenkins: FreeBSD_HEAD-modules #395

2014-05-11 Thread Li-Wen Hsu
On Sat, May 10, 2014 at 23:21:50 -0600, Warner Losh wrote:
 
 On May 10, 2014, at 10:48 PM, jenkins-ad...@freebsd.org wrote:
  + export 
  MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
 
 This is wrong. This makes the testing invalid. It should be fixed to include 
 …/ws/share/mk. Until that’s fixed, you can ignore these whining emails.


This job is still in testing stage, and I did not want to enable the
mail notification that quickly.  I did not clearly mark this is a WIP
and others think it is ready to broadcast.

Sorry for bothering.  I've just turned the notification off and work
on fix.

Li-Wen

-- 
Li-Wen Hsu lw...@freebsd.org
http://lwhsu.org
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386

2014-05-11 Thread Li-Wen Hsu
On Sat, May 10, 2014 at 20:06:58 -0600, Warner Losh wrote:
 
 On May 10, 2014, at 8:06 PM, Warner Losh i...@bsdimp.com wrote:
 
  
  On May 10, 2014, at 6:27 PM, Craig Rodrigues rodr...@freebsd.org wrote:
  
  Warner,
  
  It looks like your change broke the FreeBSD-HEAD-modules
  build.
  
  This build does the following:
  
  export JFLAG=-j4
  export MAKESYSPATH=${WORKSPACE}/mk”
  
  Shouldn’t this be ${WORKSPACE}/share/mk? MAKESYSPATH needs to be …/share/mk 
  or $TOP/share/mk when building outside of make world-like environments now.
  
  Warner
  
  cd ${WORKSPACE}/sys/modules
  echo === make cleandir ===
  make cleandir
  echo === make depend ===
  make ${JFLAG} depend
  echo === make all ===
  make ${JFLAG} all
 
 Just confirmed that it works with a proper MAKESYSPATH…
 
 Warner
 

This job checks out svn://svn.freebsd.org/base/head/sys to
${WORKSPACE}/sys and svn://svn.freebsd.org/base/head/share/mk to
${WORKSPACE}/mk , then sets MAKESYSPATH=${WORKSPACE}/mk since I was
trying not to check out the whole src tree.

Just be curious, why in line 24 of sys/conf/kern.opts.mk , we do:

.include ../../share/mk/bsd.mkopt.mk

but not:

.include bsd.mkopt.mk

like other .mk files under sys/conf ?

I tried to switch to this and it seems work, but I am not sure if this
is your original intention.  I'll change the modules building job to
checkout the whole src tree if this is not an accepted solution.

Thanks,
Li-Wen

-- 
Li-Wen Hsu lw...@freebsd.org
http://lwhsu.org
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: Ordering for network-sensitive rc scripts

2014-05-11 Thread David Chisnall
On 17 Apr 2014, at 09:30, Adrian Chadd adr...@freebsd.org wrote:

 Can't we add a devd hook to do that?

I tried doing this, but it turns out that wlan devices don't appear to send 
devd LINK_UP / LINK_DOWN events.  It would be nice to have a clean solution to 
this.  By default, using the stock rc scripts, my router is currently not able 
to forward packets from the WiFi until I've logged into it and manually run 
'service pf restart', which is a bit crazy.  I've hacked around it by having a 
script run from rc.local that sleeps for 60 seconds and then restarts a few 
things, but that's really, really ugly.  

On closer inspection, pf doesn't fail silently, it complains about a syntax 
error in my config file because wlan0 is not a known interface.

We therefore have an rc ordering problem if you want to use pf and WiFi at the 
same time.  This problem was introduced some time between 9.2 and 10.0.

David

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Ordering for network-sensitive rc scripts

2014-05-11 Thread Adrian Chadd
On 11 May 2014 12:01, David Chisnall thera...@freebsd.org wrote:
 On 17 Apr 2014, at 09:30, Adrian Chadd adr...@freebsd.org wrote:

 Can't we add a devd hook to do that?

 I tried doing this, but it turns out that wlan devices don't appear to send 
 devd LINK_UP / LINK_DOWN events.  It would be nice to have a clean solution 
 to this.  By default, using the stock rc scripts, my router is currently not 
 able to forward packets from the WiFi until I've logged into it and manually 
 run 'service pf restart', which is a bit crazy.  I've hacked around it by 
 having a script run from rc.local that sleeps for 60 seconds and then 
 restarts a few things, but that's really, really ugly.

 On closer inspection, pf doesn't fail silently, it complains about a syntax 
 error in my config file because wlan0 is not a known interface.

 We therefore have an rc ordering problem if you want to use pf and WiFi at 
 the same time.  This problem was introduced some time between 9.2 and 10.0.

Is there a PR for this? It's the first I've heard of it.


-a
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Ordering for network-sensitive rc scripts

2014-05-11 Thread David Chisnall
On 11 May 2014, at 20:23, Adrian Chadd adr...@freebsd.org wrote:

 On 11 May 2014 12:01, David Chisnall thera...@freebsd.org wrote:
 On 17 Apr 2014, at 09:30, Adrian Chadd adr...@freebsd.org wrote:
 
 Can't we add a devd hook to do that?
 
 I tried doing this, but it turns out that wlan devices don't appear to send 
 devd LINK_UP / LINK_DOWN events.  It would be nice to have a clean solution 
 to this.  By default, using the stock rc scripts, my router is currently not 
 able to forward packets from the WiFi until I've logged into it and manually 
 run 'service pf restart', which is a bit crazy.  I've hacked around it by 
 having a script run from rc.local that sleeps for 60 seconds and then 
 restarts a few things, but that's really, really ugly.
 
 On closer inspection, pf doesn't fail silently, it complains about a syntax 
 error in my config file because wlan0 is not a known interface.
 
 We therefore have an rc ordering problem if you want to use pf and WiFi at 
 the same time.  This problem was introduced some time between 9.2 and 10.0.
 
 Is there a PR for this? It's the first I've heard of it.

Not yet.  This is the result of my investigations as of 10 minutes ago.  I'll 
file a PR, if no one can tell me I'm doing something obviously wrong...

David

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386

2014-05-11 Thread Craig Rodrigues
Hi,

No, that's not the problem, because we specifically check out
/usr/share/mk into $WORKSPACE/mk before running the build.

The problem is due to this commit:

http://svnweb.freebsd.org/base/head/sys/conf/kern.mk?r1=265832r2=265841

You didn't completely remove MK_FORMAT_EXTENSIONS from this file,
so we are now getting this error message:

make[1]: /builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.opts.mk
line 24: Could not find ../../share/mk/bsd.mkopt.mk
make[1]: /builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.mk
line 38: Malformed conditional (${MK_FORMAT_EXTENSIONS} == no)

--
Craig


On Sat, May 10, 2014 at 7:06 PM, Warner Losh i...@bsdimp.com wrote:

 On May 10, 2014, at 6:27 PM, Craig Rodrigues rodr...@freebsd.org wrote:

 Warner,

 It looks like your change broke the FreeBSD-HEAD-modules
 build.

 This build does the following:

 export JFLAG=-j4
 export MAKESYSPATH=${WORKSPACE}/mk

 Shouldn't this be ${WORKSPACE}/share/mk? MAKESYSPATH needs to be .../share/mk 
 or $TOP/share/mk when building outside of make world-like environments now.

 Warner

 cd ${WORKSPACE}/sys/modules
 echo === make cleandir ===
 make cleandir
 echo === make depend ===
 make ${JFLAG} depend
 echo === make all ===
 make ${JFLAG} all


 Can you look into this?

 Thanks.

 --
 Craig


 On Fri, May 9, 2014 at 3:39 PM,  jenkins-ad...@freebsd.org wrote:
 See 
 https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/386/changes

 Changes:

 [imp] Introduce kern.opts.mk to hold all the options for kernel module
 builds. Include this in the right places. Make src.opts.mk optional so
 that modules can be built outside of the tree in the ports system.

 PR: 189520

 --
 Started by upstream project FreeBSD_HEAD build number 636
 originally caused by:
 Started by an SCM change
 Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace 
 https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/
 Updating svn://svn.freebsd.org/base/head/sys at revision 
 '2014-05-09T22:39:09.739 +'
 U conf/kmod.mk
 AUconf/kern.opts.mk
 U conf/kern.pre.mk
 At revision 265785
 Updating svn://svn.freebsd.org/base/head/share/mk at revision 
 '2014-05-09T22:39:09.739 +'
 U src.opts.mk
 At revision 265785
 [FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson6703688508778127870.sh
 + export JFLAG=-j4
 + export 
 MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
 + cd 
 https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
 + echo '=== make cleandir ==='
 === make cleandir ===
 + make cleandir
 === aac (cleandir)
 make[1]: 
 https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.opts.mk;
  line 24: Could not find ../../share/mk/bsd.mkopt.mk
 make[1]: Fatal errors encountered -- cannot continue
 make[1]: stopped in 
 https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac
 *** Error code 1

 Stop.
 make: stopped in 
 https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
 Build step 'Execute shell' marked build as failure

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386

2014-05-11 Thread Warner Losh

On May 11, 2014, at 1:43 PM, Craig Rodrigues rodr...@freebsd.org wrote:

 Hi,
 
 No, that's not the problem, because we specifically check out
 /usr/share/mk into $WORKSPACE/mk before running the build.
 
 The problem is due to this commit:
 
 http://svnweb.freebsd.org/base/head/sys/conf/kern.mk?r1=265832r2=265841
 
 You didn't completely remove MK_FORMAT_EXTENSIONS from this file,

I never tried.

 so we are now getting this error message:
 
 make[1]: 
 /builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.opts.mk
 line 24: Could not find ../../share/mk/bsd.mkopt.mk

We assume a certain tree layout, which your script violates, so we can’t 
include this file. We simply don’t support building the kernel with such 
arbitrary system layouts.

We have to include it this way, rather than other ways, because when you are 
building out of tree you don’t pass in the root.

I don’t think this is a valid test of the build system. You are building with 
weird tree layouts. Please build with standard layouts.

 make[1]: /builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.mk
 line 38: Malformed conditional (${MK_FORMAT_EXTENSIONS} == no”)

Since we can’t include the file, anything downstream from that is just noise 
and needs to be ignored.

Warner

 --
 Craig
 
 
 On Sat, May 10, 2014 at 7:06 PM, Warner Losh i...@bsdimp.com wrote:
 
 On May 10, 2014, at 6:27 PM, Craig Rodrigues rodr...@freebsd.org wrote:
 
 Warner,
 
 It looks like your change broke the FreeBSD-HEAD-modules
 build.
 
 This build does the following:
 
 export JFLAG=-j4
 export MAKESYSPATH=${WORKSPACE}/mk
 
 Shouldn't this be ${WORKSPACE}/share/mk? MAKESYSPATH needs to be 
 .../share/mk or $TOP/share/mk when building outside of make world-like 
 environments now.
 
 Warner
 
 cd ${WORKSPACE}/sys/modules
 echo === make cleandir ===
 make cleandir
 echo === make depend ===
 make ${JFLAG} depend
 echo === make all ===
 make ${JFLAG} all
 
 
 Can you look into this?
 
 Thanks.
 
 --
 Craig
 
 
 On Fri, May 9, 2014 at 3:39 PM,  jenkins-ad...@freebsd.org wrote:
 See 
 https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/386/changes
 
 Changes:
 
 [imp] Introduce kern.opts.mk to hold all the options for kernel module
 builds. Include this in the right places. Make src.opts.mk optional so
 that modules can be built outside of the tree in the ports system.
 
 PR: 189520
 
 --
 Started by upstream project FreeBSD_HEAD build number 636
 originally caused by:
 Started by an SCM change
 Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace 
 https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/
 Updating svn://svn.freebsd.org/base/head/sys at revision 
 '2014-05-09T22:39:09.739 +'
 U conf/kmod.mk
 AUconf/kern.opts.mk
 U conf/kern.pre.mk
 At revision 265785
 Updating svn://svn.freebsd.org/base/head/share/mk at revision 
 '2014-05-09T22:39:09.739 +'
 U src.opts.mk
 At revision 265785
 [FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson6703688508778127870.sh
 + export JFLAG=-j4
 + export 
 MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
 + cd 
 https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
 + echo '=== make cleandir ==='
 === make cleandir ===
 + make cleandir
 === aac (cleandir)
 make[1]: 
 https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.opts.mk;
  line 24: Could not find ../../share/mk/bsd.mkopt.mk
 make[1]: Fatal errors encountered -- cannot continue
 make[1]: stopped in 
 https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac
 *** Error code 1
 
 Stop.
 make: stopped in 
 https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
 Build step 'Execute shell' marked build as failure
 



signature.asc
Description: Message signed with OpenPGP using GPGMail


vt(4) and i915kms doesn't work as a post-boot module

2014-05-11 Thread Adrian Chadd
Hi guys,

vt(4) doesn't work now as a post-boot loaded module.

It panics, saying

panic: vtbuf_fill_locked end.tp_row 50 must be = screen width 30

Ray, have you tried your vt(4) changes on an i915 machine but without
loading i915kms at boot?


-a
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Build failed in Jenkins: FreeBSD_HEAD-modules #395

2014-05-11 Thread Warner Losh

On May 11, 2014, at 9:49 AM, Li-Wen Hsu lw...@freebsd.org wrote:

 On Sat, May 10, 2014 at 23:21:50 -0600, Warner Losh wrote:
 
 On May 10, 2014, at 10:48 PM, jenkins-ad...@freebsd.org wrote:
 + export 
 MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
 
 This is wrong. This makes the testing invalid. It should be fixed to include 
 …/ws/share/mk. Until that’s fixed, you can ignore these whining emails.
 
 
 This job is still in testing stage, and I did not want to enable the
 mail notification that quickly.  I did not clearly mark this is a WIP
 and others think it is ready to broadcast.
 
 Sorry for bothering.  I've just turned the notification off and work
 on fix.

Just adding ‘share/‘ into the name should resolve it. I don’t have access, 
afaik, to the JIRA stuff so I can’t fix it…

Warner



signature.asc
Description: Message signed with OpenPGP using GPGMail


Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386

2014-05-11 Thread Craig Rodrigues
On Sun, May 11, 2014 at 3:25 PM, Warner Losh i...@bsdimp.com wrote:

 On May 11, 2014, at 1:43 PM, Craig Rodrigues rodr...@freebsd.org wrote:

 make[1]: 
 /builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.opts.mk
 line 24: Could not find ../../share/mk/bsd.mkopt.mk

Instead of explicitly specifying the path to ../../share/mk,
should some additional logic be added to respect
MAKESYSPATH?

Some people building products do build the kernel and modules out of the
FreeBSD source tree, and put their mk files in a directory
which is not src/share/mk.

--
Craig
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386

2014-05-11 Thread Warner Losh

On May 11, 2014, at 5:00 PM, Craig Rodrigues rodr...@freebsd.org wrote:

 On Sun, May 11, 2014 at 3:25 PM, Warner Losh i...@bsdimp.com wrote:
 
 On May 11, 2014, at 1:43 PM, Craig Rodrigues rodr...@freebsd.org wrote:
 
 make[1]: 
 /builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.opts.mk
 line 24: Could not find ../../share/mk/bsd.mkopt.mk
 
 Instead of explicitly specifying the path to ../../share/mk,
 should some additional logic be added to respect
 MAKESYSPATH?

The only logic that can work is to test MAKESYSPATH and respect it if it is 
defined, and use the relative path if not (since we don’t require MAKESYSPATH 
to be defined to do a out-of-tree module build, and could be built on a system 
that isn’t running the latest current).

 Some people building products do build the kernel and modules out of the
 FreeBSD source tree, and put their mk files in a directory
 which is not src/share/mk.

That’s not really a supported configuration. Using JIRA to force it is rather 
an annoying use of JIRA since it makes making JIRA happy hard to test and 
outside the normal work flow. This will cause pain in the future, and I also 
object to my changes being characterized as “wrong” when such a non-standard 
setup has never been explicitly supported, required or part of anybody’s normal 
workflow. Grump.

I’ve prepared a compromise commit, but I’m not happy about it, and think it is 
a horribly ugly kludge. But I can think of no other ways to keep both use cases 
working.

Warner



signature.asc
Description: Message signed with OpenPGP using GPGMail


Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386

2014-05-11 Thread Craig Rodrigues
On Sun, May 11, 2014 at 4:22 PM, Warner Losh i...@bsdimp.com wrote:


 The only logic that can work is to test MAKESYSPATH and respect it if it is 
 defined, and use the relative path if not (since we don't require MAKESYSPATH 
 to be defined to do a out-of-tree module build, and could be built on a 
 system that isn't running the latest current).

That is a legitimate patch.  I've seen people make similar changes to
the kernel makefiles an mk rules,
specifically folks who import
FreeBSD kernel source into their tree, but have the mk rules in
a non-standard place.
Thanks for applying this change.



  Using JIRA to force it is rather an annoying use of JIRA since it makes 
 making JIRA happy hard to test and outside the normal work flow.


Please use the correct terminology to avoid confusion.
Jenkins is not the same as JIRA.

--
Craig
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386

2014-05-11 Thread Warner Losh

On May 11, 2014, at 7:50 PM, Craig Rodrigues rodr...@freebsd.org wrote:

 On Sun, May 11, 2014 at 4:22 PM, Warner Losh i...@bsdimp.com wrote:
 
 
 The only logic that can work is to test MAKESYSPATH and respect it if it is 
 defined, and use the relative path if not (since we don't require 
 MAKESYSPATH to be defined to do a out-of-tree module build, and could be 
 built on a system that isn't running the latest current).
 
 That is a legitimate patch.  I've seen people make similar changes to
 the kernel makefiles an mk rules,
 specifically folks who import
 FreeBSD kernel source into their tree, but have the mk rules in
 a non-standard place.
 Thanks for applying this change.

Sure. Still not sure what I think about it, but it does work and I have bigger 
fish to fry...

 Using JIRA to force it is rather an annoying use of JIRA since it makes 
 making JIRA happy hard to test and outside the normal work flow.
 
 
 Please use the correct terminology to avoid confusion.
 Jenkins is not the same as JIRA.

Yes. Others have corrected me as well. Sorry for the confusion…

Warner



signature.asc
Description: Message signed with OpenPGP using GPGMail