Re: Need help reducing compilation warnings in CURRENT
On Thu, May 28, 2015 at 12:18 PM, Baptiste Daroussin b...@freebsd.org wrote: ... If not upstreamed, there is a good chance it get lost during the next update. So in the special case of warning fixes, I would strongly advice to upstream first!! +200 Plus upstream sources generally get slammed by multiple downstream projects, so if we can contribute back fixes or pull in upstream fixes as cherrypicks through the vendor tree, then that would reduce our diff and make sure that upstream projects benefit from our changes. The only time we should really be modifying and not giving back is when we have FreeBSD-specific modifications that don't make sense in upstream projects. Those should be rare occurrences though... Thanks, -NGie ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Need help reducing compilation warnings in CURRENT
On 28 May 2015, at 21:09, Craig Rodrigues rodr...@freebsd.org wrote: On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner x...@freebsd.org ... The warnings are almost all in contrib/ areas. Hence, any fix might want to probably be submitted to upstream first. Sure, if we can push fixes upstream that would be great. However, we shouldn't let that block us from comitting fixes to FreeBSD. Yes, that should block us in most cases, since it will make future merges more difficult. We should only fix these types of warnings locally, if: 1) The contrib project's upstream is dead, unresponsive, or hostile. 2) You are sure that you don't introduce new bugs by modifying stuff. (You definitely don't want to repeat e.g. Debian's OpenSSL fiasco.) 3) You are sure that the warning exposes a real bug, that cannot be worked around in some other way. 4) You are sure that you want to take the maintenance burden of future merges. The advantage of having code in the FreeBSD repo is that we can change it if we need to, even if the fix isn't yet in the upstream sources. Contrib code is not made out of stone that can't be modified! Certainly not, but unless you have very good reasons to modify upstream code locally, you should not bother. Better spend your energy to file fixes upstream, and let *them* verify that they are correct. -Dimitry signature.asc Description: Message signed with OpenPGP using GPGMail
Re: Need help reducing compilation warnings in CURRENT
On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner x...@freebsd.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Craig, I'll gladly help (good excuse to learn C), but looking at those errors in general, one thing pops out: The warnings are almost all in contrib/ areas. Hence, any fix might want to probably be submitted to upstream first. Sure, if we can push fixes upstream that would be great. However, we shouldn't let that block us from comitting fixes to FreeBSD. The advantage of having code in the FreeBSD repo is that we can change it if we need to, even if the fix isn't yet in the upstream sources. Contrib code is not made out of stone that can't be modified! -- Craig ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Need help reducing compilation warnings in CURRENT
On Thu, May 28, 2015 at 12:09:35PM -0700, Craig Rodrigues wrote: On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner x...@freebsd.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Craig, I'll gladly help (good excuse to learn C), but looking at those errors in general, one thing pops out: The warnings are almost all in contrib/ areas. Hence, any fix might want to probably be submitted to upstream first. Sure, if we can push fixes upstream that would be great. However, we shouldn't let that block us from comitting fixes to FreeBSD. The advantage of having code in the FreeBSD repo is that we can change it if we need to, even if the fix isn't yet in the upstream sources. Contrib code is not made out of stone that can't be modified! If not upstreamed, there is a good chance it get lost during the next update. So in the special case of warning fixes, I would strongly advice to upstream first!! Best regards, Bapt pgp0BlQSYtTQV.pgp Description: PGP signature
FreeBSD_HEAD-tests - Build #1065 - Still Unstable
FreeBSD_HEAD-tests - Build #1065 - Still Unstable: Check console output at https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1065/ to view the results. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: am335x-bone.dts not exist
On May 25, 2015, at 4:19 PM, Tim Kientzle t...@kientzle.com wrote: On May 25, 2015, at 8:25 AM, Warner Losh i...@bsdimp.com wrote: On May 24, 2015, at 7:44 PM, Tim Kientzle t...@kientzle.com wrote: On May 24, 2015, at 12:55 AM, Oleksandr Tymoshenko go...@bluezbox.com wrote: On May 24, 2015, at 12:12 AM, Garrett Cooper yaneurab...@gmail.com wrote: On May 24, 2015, at 0:07, Oleksandr Tymoshenko go...@bluezbox.com wrote: On May 23, 2015, at 7:21 PM, Andrey Fesenko f0and...@gmail.com wrote: # uname -a FreeBSD des.local 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r283306: Sat May 23 11:56:46 MSK 2015 root@des.local:/usr/obj/usr/src/sys/GENERIC amd64 I'm build BEAGLEBONE with crochet. build error Mounting UFS partition 1 at /usr/obj/_.mount.freebsd Installing U-Boot from : /usr/local/share/u-boot/u-boot-beaglebone Error: beaglebone.dts:29.1-2 syntax error FATAL ERROR: Unable to parse input tree file /usr/src/sys/boot/fdt/dts/arm/beaglebone.dts contain #include am335x-bone.dts but this file not existence. Need use am335x-evm.dts or else? am335x-bone.dts in in sys/gnu/dts/arm/, it's a file provided by vendor (TI) I guess crochet does not have this path as include path when compiling dts files. Pardon me for being a bit daft potentially, but shouldn’t #include work for all dts files (look for #include in this doc: http://events.linuxfoundation.org/sites/events/files/slides/petazzoni-device-tree-dummies.pdf )? Thanks! #include in dts file is handled by cpp(1). /include/ is handled by dtc I believe You can take a look at how FreeBSD compiles dts files in sys/tools/fdt/make_dtb.sh crochet does not have cpp stage of compilation and before my TI code/devicetree refactoring none of the dts files referenced in crochet used #include. That's why problem never appeared. Fix is just a matter of fixing freebsd_install_fdt in lib/freebsd.sh. If nobody beats me to it I'll try to fix it and submit pull request to Tim. I’m testing a fix for this now. Thanks for providing such detailed information. Is there any reason the standard dts to dtb script isn’t being used instead of enshrining another copy of that outside the tree which may break if/when we need to enhance the current script? Until recently, this didn’t seem necessary; it was a lot simpler to just invoke dtc. I changed things to require cpp when I started merging in the upstream dts files that required it. This was almost a year ago now, about the time we switched back to the GPL dtc because the BSDL one choked on a lot of the newer files. But times change: https://github.com/freebsd/crochet/commit/22d7555 Cool! Thanks! Warner signature.asc Description: Message signed with OpenPGP using GPGMail
Re: Need help reducing compilation warnings in CURRENT
On Thu, May 28, 2015 at 5:45 AM, Muhammad Moinur Rahman b...@freebsd.org wrote: Hi, Can anyone give me any ideas about how can I contribute some of my idle times? Do I need commit bit to submit patches in Jenkins? Or should I submit through CODE Review? Please read this: https://wiki.freebsd.org/CodeReview for instructions on how you can send patches to our code review tool. -- Craig ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Jenkins build is back to normal : Build-UFS-image #1733
See https://jenkins.freebsd.org/job/Build-UFS-image/1733/ ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
FreeBSD_HEAD-tests - Build #1066 - Still Unstable
FreeBSD_HEAD-tests - Build #1066 - Still Unstable: Check console output at https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1066/ to view the results. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Need help reducing compilation warnings in CURRENT
Hi, I've configured Jenkins to highlight compiler warnings and generate a table. Jenkins also keeps track of new compiler warnings over time. See: https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 Can anyone help improve the code by periodically looking at this table and submitting patches to clean up the code? Cleaning up compiler warnings is always boring work, but it is good to clean up the code over time. -- Craig ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Need help reducing compilation warnings in CURRENT
Hi Craig, I can give a hand with it. Best, 2015-05-28 14:30 GMT+08:00 Craig Rodrigues rodr...@freebsd.org: Hi, I've configured Jenkins to highlight compiler warnings and generate a table. Jenkins also keeps track of new compiler warnings over time. See: https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 Can anyone help improve the code by periodically looking at this table and submitting patches to clean up the code? Cleaning up compiler warnings is always boring work, but it is good to clean up the code over time. -- Craig ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org -- -- Marcelo Araujo(__)ara...@freebsd.org \\\'',)http://www.FreeBSD.org http://www.freebsd.org/ \/ \ ^ Power To Server. .\. /_) ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
FreeBSD_HEAD-tests - Build #1064 - Still Unstable
FreeBSD_HEAD-tests - Build #1064 - Still Unstable: Check console output at https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1064/ to view the results. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Need help reducing compilation warnings in CURRENT
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Craig, I'll gladly help (good excuse to learn C), but looking at those errors in general, one thing pops out: The warnings are almost all in contrib/ areas. Hence, any fix might want to probably be submitted to upstream first. Correct me if I'm missing something obvious here please ;-) - -J On 05/28/2015 09:30, Craig Rodrigues wrote: Hi, I've configured Jenkins to highlight compiler warnings and generate a table. Jenkins also keeps track of new compiler warnings over time. See: https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 Can anyone help improve the code by periodically looking at this table and submitting patches to clean up the code? Cleaning up compiler warnings is always boring work, but it is good to clean up the code over time. -- Craig ___ freebsd-test...@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-testing To unsubscribe, send any mail to freebsd-testing-unsubscr...@freebsd.org - -- Johannes Meixner| FreeBSD Committer x...@freebsd.org | http://people.freebsd.org/~xmj -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQEcBAEBCAAGBQJVZwxUAAoJEPyeKTcbGw0Lh7wH/2G4ZvwLCvDisEp4pJthlaQZ KNSQWTGILkhGWK2NkDqe5zsFl4SbTGIH83JgHZVoArChoa5vxQ6FXgdyYNl6ep2i kGveOpE/U/Z2OT89Jirh4dllxkSHYNd76vbUWJrG70Cgss+5JNuYxO/1hO6Vg0xj qnq1sSggjQzlMG5tgA3vobPz73p17eUdsWhlVgER18OJ3I7ZKEB+spYiu8B3N3HF E0CsoOy9NaLmVD0i7oZpaH8Rev8CJzJ9hBTDex6o/pIR735/3SZu+NtOGfU4Viqx DFfE1qIQUO1uXDFb9UK7s0SanTzJnzi9amWoiB1DSGKhgTbAF5XeTqRso6QyVxw= =FziJ -END PGP SIGNATURE- ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Need help reducing compilation warnings in CURRENT
Hi, Can anyone give me any ideas about how can I contribute some of my idle times? Do I need commit bit to submit patches in Jenkins? Or should I submit through CODE Review? BR, @bofh On Thu, May 28, 2015 at 6:38 PM, Johannes Jost Meixner x...@freebsd.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Craig, I'll gladly help (good excuse to learn C), but looking at those errors in general, one thing pops out: The warnings are almost all in contrib/ areas. Hence, any fix might want to probably be submitted to upstream first. Correct me if I'm missing something obvious here please ;-) - -J On 05/28/2015 09:30, Craig Rodrigues wrote: Hi, I've configured Jenkins to highlight compiler warnings and generate a table. Jenkins also keeps track of new compiler warnings over time. See: https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 Can anyone help improve the code by periodically looking at this table and submitting patches to clean up the code? Cleaning up compiler warnings is always boring work, but it is good to clean up the code over time. -- Craig ___ freebsd-test...@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-testing To unsubscribe, send any mail to freebsd-testing-unsubscr...@freebsd.org - -- Johannes Meixner| FreeBSD Committer x...@freebsd.org | http://people.freebsd.org/~xmj -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQEcBAEBCAAGBQJVZwxUAAoJEPyeKTcbGw0Lh7wH/2G4ZvwLCvDisEp4pJthlaQZ KNSQWTGILkhGWK2NkDqe5zsFl4SbTGIH83JgHZVoArChoa5vxQ6FXgdyYNl6ep2i kGveOpE/U/Z2OT89Jirh4dllxkSHYNd76vbUWJrG70Cgss+5JNuYxO/1hO6Vg0xj qnq1sSggjQzlMG5tgA3vobPz73p17eUdsWhlVgER18OJ3I7ZKEB+spYiu8B3N3HF E0CsoOy9NaLmVD0i7oZpaH8Rev8CJzJ9hBTDex6o/pIR735/3SZu+NtOGfU4Viqx DFfE1qIQUO1uXDFb9UK7s0SanTzJnzi9amWoiB1DSGKhgTbAF5XeTqRso6QyVxw= =FziJ -END PGP SIGNATURE- ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Need help reducing compilation warnings in CURRENT
Hi, You don't need src bit to submit any patch and you can do it via review without any problem. Just try to drive the patch to the right person. Best, 2015-05-28 20:45 GMT+08:00 Muhammad Moinur Rahman b...@freebsd.org: Hi, Can anyone give me any ideas about how can I contribute some of my idle times? Do I need commit bit to submit patches in Jenkins? Or should I submit through CODE Review? BR, @bofh On Thu, May 28, 2015 at 6:38 PM, Johannes Jost Meixner x...@freebsd.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Craig, I'll gladly help (good excuse to learn C), but looking at those errors in general, one thing pops out: The warnings are almost all in contrib/ areas. Hence, any fix might want to probably be submitted to upstream first. Correct me if I'm missing something obvious here please ;-) - -J On 05/28/2015 09:30, Craig Rodrigues wrote: Hi, I've configured Jenkins to highlight compiler warnings and generate a table. Jenkins also keeps track of new compiler warnings over time. See: https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 Can anyone help improve the code by periodically looking at this table and submitting patches to clean up the code? Cleaning up compiler warnings is always boring work, but it is good to clean up the code over time. -- Craig ___ freebsd-test...@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-testing To unsubscribe, send any mail to freebsd-testing-unsubscr...@freebsd.org - -- Johannes Meixner| FreeBSD Committer x...@freebsd.org | http://people.freebsd.org/~xmj -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQEcBAEBCAAGBQJVZwxUAAoJEPyeKTcbGw0Lh7wH/2G4ZvwLCvDisEp4pJthlaQZ KNSQWTGILkhGWK2NkDqe5zsFl4SbTGIH83JgHZVoArChoa5vxQ6FXgdyYNl6ep2i kGveOpE/U/Z2OT89Jirh4dllxkSHYNd76vbUWJrG70Cgss+5JNuYxO/1hO6Vg0xj qnq1sSggjQzlMG5tgA3vobPz73p17eUdsWhlVgER18OJ3I7ZKEB+spYiu8B3N3HF E0CsoOy9NaLmVD0i7oZpaH8Rev8CJzJ9hBTDex6o/pIR735/3SZu+NtOGfU4Viqx DFfE1qIQUO1uXDFb9UK7s0SanTzJnzi9amWoiB1DSGKhgTbAF5XeTqRso6QyVxw= =FziJ -END PGP SIGNATURE- ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org -- -- Marcelo Araujo(__)ara...@freebsd.org \\\'',)http://www.FreeBSD.org http://www.freebsd.org/ \/ \ ^ Power To Server. .\. /_) ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Need help reducing compilation warnings in CURRENT
On Wed, May 27, 2015 at 11:30:45PM -0700, Craig Rodrigues wrote: Hi, I've configured Jenkins to highlight compiler warnings and generate a table. Jenkins also keeps track of new compiler warnings over time. See: https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 Can anyone help improve the code by periodically looking at this table and submitting patches to clean up the code? Cleaning up compiler warnings is always boring work, but it is good to clean up the code over time. I take some time to do a pass over mine code or code I am somewhat knowledgable, to correct some 'assigned but not used variable' warnings. There might be even one real bug in SU code uncovered, but I am not sure yet. Please review at https://reviews.freebsd.org/D2665 . I do not have an intention of splitting this into individual changes. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
