Re: Patch for Alpha/AXP
Kazutaka YOKOTA scribbled this message on Jul 24: I am afraid this is not quite right. Bruce, Doug and I are currently in discussion to fix this. Hrm. Why does the AXP cons.c track udev_t while the x86 verson doesn't? As best as I can tell, the AXP doesn't seem to need it any more than the x86 does, unless I've missed something. As dev_t is now a struct, we cannot track dev_t for SYSCTL. It has to be udev_t. sys/i386/i386/cons.c should be doing the same as the alpha version, rather than vice versa. To quote Bruce: "alpha/alpha/cons.c should be identical with i386/i386/cons.c and not in a machine-dependent place. All current differences are bugs" :-) hmmm.. guess it's time for me to bring out my MI cons.c that I did a long time ago and dust it off?? Bruce kinda vetoed it, but I also didn't have the courage to commit it back then... and it's not hard to make it MI -- John-Mark Gurney Voice: +1 541 684 8449 Cu Networking P.O. Box 5693, 97405 "The soul contains in itself the event that shall presently befall it. The event is only the actualizing of its thought." -- Ralph Waldo Emerson To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Patch for Alpha/AXP
Does this look right? Without this patch, my AXP was memory faulting every time it booted, in the dev2udev routine. Thanks Index: alpha/alpha/cons.c === RCS file: /home/ncvs/src/sys/alpha/alpha/cons.c,v retrieving revision 1.11 diff -u -r1.11 cons.c --- cons.c 1999/06/22 14:13:16 1.11 +++ cons.c 1999/07/24 07:18:25 @@ -88,9 +88,8 @@ }; static dev_t cn_dev_t; /* seems to be never really used */ -static udev_t cn_udev_t; SYSCTL_OPAQUE(_machdep, CPU_CONSDEV, consdev, CTLFLAG_RD, - cn_udev_t, sizeof cn_udev_t, "T,dev_t", ""); + cn_dev_t, sizeof cn_dev_t, "T,dev_t", ""); static int cn_mute; @@ -185,7 +184,6 @@ cdp-d_open = cnopen; cn_tp = (*cdp-d_devtotty)(cn_tab-cn_dev); cn_dev_t = cn_tp-t_dev; - cn_udev_t = dev2udev(cn_dev_t); } static void @@ -206,7 +204,6 @@ cn_phys_open = NULL; cn_tp = NULL; cn_dev_t = 0; - cn_udev_t = dev2udev(cn_dev_t); } /* To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Patch for Alpha/AXP
Yes, looks right. In message [EMAIL PROTECTED], "Gary Palmer" writes: Does this look right? Without this patch, my AXP was memory faulting every time it booted, in the dev2udev routine. Thanks Index: alpha/alpha/cons.c === RCS file: /home/ncvs/src/sys/alpha/alpha/cons.c,v retrieving revision 1.11 diff -u -r1.11 cons.c --- cons.c 1999/06/22 14:13:16 1.11 +++ cons.c 1999/07/24 07:18:25 @@ -88,9 +88,8 @@ }; static dev_t cn_dev_t; /* seems to be never really used */ -static udev_t cn_udev_t; SYSCTL_OPAQUE(_machdep, CPU_CONSDEV, consdev, CTLFLAG_RD, - cn_udev_t, sizeof cn_udev_t, "T,dev_t", ""); + cn_dev_t, sizeof cn_dev_t, "T,dev_t", ""); static int cn_mute; @@ -185,7 +184,6 @@ cdp-d_open = cnopen; cn_tp = (*cdp-d_devtotty)(cn_tab-cn_dev); cn_dev_t = cn_tp-t_dev; - cn_udev_t = dev2udev(cn_dev_t); } static void @@ -206,7 +204,6 @@ cn_phys_open = NULL; cn_tp = NULL; cn_dev_t = 0; - cn_udev_t = dev2udev(cn_dev_t); } /* To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message -- Poul-Henning Kamp FreeBSD coreteam member [EMAIL PROTECTED] "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
