Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-23 Thread David Chisnall
On 22 Mar 2015, at 22:01, Craig Rodrigues rodr...@freebsd.org wrote: Volatile is not the solution, it is completely orthogonal. The correct way would be to use unsigned integers, for which wrapping is defined, then convert those back and forth when presenting the results to the user.

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Dimitry Andric
On 22 Mar 2015, at 23:11, Garrett Cooper yaneurab...@gmail.com wrote: On Mar 22, 2015, at 15:09, Dimitry Andric d...@freebsd.org wrote: On 22 Mar 2015, at 23:04, Garrett Cooper yaneurab...@gmail.com wrote: On Mar 22, 2015, at 15:01, Craig Rodrigues rodr...@freebsd.org wrote: ... OK,

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Craig Rodrigues
On Sun, Mar 22, 2015 at 3:01 PM, Craig Rodrigues rodr...@freebsd.org wrote: On Sun, Mar 22, 2015 at 2:36 PM, Dimitry Andric d...@freebsd.org wrote: On 22 Mar 2015, at 22:32, Craig Rodrigues rodr...@freebsd.org wrote: On Sun, Mar 22, 2015 at 2:29 PM, Dimitry Andric d...@freebsd.org

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Dimitry Andric
On 22 Mar 2015, at 22:02, Craig Rodrigues rodr...@freebsd.org wrote: On Sun, Mar 22, 2015 at 11:26 AM, jenkins-ad...@freebsd.org wrote: See https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/867/ Can someone with toolchain expertise look at this? After the clang 3.6.1 import,

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Dimitry Andric
On 22 Mar 2015, at 22:23, Dimitry Andric d...@freebsd.org wrote: On 22 Mar 2015, at 22:02, Craig Rodrigues rodr...@freebsd.org wrote: On Sun, Mar 22, 2015 at 11:26 AM, jenkins-ad...@freebsd.org wrote: See https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/867/ Can someone with

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Garrett Cooper
On Mar 22, 2015, at 14:36, Dimitry Andric d...@freebsd.org wrote: On 22 Mar 2015, at 22:32, Craig Rodrigues rodr...@freebsd.org wrote: On Sun, Mar 22, 2015 at 2:29 PM, Dimitry Andric d...@freebsd.org wrote: Ah right, that was on i386, on amd64 it does result in -2^63. It is indeed

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Craig Rodrigues
On Sun, Mar 22, 2015 at 11:26 AM, jenkins-ad...@freebsd.org wrote: See https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/867/ Can someone with toolchain expertise look at this? After the clang 3.6.1 import, /bin/expr behaves differently. With clang 3.5.0: # expr 4611686018427387904 +

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Garrett Cooper
On Mar 22, 2015, at 14:02, Craig Rodrigues rodr...@freebsd.org wrote: On Sun, Mar 22, 2015 at 11:26 AM, jenkins-ad...@freebsd.org wrote: See https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/867/ Can someone with toolchain expertise look at this? After the clang 3.6.1 import,

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Dimitry Andric
On 22 Mar 2015, at 22:32, Craig Rodrigues rodr...@freebsd.org wrote: On Sun, Mar 22, 2015 at 2:29 PM, Dimitry Andric d...@freebsd.org wrote: Ah right, that was on i386, on amd64 it does result in -2^63. It is indeed caused by reliance on signed integer wrapping. This diff should fix

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Craig Rodrigues
On Sun, Mar 22, 2015 at 2:29 PM, Dimitry Andric d...@freebsd.org wrote: Ah right, that was on i386, on amd64 it does result in -2^63. It is indeed caused by reliance on signed integer wrapping. This diff should fix it, without rewriting the utility: Index: bin/expr/Makefile

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Craig Rodrigues
On Sun, Mar 22, 2015 at 2:36 PM, Dimitry Andric d...@freebsd.org wrote: On 22 Mar 2015, at 22:32, Craig Rodrigues rodr...@freebsd.org wrote: On Sun, Mar 22, 2015 at 2:29 PM, Dimitry Andric d...@freebsd.org wrote: Ah right, that was on i386, on amd64 it does result in -2^63. It is

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Garrett Cooper
On Mar 22, 2015, at 15:01, Craig Rodrigues rodr...@freebsd.org wrote: ... OK, converting expr.y to use unsigned integers would require a bit of work. Can you commit your patch to the Makefile? It fixes the problem for now. +1 I’d still like to know why clang 3.5 doesn’t have this behavior

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Dimitry Andric
On 22 Mar 2015, at 23:04, Garrett Cooper yaneurab...@gmail.com wrote: On Mar 22, 2015, at 15:01, Craig Rodrigues rodr...@freebsd.org wrote: ... OK, converting expr.y to use unsigned integers would require a bit of work. Can you commit your patch to the Makefile? It fixes the problem

Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867

2015-03-22 Thread Garrett Cooper
On Mar 22, 2015, at 15:09, Dimitry Andric d...@freebsd.org wrote: On 22 Mar 2015, at 23:04, Garrett Cooper yaneurab...@gmail.com wrote: On Mar 22, 2015, at 15:01, Craig Rodrigues rodr...@freebsd.org wrote: ... OK, converting expr.y to use unsigned integers would require a bit of work.