Re: dc(4) patch

2002-09-20 Thread John Baldwin
On 19-Sep-2002 Vincent Poy wrote: I think the first card is a LinkSys PCMP200 and not the PCMP100 since the 100 is a 16bit PCMCIA and runs as a ed1 adapter in 4.6.2-RELEASE but doesn't get recognized at all under -current. I've tried both the LinkSys PCMP200 v2.0/PCMPC200 v2.0 and the

Re: dc(4) patch

2002-09-20 Thread Stephen McKay
On Thursday, 19th September 2002, John Baldwin wrote: --- if_dc.c 4 Sep 2002 18:14:17 - 1.77 +++ if_dc.c 19 Sep 2002 20:57:03 - @@ -1366,7 +1370,8 @@ for (i = 0; i DC_TIMEOUT; i++) { isr = CSR_READ_4(sc, DC_ISR);

Re: dc(4) patch

2002-09-20 Thread John Baldwin
On 20-Sep-2002 Stephen McKay wrote: On Thursday, 19th September 2002, John Baldwin wrote: --- if_dc.c 4 Sep 2002 18:14:17 - 1.77 +++ if_dc.c 19 Sep 2002 20:57:03 - @@ -1366,7 +1370,8 @@ for (i = 0; i DC_TIMEOUT; i++) { isr =

Re: dc(4) patch

2002-09-20 Thread Stephen McKay
On Friday, 20th September 2002, John Baldwin wrote: On 20-Sep-2002 Stephen McKay wrote: Sadly this change is insufficient to satisfy all cards. Well. I think we can keep the check for TX going idle and just not do the check for RX going idle. The original code basically did this until you

Re: dc(4) patch

2002-09-20 Thread John Baldwin
On 20-Sep-2002 Stephen McKay wrote: On Friday, 20th September 2002, John Baldwin wrote: On 20-Sep-2002 Stephen McKay wrote: Sadly this change is insufficient to satisfy all cards. Well. I think we can keep the check for TX going idle and just not do the check for RX going idle. The

Re: dc(4) patch

2002-09-20 Thread Stephen McKay
On Friday, 20th September 2002, John Baldwin wrote: On 20-Sep-2002 Stephen McKay wrote: Not quite. Davicom cards (and your card) fail to idle the receiver. PNIC cards fail to idle the transmitter. So it makes just as much sense as any other idea to check those bits only on cards that

Re: dc(4) patch

2002-09-20 Thread Vincent Poy
On Fri, 20 Sep 2002, John Baldwin wrote: On 19-Sep-2002 Vincent Poy wrote: I think the first card is a LinkSys PCMP200 and not the PCMP100 since the 100 is a 16bit PCMCIA and runs as a ed1 adapter in 4.6.2-RELEASE but doesn't get recognized at all under -current. I've tried both

Re: dc(4) patch

2002-09-19 Thread Martin Blapp
Hi John, See the patch I've submitted last week or previous week. Topic was uncomitted dc0 PR's. I had a patch for this there. Martin Martin Blapp, [EMAIL PROTECTED] [EMAIL PROTECTED] -- ImproWare AG, UNIXSP ISP,

Re: dc(4) patch

2002-09-19 Thread Martin Blapp
Hi John, Your patch looks correct ! Thanks to finding this out. Can you commit this or do you wait for McKay ? Or should I ;-) ? Ps: the automatic TX underrun recovery still needs to be comitted. Without it no cvsup survives here. Martin Martin Blapp, [EMAIL PROTECTED] [EMAIL PROTECTED]

Re: dc(4) patch

2002-09-19 Thread John Baldwin
On 19-Sep-2002 Martin Blapp wrote: Hi John, See the patch I've submitted last week or previous week. Topic was uncomitted dc0 PR's. I had a patch for this there. IIRC, yours completely disabled the check. It would seem to make good sense to still try to force the card idle before

Re: dc(4) patch

2002-09-19 Thread Vincent Poy
On Thu, 19 Sep 2002, John Baldwin wrote: A while ago I started having problems with a dc(4) cardbus card that I hadn't had before. Lots of failures to force tx and rx to idle state resulting in the card eventually hanging under load and basically being worthless until I ejected it and