Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-18 Thread Bruce Evans
On Fri, 17 Aug 2001, David O'Brien wrote: On Wed, Aug 15, 2001 at 12:40:19PM +1000, Bruce Evans wrote: On Tue, 14 Aug 2001, Ruslan Ermilov wrote: On Tue, Aug 14, 2001 at 08:55:56AM -0700, David O'Brien wrote: From a correctness stand point, building the .mgc files at install time

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-17 Thread David O'Brien
On Fri, Aug 10, 2001 at 05:37:51PM +0300, Ruslan Ermilov wrote: I can't believe I hear that from you, Bruce. :-) Generation at install time is a damn bad idea, please see below. [...] 1. This won't work for cross-platform installworld, since ./file is targetted for a different platform.

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-17 Thread Ruslan Ermilov
On Fri, Aug 17, 2001 at 08:49:10AM -0700, David O'Brien wrote: On Fri, Aug 10, 2001 at 05:37:51PM +0300, Ruslan Ermilov wrote: I can't believe I hear that from you, Bruce. :-) Generation at install time is a damn bad idea, please see below. [...] 1. This won't work for cross-platform

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-17 Thread Warner Losh
In message [EMAIL PROTECTED] David O'Brien writes: : We should decide if a cross-platform must be : installworld'able on the host, target, or both. Having brought up ports on other OSes, I've found the ability to install a target on a host to be useful. I think it should be a goal, unless it

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-15 Thread Ruslan Ermilov
On Wed, Aug 15, 2001 at 12:40:19PM +1000, Bruce Evans wrote: [...] +mkmagic: apprentice.c print-hacked.c + ${HOST_CC} -o mkmagic -DHAVE_CONFIG_H -DCOMPILE_ONLY \ + -I${.CURDIR} -I${SRCDIR} ${.ALLSRC} Whoa, cool! That's what I wanted from the very beginning

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-15 Thread Bruce Evans
On Wed, 15 Aug 2001, Ruslan Ermilov wrote: On Wed, Aug 15, 2001 at 12:40:19PM +1000, Bruce Evans wrote: I agree (except the build-tools concept is a hack to work around build-tools binaries not being buildable and installable in the usual way (with 1 binary per Makefile)). It seems

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-14 Thread Ruslan Ermilov
On Mon, Aug 13, 2001 at 01:30:15PM -0700, David O'Brien wrote: On Fri, Aug 10, 2001 at 08:23:00PM +0300, Ruslan Ermilov wrote: Your solution does not work. You're creating binary files in HOST format during the build phase and expecting things such as alignment and endianness to be

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-14 Thread David O'Brien
On Tue, Aug 14, 2001 at 09:54:04AM +0300, Ruslan Ermilov wrote: They produce the same output, but in the general case they do not need to. What I hear? Hell, then my solution (or something similar) should be committed, as it at least unbreaks the 4.x - 5.0 upgrade path, which I am

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-14 Thread Ruslan Ermilov
On Tue, Aug 14, 2001 at 08:55:56AM -0700, David O'Brien wrote: On Tue, Aug 14, 2001 at 09:54:04AM +0300, Ruslan Ermilov wrote: They produce the same output, but in the general case they do not need to. What I hear? Hell, then my solution (or something similar) should be committed,

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-14 Thread David O'Brien
On Tue, Aug 14, 2001 at 08:30:45PM +0300, Ruslan Ermilov wrote: Just to clarify. Nothing should be built in ${.OBJDIR} at install time, as it may be read-only. Correct. The build in ${DESTDIR} is allowed, we, for example, execute makewhatis(1) at the end of `installworld'. But this

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-14 Thread Bruce Evans
On Tue, 14 Aug 2001, Ruslan Ermilov wrote: On Tue, Aug 14, 2001 at 08:55:56AM -0700, David O'Brien wrote: From a correctness stand point, building the .mgc files at install time is the correct thing to do... or maybe we should do both -- doing the [re]creation of the .mgc files at install

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-14 Thread Bruce Evans
On Tue, 14 Aug 2001, David O'Brien wrote: On Tue, Aug 14, 2001 at 08:30:45PM +0300, Ruslan Ermilov wrote: The build in ${DESTDIR} is allowed, we, for example, execute makewhatis(1) at the end of `installworld'. But this build is implicit, i.e., it's not done by make dependencies. What

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-13 Thread Ruslan Ermilov
On Sat, Aug 11, 2001 at 11:51:18AM -0700, Terry Lambert wrote: [...] If this is really a goal, then you should redesign the process and not put more and more tools into the build tools category to work around these problems. Take a look at sysinstall/Makefile to have a better idea

Re: Cross builds and upgrade path from 4.x are broken in usr.bin

2001-08-13 Thread Ruslan Ermilov
On Fri, Aug 10, 2001 at 11:54:27AM -0700, John Baldwin wrote: On 10-Aug-01 Ruslan Ermilov wrote: On Fri, Aug 10, 2001 at 10:04:01AM -0700, Mark Peek wrote: At 7:14 PM +0300 8/10/01, Ruslan Ermilov wrote: On Fri, Aug 10, 2001 at 08:38:21AM -0700, Mark Peek wrote: At 5:37 PM +0300

Re: Cross builds and upgrade path from 4.x are broken in usr.bin

2001-08-13 Thread John Baldwin
On 13-Aug-01 Ruslan Ermilov wrote: On Fri, Aug 10, 2001 at 11:54:27AM -0700, John Baldwin wrote: On 10-Aug-01 Ruslan Ermilov wrote: On Fri, Aug 10, 2001 at 10:04:01AM -0700, Mark Peek wrote: At 7:14 PM +0300 8/10/01, Ruslan Ermilov wrote: On Fri, Aug 10, 2001 at 08:38:21AM -0700, Mark

Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-13 Thread David O'Brien
On Fri, Aug 10, 2001 at 08:23:00PM +0300, Ruslan Ermilov wrote: Your solution does not work. You're creating binary files in HOST format during the build phase and expecting things such as alignment and endianness to be the same as the TARGET format. Unless the tools are built to

Cross builds and upgrade path from 4.x are broken in usr.bin/file

2001-08-09 Thread Ruslan Ermilov
David! As you have been warned, revisions 1.19 and 1.20 to file/Makefile broke cross builds and upgrade path from 4.x to 5.0. This is due to the use of just built ./file binary to produce magic.mgc and magic.mime.mgc files. In the case of 4.x-5.0 upgrade, buildworld bombs with ./file -C -m