Re: Fix Emulex "oce" driver in CURRENT

2014-12-05 Thread sthaug
> >> Seems 10.1 is on the pipeline now, but as far as I know none of these > >> fixes have been applied to -STABLE. Any chances to do it yet? As far as I > >> know, the "oce" driver is currently unusable in -STABLE. I managed to > >> cause a panic reliably within 30 seconds. > > > > Was there a

Re: Fix Emulex "oce" driver in CURRENT

2014-12-05 Thread Steven Hartland
On 05/12/2014 13:07, Borja Marcos wrote: On Dec 5, 2014, at 2:00 PM, Steven Hartland wrote: On 04/09/2014 09:49, Borja Marcos wrote: On Jun 30, 2014, at 8:02 PM, John Baldwin wrote: I think these sound fine, but I've cc'd Xin Li (delphij@) who has worked with folks at Emulex to maintain thi

Re: Fix Emulex "oce" driver in CURRENT

2014-12-05 Thread Borja Marcos
On Dec 5, 2014, at 2:00 PM, Steven Hartland wrote: > > On 04/09/2014 09:49, Borja Marcos wrote: >> On Jun 30, 2014, at 8:02 PM, John Baldwin wrote: >> >>> I think these sound fine, but I've cc'd Xin Li (delphij@) who has worked >>> with >>> folks at Emulex to maintain this driver. He is proba

Re: Fix Emulex "oce" driver in CURRENT

2014-12-05 Thread Steven Hartland
On 04/09/2014 09:49, Borja Marcos wrote: On Jun 30, 2014, at 8:02 PM, John Baldwin wrote: I think these sound fine, but I've cc'd Xin Li (delphij@) who has worked with folks at Emulex to maintain this driver. He is probably the best person to review this. Hi, Seems 10.1 is on the pipeline n

Re: Fix Emulex "oce" driver in CURRENT

2014-09-04 Thread Borja Marcos
On Jun 30, 2014, at 8:02 PM, John Baldwin wrote: > > I think these sound fine, but I've cc'd Xin Li (delphij@) who has worked with > folks at Emulex to maintain this driver. He is probably the best person to > review this. Hi, Seems 10.1 is on the pipeline now, but as far as I know none of th

Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 Thread Borja Marcos
On Jul 15, 2014, at 1:36 PM, Stefano Garzarella wrote: > So, asking for spiritual counsel now. Would you use this driver in a > production environment instead of the 747 version downloaded from Emulex? I > think the latter is giving slightly better performance but, anyway, I disable > LRO and

Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 Thread Stefano Garzarella
2014-07-15 12:00 GMT+02:00 Borja Marcos : > > On Jul 15, 2014, at 11:45 AM, Stefano Garzarella wrote: > > > I just tried to run iperf3 with this patch and STABLE-10 and it seems to > > work. > > Do you have a panic? > > So far, so good. I've ran a couple of iperf3 tests (60 seconds, trying > both

Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 Thread Borja Marcos
On Jul 15, 2014, at 11:45 AM, Stefano Garzarella wrote: > I just tried to run iperf3 with this patch and STABLE-10 and it seems to > work. > Do you have a panic? So far, so good. I've ran a couple of iperf3 tests (60 seconds, trying both directions) and it doesn't crash. Without the fixes I ob

Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 Thread Stefano Garzarella
2014-07-15 11:46 GMT+02:00 Borja Marcos : > > On Jul 15, 2014, at 11:45 AM, Stefano Garzarella wrote: > > > I just tried to run iperf3 with this patch and STABLE-10 and it seems to > work. > > Do you have a panic? > > Still compiling :) Anyway, you didn't suffer panics before, right? Right, I di

Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 Thread Borja Marcos
On Jul 15, 2014, at 11:45 AM, Stefano Garzarella wrote: > I just tried to run iperf3 with this patch and STABLE-10 and it seems to work. > Do you have a panic? Still compiling :) Anyway, you didn't suffer panics before, right? Borja. ___ freebsd-c

Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 Thread Stefano Garzarella
I just tried to run iperf3 with this patch and STABLE-10 and it seems to work. Do you have a panic? Cheers, Stefano 2014-07-15 11:19 GMT+02:00 Stefano Garzarella : > I think there is some problem with the email formatting. > I send you a file with both patches. > > Cheers, > Stefano > > > 2014-

Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 Thread Stefano Garzarella
I think there is some problem with the email formatting. I send you a file with both patches. Cheers, Stefano 2014-07-15 11:12 GMT+02:00 Borja Marcos : > > On Jul 15, 2014, at 10:43 AM, Stefano Garzarella wrote: > > > I used the "oce" driver in CURRENT. > > I think that this patch in combinatio

Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 Thread Borja Marcos
On Jul 15, 2014, at 10:43 AM, Stefano Garzarella wrote: > I used the "oce" driver in CURRENT. > I think that this patch in combination with the previous one should work in > 10-STABLE. > > I have only tested if it works with CURRENT, but now I try if it works with > 10-STABLE and I'll send you s

Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 Thread Borja Marcos
On Jul 15, 2014, at 10:43 AM, Stefano Garzarella wrote: > I used the "oce" driver in CURRENT. > I think that this patch in combination with the previous one should work in > 10-STABLE. > > I have only tested if it works with CURRENT, but now I try if it works with > 10-STABLE and I'll send yo

Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 Thread Stefano Garzarella
I used the "oce" driver in CURRENT. I think that this patch in combination with the previous one should work in 10-STABLE. I have only tested if it works with CURRENT, but now I try if it works with 10-STABLE and I'll send you some feedback. Cheers, Stefano 2014-07-15 10:28 GMT+02:00 Borja Marc

Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 Thread Borja Marcos
On Jul 15, 2014, at 10:22 AM, Stefano Garzarella wrote: > Hi, > I found other problems in the "oce" driver during some experiments with > netmap in emulation mode. What about driver version 10.0.747.0? At least in my configuration it works perfectly, no crashes despite keeping it running for s

Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 Thread Stefano Garzarella
Hi, I found other problems in the "oce" driver during some experiments with netmap in emulation mode. In details: - missing locking: - in some functions there are write accesses on the wq struct (tx queue descriptor) without acquire LOCK on the queue, particularly in oce_wq_handler() that is invok

Re: Fix Emulex "oce" driver in CURRENT

2014-07-07 Thread Luigi Rizzo
On Mon, Jul 7, 2014 at 1:57 PM, Borja Marcos wrote: ... > The environment details are here: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=183391 > > The way I produce an instant panic is: > > 1) Connect to another machine (cross connect cable) > > 2) iperf3 -s on the other machine > (The

Re: Fix Emulex "oce" driver in CURRENT

2014-07-07 Thread Borja Marcos
On Jul 7, 2014, at 1:23 PM, Luigi Rizzo wrote: > On Mon, Jul 7, 2014 at 1:03 PM, Borja Marcos wrote: > we'll try to investigate, can you tell us more about the environment you use ? > (FreeBSD version, card model (PCI id perhaps), iperf3 invocation line, > interface configuration etc.) > > The

Re: Fix Emulex "oce" driver in CURRENT

2014-07-07 Thread Luigi Rizzo
On Mon, Jul 7, 2014 at 1:03 PM, Borja Marcos wrote: > > On Jul 1, 2014, at 10:24 PM, Luigi Rizzo wrote: > >> >> >> >> On Tue, Jul 1, 2014 at 8:58 PM, wrote: >> El 30.06.2014 18:36, Stefano Garzarella escribió: >> >> Hello, >> I had problems during some experiments with Emulex and "oce" driver in

Re: Fix Emulex "oce" driver in CURRENT

2014-07-07 Thread Borja Marcos
On Jul 1, 2014, at 10:24 PM, Luigi Rizzo wrote: > > > > On Tue, Jul 1, 2014 at 8:58 PM, wrote: > El 30.06.2014 18:36, Stefano Garzarella escribió: > > Hello, > I had problems during some experiments with Emulex and "oce" driver in > CURRENT. > I found several bugs in the "oce" driver and thi

Re: Fix Emulex "oce" driver in CURRENT

2014-07-01 Thread Luigi Rizzo
On Tue, Jul 1, 2014 at 8:58 PM, wrote: > El 30.06.2014 18:36, Stefano Garzarella escribió: > > Hello, >> I had problems during some experiments with Emulex and "oce" driver in >> CURRENT. >> I found several bugs in the "oce" driver and this patch fixes them. >> > > At least with some cards, the

Re: Fix Emulex "oce" driver in CURRENT

2014-07-01 Thread borjam
El 30.06.2014 18:36, Stefano Garzarella escribió: Hello, I had problems during some experiments with Emulex and "oce" driver in CURRENT. I found several bugs in the "oce" driver and this patch fixes them. At least with some cards, the driver simply does not work. It causes a panic when there i

Re: Fix Emulex "oce" driver in CURRENT

2014-06-30 Thread John Baldwin
On Monday, June 30, 2014 12:36:22 pm Stefano Garzarella wrote: > Hello, > I had problems during some experiments with Emulex and "oce" driver in > CURRENT. > I found several bugs in the "oce" driver and this patch fixes them. > > - oce_multiq_start(): if the link is down returns ENXIO without cons

Fix Emulex "oce" driver in CURRENT

2014-06-30 Thread Stefano Garzarella
Hello, I had problems during some experiments with Emulex and "oce" driver in CURRENT. I found several bugs in the "oce" driver and this patch fixes them. - oce_multiq_start(): if the link is down returns ENXIO without consuming the mbuf. A trivial fix is to remove the initial error check, since