Re: Proposal: Disable compression of newsyslog by default

2023-12-25 Thread Mike Karels
On 25 Dec 2023, at 2:12, Xin Li wrote: > On 2023-12-23 14:17, Mike Karels wrote: >> On 23 Dec 2023, at 15:23, Craig Leres wrote: >> >>> On 12/23/23 06:52, Konstantin Belousov wrote: This is strange change at best. I have no opinion about the disabling of compression of the rotated logs

Re: Proposal: Disable compression of newsyslog by default

2023-12-25 Thread Xin Li
On 2023-12-23 14:17, Mike Karels wrote: On 23 Dec 2023, at 15:23, Craig Leres wrote: On 12/23/23 06:52, Konstantin Belousov wrote: This is strange change at best. I have no opinion about the disabling of compression of the rotated logs by default, but we already have knobs to do that.

Re: Proposal: Disable compression of newsyslog by default

2023-12-25 Thread Xin Li
On 2023-12-24 10:03, Rodney W. Grimes wrote: On 2023-12-23 06:52, Konstantin Belousov wrote: On Fri, Dec 22, 2023 at 11:18:23PM -0800, Xin Li wrote: Hi, Inspired by D42961, I propose that we move forward with disabling the compression by default in newsyslog, as implemented in

Re: Proposal: Disable compression of newsyslog by default

2023-12-24 Thread Rodney W. Grimes
> On 2023-12-23 10:17, Ceri Davies wrote: > > I really don?t like the idea of adding flags that make the program ignore a > > config file. I also think this is premature until ZFS installs are default > > on all architectures. > > > > However, if you must (and I see you have) change this,

Re: Proposal: Disable compression of newsyslog by default

2023-12-24 Thread Rodney W. Grimes
> On 2023-12-23 06:52, Konstantin Belousov wrote: > > On Fri, Dec 22, 2023 at 11:18:23PM -0800, Xin Li wrote: > >> Hi, > >> > >> Inspired by D42961, I propose that we move forward with disabling the > >> compression by default in newsyslog, as implemented in > >> https://reviews.freebsd.org/D43169

Re: Proposal: Disable compression of newsyslog by default

2023-12-24 Thread Alex Dupre
Xin Li wrote: > Inspired by D42961, I propose that we move forward with disabling the > compression by default in newsyslog, as implemented in > https://reviews.freebsd.org/D43169 I like the possibility to entirely disable compression on log files, or to select a specific compression algorithm,

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Tomoaki AOKI
On Sat, 23 Dec 2023 15:14:20 -0800 Xin Li wrote: > On 2023-12-23 07:09, Enji Cooper wrote: > > This impacts embedded systems or jails which use UFS as the default > > /var/log backed device. There are quite a few larger consumers of > > FreeBSD out there that still use UFS instead of ZFS. > > I

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Sulev-Madis Silber
On 23 December 2023 09:18:23 EET, Xin Li wrote: >Hi, > >Inspired by D42961, I propose that we move forward with disabling the >compression by default in newsyslog, as implemented in >https://reviews.freebsd.org/D43169 > >Historically, newsyslog has compressed rotated log files to save disk

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Xin Li
On 2023-12-23 07:09, Enji Cooper wrote: This impacts embedded systems or jails which use UFS as the default /var/log backed device. There are quite a few larger consumers of FreeBSD out there that still use UFS instead of ZFS. I appreciate your feedback! Thank you for pointing out the

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Xin Li
On 2023-12-23 10:17, Ceri Davies wrote: I really don’t like the idea of adding flags that make the program ignore a config file. I also think this is premature until ZFS installs are default on all architectures. However, if you must (and I see you have) change this, please don’t call the

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Xin Li
On 2023-12-23 13:08, Steve Kargl wrote: On Sat, Dec 23, 2023 at 11:13:23AM -0800, Xin Li wrote: I appreciate your perspective on this issue. However, I believe there are additional benefits to modifying the newsyslog code (which is already done in commit 906748d208d3, by the way) beyond what

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Mike Karels
On 23 Dec 2023, at 15:23, Craig Leres wrote: > On 12/23/23 06:52, Konstantin Belousov wrote: >> This is strange change at best. I have no opinion about the disabling >> of compression of the rotated logs by default, but we already have knobs >> to do that. Adding a knob that disables (or

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Craig Leres
On 12/23/23 06:52, Konstantin Belousov wrote: This is strange change at best. I have no opinion about the disabling of compression of the rotated logs by default, but we already have knobs to do that. Adding a knob that disables (or enables) other knobs to work is weird. I totally agree.

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Steve Kargl
On Sat, Dec 23, 2023 at 11:13:23AM -0800, Xin Li wrote: > > I appreciate your perspective on this issue. However, I believe there are > additional benefits to modifying the newsyslog code (which is already done > in commit 906748d208d3, by the way) beyond what can be achieved by simply >

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Xin Li
On 2023-12-23 06:52, Konstantin Belousov wrote: On Fri, Dec 22, 2023 at 11:18:23PM -0800, Xin Li wrote: Hi, Inspired by D42961, I propose that we move forward with disabling the compression by default in newsyslog, as implemented in https://reviews.freebsd.org/D43169 Historically, newsyslog

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Xin Li
On 2023-12-23 00:51, Miroslav Lachman wrote: On 23/12/2023 08:18, Xin Li wrote: Hi, Inspired by D42961, I propose that we move forward with disabling the compression by default in newsyslog, as implemented in https://reviews.freebsd.org/D43169 Historically, newsyslog has compressed rotated

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Michael Gmelin
> On 23. Dec 2023, at 16:10, Enji Cooper wrote: > >  >> On Dec 22, 2023, at 23:18, Xin Li wrote: >> >> Hi, >> >> Inspired by D42961, I propose that we move forward with disabling the >> compression by default in newsyslog, as implemented in >> https://reviews.freebsd.org/D43169 >> >>

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Enji Cooper
> On Dec 22, 2023, at 23:18, Xin Li wrote: > > Hi, > > Inspired by D42961, I propose that we move forward with disabling the > compression by default in newsyslog, as implemented in > https://reviews.freebsd.org/D43169 > > Historically, newsyslog has compressed rotated log files to save

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Konstantin Belousov
On Fri, Dec 22, 2023 at 11:18:23PM -0800, Xin Li wrote: > Hi, > > Inspired by D42961, I propose that we move forward with disabling the > compression by default in newsyslog, as implemented in > https://reviews.freebsd.org/D43169 > > Historically, newsyslog has compressed rotated log files to

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Marek Zarychta
W dniu 23.12.2023 o 09:51, Miroslav Lachman pisze: On 23/12/2023 08:18, Xin Li wrote: Hi, Inspired by D42961, I propose that we move forward with disabling the compression by default in newsyslog, as implemented in https://reviews.freebsd.org/D43169 Historically, newsyslog has compressed

Re: Proposal: Disable compression of newsyslog by default

2023-12-23 Thread Miroslav Lachman
On 23/12/2023 08:18, Xin Li wrote: Hi, Inspired by D42961, I propose that we move forward with disabling the compression by default in newsyslog, as implemented in https://reviews.freebsd.org/D43169 Historically, newsyslog has compressed rotated log files to save disk space. This approach

Re: Proposal: Disable compression of newsyslog by default

2023-12-22 Thread Fabian Keil
Xin Li wrote on 2023-12-22 at 23:18:23: > Inspired by D42961, I propose that we move forward with disabling the > compression by default in newsyslog, as implemented in > https://reviews.freebsd.org/D43169 [...] > Therefore I would propose that we change the default compression setting > to

Proposal: Disable compression of newsyslog by default

2023-12-22 Thread Xin Li
Hi, Inspired by D42961, I propose that we move forward with disabling the compression by default in newsyslog, as implemented in https://reviews.freebsd.org/D43169 Historically, newsyslog has compressed rotated log files to save disk space. This approach was valuable in the early days where