Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM

2012-01-12 Thread Dag-Erling Smørgrav
Don Lewis writes: > building shared library libpam.so.5 > make: don't know how to make openpam.3. Stop > *** Error code 2 Ah, yes, the man pages are generated during the release process, so you either have to copy them over from the original contrib/openpam directory (or export the new sources on

Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM

2012-01-11 Thread Don Lewis
On 11 Jan, Dag-Erling Smørgrav wrote: > Could you please try this: > > # cd /usr/src/contrib > # mv openpam openpam.orig > # svn export svn://svn.des.no/openpam/trunk@526 openpam > # cd ../lib/libpam > # make depend && make all && make install [snip] building shared library libpam.so.5 make: don'

Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM

2012-01-10 Thread Dag-Erling Smørgrav
Could you please try this: # cd /usr/src/contrib # mv openpam openpam.orig # svn export svn://svn.des.no/openpam/trunk@526 openpam # cd ../lib/libpam # make depend && make all && make install In addition to the pam.conf issue, the major changes relative to head are reduced log spam, improved log

Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM

2012-01-10 Thread Don Lewis
On 10 Jan, Dag-Erling Smørgrav wrote: > If at any point in this conversation I seemed to make _no sense at all_, > it was because I conflated it with a completely different OpenPAM issue > (error reporting in openpam_dynamic.c) which has been on my mind lately. > Sorry about that. I will attempt t

Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM

2012-01-10 Thread Dag-Erling Smørgrav
If at any point in this conversation I seemed to make _no sense at all_, it was because I conflated it with a completely different OpenPAM issue (error reporting in openpam_dynamic.c) which has been on my mind lately. Sorry about that. I will attempt to address both issues in the next release, whi

Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM

2012-01-09 Thread Don Lewis
On 9 Jan, Dag-Erling Smørgrav wrote: > Don Lewis writes: >> After staring at the code a lot more, I see your point about the loss of >> information. The problem is that openpam_parse_chain() returns >> PAM_SUCCESS whether or not if found anything, but we want the loop to >> terminate when either

Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM

2012-01-09 Thread Dag-Erling Smørgrav
Don Lewis writes: > After staring at the code a lot more, I see your point about the loss of > information. The problem is that openpam_parse_chain() returns > PAM_SUCCESS whether or not if found anything, but we want the loop to > terminate when either an error is detected or if openpam_parse_ch

Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM

2012-01-09 Thread Don Lewis
On 9 Jan, Dag-Erling Smørgrav wrote: > Don Lewis writes: >> Dag-Erling Smørgrav writes: >> > The culprit was this commit: >> > >> > http://trac.des.no/openpam/changeset/487/trunk/lib/openpam_configure.c >> > >> > However, I'm not confident that simply reverting this commit is the >> > right wa

Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM

2012-01-09 Thread Dag-Erling Smørgrav
Don Lewis writes: > Dag-Erling Smørgrav writes: > > The culprit was this commit: > > > > http://trac.des.no/openpam/changeset/487/trunk/lib/openpam_configure.c > > > > However, I'm not confident that simply reverting this commit is the > > right way to go. > Thanks for the detective work. It l

Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM

2012-01-09 Thread Don Lewis
On 9 Jan, Dag-Erling Smørgrav wrote: > Don Lewis writes: >> The documentation says that /etc/pam.conf is only used if >> /etc/pam.d/service-name isn't found, and the code appears to agree >> with that, however this doesn't seem to be working as expected after >> the latest import of PAM. > > The

Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM

2012-01-09 Thread Dag-Erling Smørgrav
Don Lewis writes: > The documentation says that /etc/pam.conf is only used if > /etc/pam.d/service-name isn't found, and the code appears to agree > with that, however this doesn't seem to be working as expected after > the latest import of PAM. The culprit was this commit: http://trac.des.no/op

couldn't log on to my -CURRENT machine after upgrade to latest PAM

2012-01-07 Thread Don Lewis
I just upgraded my -CURRENT machine for the first time since mid-November. When I rebooted, I was surprised that I was unable to log in via either ssh or directly on the console. The diagnostics printed to the console indicated that pam_skey.so was missing. Since that was nuked a long time ago,