Re: Fw: Stop annoying message of lnc
> Ian Dowse wrote: > > > > In message <[EMAIL PROTECTED]>, Mike Smith writes: > > > > > >I don't quite understand Paul's reasoning, though; it's not actually > > >useful to unload/reload parts of a device's bus attachment without > > >unloading/reloading all the downstream parts of the driver. > > What do you mean by the downstream parts of the driver? 1 nexus | 2 PCI bus | 3 PCI interface of driver | 4 driver core It makes limited sense, with this structure, to unload just #3. What you're trying to do is take a specialised development hack and wedge it into the production version of the driver. Don't do that. 8) > We're not there yet, but I can see a time where we would want to > load/unload the probe functions as we do hardware probing and then only > pull in the rest of the driver when we associate that driver to the > device. We've already been down this path. Given the size of our device drivers, it's a very false economy. -- ... every activity meets with opposition, everyone who acts has his rivals and unfortunately opponents also. But not because people want to be opponents, rather because the tasks and relationships force people to take different points of view. [Dr. Fritz Todt] V I C T O R Y N O T V E N G E A N C E To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Fw: Stop annoying message of lnc
Ian Dowse wrote: > > In message <[EMAIL PROTECTED]>, Mike Smith writes: > > > >I don't quite understand Paul's reasoning, though; it's not actually > >useful to unload/reload parts of a device's bus attachment without > >unloading/reloading all the downstream parts of the driver. What do you mean by the downstream parts of the driver? I think it makes sense to be able to load/unload the bus specific parts of the driver independently. If you've only got a PCI device installed there's no reason to keep the ISA bus code in the kernel. We're not there yet, but I can see a time where we would want to load/unload the probe functions as we do hardware probing and then only pull in the rest of the driver when we associate that driver to the device. > >I think the fix should probably be committed and the driver turned into a > >single monolithic module. > > Yes, Paul essentially agreed to my doing this as an interim measure > until ifconfig is "fixed" to use the module file name rather than > the module name when loading drivers. I'll commit the change in a > few hours after I have tested that it works. Thanks. Paul. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Fw: Stop annoying message of lnc
In message <[EMAIL PROTECTED]>, Mike Smith writes: > >I don't quite understand Paul's reasoning, though; it's not actually >useful to unload/reload parts of a device's bus attachment without >unloading/reloading all the downstream parts of the driver. > >I think the fix should probably be committed and the driver turned into a >single monolithic module. Yes, Paul essentially agreed to my doing this as an interim measure until ifconfig is "fixed" to use the module file name rather than the module name when loading drivers. I'll commit the change in a few hours after I have tested that it works. Ian To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Fw: Stop annoying message of lnc
> That's Paul Richards, not Bill Paul. My apologies, I should have checked before pressing that 'Send' button :( > I don't quite understand Paul's reasoning, though; it's not actually > useful to unload/reload parts of a device's bus attachment without > unloading/reloading all the downstream parts of the driver. > > I think the fix should probably be committed and the driver turned into a > single monolithic module. > I am not advocating either approach. Just wanted to point out that there is PR available which should be closed if the fix will get committed. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Fw: Stop annoying message of lnc
> See my PR kern/25582. The explanation why Bill Paul does not want to make this > change yet is there :) That's Paul Richards, not Bill Paul. I don't quite understand Paul's reasoning, though; it's not actually useful to unload/reload parts of a device's bus attachment without unloading/reloading all the downstream parts of the driver. I think the fix should probably be committed and the driver turned into a single monolithic module. -- ... every activity meets with opposition, everyone who acts has his rivals and unfortunately opponents also. But not because people want to be opponents, rather because the tasks and relationships force people to take different points of view. [Dr. Fritz Todt] V I C T O R Y N O T V E N G E A N C E To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
RE: Fw: Stop annoying message of lnc
See my PR kern/25582. The explanation why Bill Paul does not want to make this change yet is there :) On 18-Mar-2001 Makoto MATSUSHITA wrote: > > I've sent an email to [EMAIL PROTECTED], a maintainer of lnc ethernet > driver, to fix the module name of lnc almost two weeks before. > > However, he maybe too busy working, there is no response from him. Are > there any committers to check my patch and fix the driver? > > -- - > Makoto MATSUSHITA -- E-Mail: Alexander N. Kabaev <[EMAIL PROTECTED]> Date: 18-Mar-2001 Time: 00:02:17 -- To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Fw: Stop annoying message of lnc
I've sent an email to [EMAIL PROTECTED], a maintainer of lnc ethernet driver, to fix the module name of lnc almost two weeks before. However, he maybe too busy working, there is no response from him. Are there any committers to check my patch and fix the driver? -- - Makoto MATSUSHITA It seems that module name of lnc is not 'if_xxx', which is assumed by ifconfig(8) or friends. Because of this, we've got annoying messages while booting (if kernel has lnc driver already): module_register: module pci/lnc_pci already exists! Module pci/lnc_pci failed to register: 17 module_register: module isa/lnc_isa already exists! Module isa/lnc_isa failed to register: 17 Fixing is too trivial, change the module's name; attached below is a sample patch: --- if_lnc_isa.c.dist Wed Mar 7 13:42:29 2001 +++ if_lnc_isa.cWed Mar 7 13:44:12 2001 @@ -310,4 +310,4 @@ sizeof(struct lnc_softc), }; -DRIVER_MODULE(lnc_isa, isa, lnc_isa_driver, lnc_devclass, 0, 0); +DRIVER_MODULE(if_lnc, isa, lnc_isa_driver, lnc_devclass, 0, 0); --- if_lnc_pci.c.dist Wed Mar 7 13:42:29 2001 +++ if_lnc_pci.cWed Mar 7 13:43:42 2001 @@ -223,4 +223,4 @@ sizeof(struct lnc_softc), }; -DRIVER_MODULE(lnc_pci, pci, lnc_pci_driver, lnc_devclass, 0, 0); +DRIVER_MODULE(if_lnc, pci, lnc_pci_driver, lnc_devclass, 0, 0); Would you please check this patch out and commit ? -- - Makoto `MAR' MATSUSHITA
