Re: Need help reducing compilation warnings in CURRENT

2015-05-30 Thread Garrett Cooper
On May 30, 2015, at 19:15, Craig Rodrigues wrote: > On Thu, May 28, 2015 at 9:49 AM, Konstantin Belousov > wrote: > >> On Wed, May 27, 2015 at 11:30:45PM -0700, Craig Rodrigues wrote: >> >> I take some time to do a pass over mine code or code I am somewhat >> knowledgable, to correct some 'ass

Re: Need help reducing compilation warnings in CURRENT

2015-05-30 Thread Craig Rodrigues
On Thu, May 28, 2015 at 9:49 AM, Konstantin Belousov wrote: > On Wed, May 27, 2015 at 11:30:45PM -0700, Craig Rodrigues wrote: > > I take some time to do a pass over mine code or code I am somewhat > knowledgable, to correct some 'assigned but not used variable' warnings. > There might be even on

Re: Need help reducing compilation warnings in CURRENT

2015-05-28 Thread Craig Rodrigues
On Thu, May 28, 2015 at 5:45 AM, Muhammad Moinur Rahman wrote: > Hi, > > Can anyone give me any ideas about how can I contribute some of my idle > times? Do I need commit bit to submit patches in Jenkins? Or should I > submit through CODE Review? > Please read this: https://wiki.freebsd.org/Cod

Re: Need help reducing compilation warnings in CURRENT

2015-05-28 Thread Dimitry Andric
On 28 May 2015, at 21:09, Craig Rodrigues wrote: > > On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner ... >> The warnings are almost all in contrib/ areas. Hence, any fix might >> want to probably be submitted to upstream first. >> > Sure, if we can push fixes upstream that would be great

Re: Need help reducing compilation warnings in CURRENT

2015-05-28 Thread NGie Cooper
On Thu, May 28, 2015 at 12:18 PM, Baptiste Daroussin wrote: ... > If not upstreamed, there is a good chance it get lost during the next update. > So > in the special case of warning fixes, I would strongly advice to upstream > first!! +200 Plus upstream sources generally get slammed by multiple

Re: Need help reducing compilation warnings in CURRENT

2015-05-28 Thread Baptiste Daroussin
On Thu, May 28, 2015 at 12:09:35PM -0700, Craig Rodrigues wrote: > On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner > wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA256 > > > > Hi Craig, > > > > I'll gladly help (good excuse to learn C), but looking at those errors > > in gene

Re: Need help reducing compilation warnings in CURRENT

2015-05-28 Thread Craig Rodrigues
On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Hi Craig, > > I'll gladly help (good excuse to learn C), but looking at those errors > in general, one thing pops out: > > The warnings are almost all in contrib/ areas. Hence, an

Re: Need help reducing compilation warnings in CURRENT

2015-05-28 Thread Konstantin Belousov
On Wed, May 27, 2015 at 11:30:45PM -0700, Craig Rodrigues wrote: > Hi, > > I've configured Jenkins to highlight compiler warnings and > generate a table. Jenkins also keeps track of new compiler warnings > over time. See: > > https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 > > Can anyon

Re: Need help reducing compilation warnings in CURRENT

2015-05-28 Thread Marcelo Araujo
Hi, You don't need src bit to submit any patch and you can do it via review without any problem. Just try to drive the patch to the right person. Best, 2015-05-28 20:45 GMT+08:00 Muhammad Moinur Rahman : > Hi, > > Can anyone give me any ideas about how can I contribute some of my idle > times?

Re: Need help reducing compilation warnings in CURRENT

2015-05-28 Thread Muhammad Moinur Rahman
Hi, Can anyone give me any ideas about how can I contribute some of my idle times? Do I need commit bit to submit patches in Jenkins? Or should I submit through CODE Review? BR, @bofh On Thu, May 28, 2015 at 6:38 PM, Johannes Jost Meixner wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA

Re: Need help reducing compilation warnings in CURRENT

2015-05-28 Thread Johannes Jost Meixner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Craig, I'll gladly help (good excuse to learn C), but looking at those errors in general, one thing pops out: The warnings are almost all in contrib/ areas. Hence, any fix might want to probably be submitted to upstream first. Correct me if I'm

Re: Need help reducing compilation warnings in CURRENT

2015-05-28 Thread Marcelo Araujo
Hi Craig, I can give a hand with it. Best, 2015-05-28 14:30 GMT+08:00 Craig Rodrigues : > Hi, > > I've configured Jenkins to highlight compiler warnings and > generate a table. Jenkins also keeps track of new compiler warnings > over time. See: > > https://jenkins.freebsd.org/job/FreeBSD_HEA

Need help reducing compilation warnings in CURRENT

2015-05-27 Thread Craig Rodrigues
Hi, I've configured Jenkins to highlight compiler warnings and generate a table. Jenkins also keeps track of new compiler warnings over time. See: https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 Can anyone help improve the code by periodically looking at this table and submitting patche