RE: cvs commit: src/sys/sys mutex.h
On Fri, 21 Sep 2001, John Baldwin wrote: On 21-Sep-01 John Baldwin wrote: jhb 2001/09/21 16:15:10 PDT Modified files: sys/sys mutex.h Log: Use __FILE__ and __LINE__ explicitly since we know we will be using them when calling _mtx_assert() to prevent mtx_assert() from requiring sys/lock.h as well as sys/mutex.h. This fixes the COMPAT_SVR4 breakage. Seems to still be broken... cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -g -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/dev -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 /usr/src/sys/compat/svr4/svr4_resource.c /usr/src/sys/compat/svr4/svr4_resource.c: In function `svr4_sys_getrlimit': /usr/src/sys/compat/svr4/svr4_resource.c:143: `LOCK_FILE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c:143: (Each undeclared identifier is reported only once /usr/src/sys/compat/svr4/svr4_resource.c:143: for each function it appears in.) /usr/src/sys/compat/svr4/svr4_resource.c:143: `LOCK_LINE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c: In function `svr4_sys_setrlimit': /usr/src/sys/compat/svr4/svr4_resource.c:191: `LOCK_FILE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c:191: `LOCK_LINE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c: In function `svr4_sys_getrlimit64': /usr/src/sys/compat/svr4/svr4_resource.c:241: `LOCK_FILE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c:241: `LOCK_LINE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c: In function `svr4_sys_setrlimit64': /usr/src/sys/compat/svr4/svr4_resource.c:289: `LOCK_FILE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c:289: `LOCK_LINE' undeclared (first use in this function) *** Error code 1 Stop in /usr/obj/usr/src/sys/PELE. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. Cheers, Vince - [EMAIL PROTECTED] - Vice President __ Unix Networking Operations - FreeBSD-Real Unix for Free / / / / | / |[__ ] WurldLink Corporation / / / / | / | __] ] San Francisco - Honolulu - Hong Kong / / / / / |/ / | __] ] HongKong Stars/Gravis UltraSound Mailing Lists Admin /_/_/_/_/|___/|_|[] Almighty1@IRC - oahu.DAL.NET Hawaii's DALnet IRC Network Server Admin To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
RE: cvs commit: src/sys/sys mutex.h - it's working!
On Fri, 21 Sep 2001, Vincent Poy wrote: On Fri, 21 Sep 2001, John Baldwin wrote: On 21-Sep-01 John Baldwin wrote: jhb 2001/09/21 16:15:10 PDT Modified files: sys/sys mutex.h Log: Use __FILE__ and __LINE__ explicitly since we know we will be using them when calling _mtx_assert() to prevent mtx_assert() from requiring sys/lock.h as well as sys/mutex.h. This fixes the COMPAT_SVR4 breakage. Seems to still be broken... cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -g -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/dev -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 /usr/src/sys/compat/svr4/svr4_resource.c /usr/src/sys/compat/svr4/svr4_resource.c: In function `svr4_sys_getrlimit': /usr/src/sys/compat/svr4/svr4_resource.c:143: `LOCK_FILE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c:143: (Each undeclared identifier is reported only once /usr/src/sys/compat/svr4/svr4_resource.c:143: for each function it appears in.) /usr/src/sys/compat/svr4/svr4_resource.c:143: `LOCK_LINE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c: In function `svr4_sys_setrlimit': /usr/src/sys/compat/svr4/svr4_resource.c:191: `LOCK_FILE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c:191: `LOCK_LINE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c: In function `svr4_sys_getrlimit64': /usr/src/sys/compat/svr4/svr4_resource.c:241: `LOCK_FILE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c:241: `LOCK_LINE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c: In function `svr4_sys_setrlimit64': /usr/src/sys/compat/svr4/svr4_resource.c:289: `LOCK_FILE' undeclared (first use in this function) /usr/src/sys/compat/svr4/svr4_resource.c:289: `LOCK_LINE' undeclared (first use in this function) *** Error code 1 Stop in /usr/obj/usr/src/sys/PELE. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. It's working. For whatever reason, when I did the cvsup from cvsup10.FreeBSD.ORG an hour after your commit, it shows mutex.h 1.40 so I proceeded with the build afterwards. After I wrote the above, I checked the file and it was still 1.39 so another cvsup put it at 1.40 and it compiles fine now. Thanks for the efforts! Cheers, Vince - [EMAIL PROTECTED] - Vice President __ Unix Networking Operations - FreeBSD-Real Unix for Free / / / / | / |[__ ] WurldLink Corporation / / / / | / | __] ] San Francisco - Honolulu - Hong Kong / / / / / |/ / | __] ] HongKong Stars/Gravis UltraSound Mailing Lists Admin /_/_/_/_/|___/|_|[] Almighty1@IRC - oahu.DAL.NET Hawaii's DALnet IRC Network Server Admin To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
RE: cvs commit: src/sys/sys mutex.h src/sys/kern kern_mutex.c
On 01-Dec-00 John Baldwin wrote: jhb 2000/11/30 16:11:00 PST Modified files: sys/sys mutex.h sys/kern kern_mutex.c Log: Split the WITNESS and MUTEX_DEBUG options apart so that WITNESS does not depend on MUTEX_DEBUG. The MUTEX_DEBUG option turns on extra assertions and checks to verify that mutexes themselves are implemented properly. The WITNESS option uses extra checks and diagnostics to verify that other code is using mutexes properly. Removing MUTEX_DEBUG and only using WITNESS provided a very noticable performance increase on the quad xeon I have here for testing for I/O bound operations. Before, trying to do a cvs update would end up with cvs having 7s of user time nad 9000s of system time, now it is back down to more sane boundaries. -- John Baldwin [EMAIL PROTECTED] -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
