Re: misc/15421 (was: Re: initgroups)

2001-11-20 Thread Ruslan Ermilov
On Mon, Nov 19, 2001 at 10:28:55PM +0600, Max Khon wrote: hi, there! On Mon, Nov 19, 2001 at 06:19:50PM +0200, Ruslan Ermilov wrote: Can setgroups return a positive number? If so, you've just changed the semantics of the funtion; before, it used to return 0 on 0 or a positive

Re: misc/15421 (was: Re: initgroups)

2001-11-20 Thread Anton Berezin
On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote: On Mon, Nov 19, 2001 at 10:28:55PM +0600, Max Khon wrote: I asked tobez (he is an originator and he took responsibility on this PR) and he said that src/ must be audited also -- he said that some initgroups() callers do not

Re: misc/15421 (was: Re: initgroups)

2001-11-20 Thread Ruslan Ermilov
On Tue, Nov 20, 2001 at 03:12:50PM +0100, Anton Berezin wrote: On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote: On Mon, Nov 19, 2001 at 10:28:55PM +0600, Max Khon wrote: I asked tobez (he is an originator and he took responsibility on this PR) and he said that src/ must

Re: misc/15421 (was: Re: initgroups)

2001-11-20 Thread Anton Berezin
On Tue, Nov 20, 2001 at 04:27:03PM +0200, Ruslan Ermilov wrote: On Tue, Nov 20, 2001 at 03:12:50PM +0100, Anton Berezin wrote: On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote: While this is indeed a good thing to do, this is completely unrelated to the above mentioned

Re: misc/15421 (was: Re: initgroups)

2001-11-20 Thread Ruslan Ermilov
On Tue, Nov 20, 2001 at 03:43:52PM +0100, Anton Berezin wrote: On Tue, Nov 20, 2001 at 04:27:03PM +0200, Ruslan Ermilov wrote: On Tue, Nov 20, 2001 at 03:12:50PM +0100, Anton Berezin wrote: On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote: While this is indeed a good

Re: misc/15421 (was: Re: initgroups)

2001-11-19 Thread Ruslan Ermilov
On Tue, Nov 13, 2001 at 02:28:57PM -0800, Terry Lambert wrote: Max Khon wrote: hi, there! Any objections if I will commit the following patch (see PR/15421)? Can setgroups return a positive number? If so, you've just changed the semantics of the funtion; before, it used to return

Re: misc/15421 (was: Re: initgroups)

2001-11-19 Thread Max Khon
hi, there! On Mon, Nov 19, 2001 at 06:19:50PM +0200, Ruslan Ermilov wrote: Can setgroups return a positive number? If so, you've just changed the semantics of the funtion; before, it used to return 0 on 0 or a positive number. No. setgroups() is a syscall, and as such returns either

RE: initgroups

2001-11-13 Thread John Baldwin
On 13-Nov-01 Max Khon wrote: hi, there! Any objections if I will commit the following patch (see PR/15421)? Index: initgroups.c === RCS file: /home/ncvs/src/lib/libc/gen/initgroups.c,v retrieving revision 1.4 diff -u

Re: initgroups

2001-11-13 Thread David Malone
On Wed, Nov 14, 2001 at 02:19:56AM +0600, Max Khon wrote: Any objections if I will commit the following patch (see PR/15421)? Does the man page need a note about setting errno? David. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the

Re: initgroups

2001-11-13 Thread Terry Lambert
Max Khon wrote: hi, there! Any objections if I will commit the following patch (see PR/15421)? Can setgroups return a positive number? If so, you've just changed the semantics of the funtion; before, it used to return 0 on 0 or a positive number. Also, is removing the _warn() really the

Re: initgroups

2001-11-13 Thread Terry Lambert
John Baldwin wrote: + return setgroups(ngroups, groups); } Style nit: return (setgruops(ngroups, groups)); return (setgroups(ngroups, groups)); (avoiding cut-and-paste error). -- Terry To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe

Re: initgroups

2001-11-13 Thread John Baldwin
On 13-Nov-01 Terry Lambert wrote: John Baldwin wrote: + return setgroups(ngroups, groups); } Style nit: return (setgruops(ngroups, groups)); return (setgroups(ngroups, groups)); (avoiding cut-and-paste error). Yes, my mailer eats tabs and sucks as is well

Re: initgroups

2001-11-13 Thread Terry Lambert
John Baldwin wrote: return (setgruops(ngroups, groups)); return (setgroups(ngroups, groups)); (avoiding cut-and-paste error). Yes, my mailer eats tabs and sucks as is well documented, the point was the ()'s. :) I didn't fix the tabs; I fixed the typo; I lined it up

Re: initgroups

2001-11-13 Thread John Baldwin
On 13-Nov-01 Terry Lambert wrote: John Baldwin wrote: return (setgruops(ngroups, groups)); return (setgroups(ngroups, groups)); (avoiding cut-and-paste error). Yes, my mailer eats tabs and sucks as is well documented, the point was the ()'s. :) I didn't fix the