Re: [PATCH] Various fixes to wl(4)

2014-09-22 Thread Adrian Chadd
I have lots of wavelan/prism NICs. The driver just doesn't work with them.


-a
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: [PATCH] Various fixes to wl(4)

2014-09-22 Thread Warner Losh

On Sep 22, 2014, at 4:05 PM, Adrian Chadd  wrote:

> On 22 September 2014 13:46, Warner Losh  wrote:
>> I have a dozen I can bring to the next bafug I go to :)
> 
> But, do you have the pentium class machines with ISA slots that we'd
> need to use em? :P

For wi(4)? You can test that with any laptop with a CardBus slot…  Those I’ve 
got :)
Or a PCI machine with an adapter: Got one left.
Of in an ISA adapter … hmmm, FreeBSD doesn’t support that, but I have a machine 
that can do that…

I just don’t have a network that doesn’t have crypto enabled to try it out, and 
I’m too lazy to set that up.

Warner



signature.asc
Description: Message signed with OpenPGP using GPGMail


Re: [PATCH] Various fixes to wl(4)

2014-09-22 Thread Adrian Chadd
On 22 September 2014 15:28, Alfred Perlstein  wrote:
>
> On 9/22/14 3:05 PM, Adrian Chadd wrote:
>>
>> On 22 September 2014 13:46, Warner Losh  wrote:
>>>
>>> I have a dozen I can bring to the next bafug I go to :)
>>
>> But, do you have the pentium class machines with ISA slots that we'd
>> need to use em? :P
>
>
> I have the pci card to pccard bridge cards.
>
> I'll bring those in, they'll be on your desk tomorrow AM.

I have those. Because, well, Sam gave me his prism collection..


-a
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: [PATCH] Various fixes to wl(4)

2014-09-22 Thread Alfred Perlstein


On 9/22/14 3:05 PM, Adrian Chadd wrote:

On 22 September 2014 13:46, Warner Losh  wrote:

I have a dozen I can bring to the next bafug I go to :)

But, do you have the pentium class machines with ISA slots that we'd
need to use em? :P


I have the pci card to pccard bridge cards.

I'll bring those in, they'll be on your desk tomorrow AM.

-Alfred
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: [PATCH] Various fixes to wl(4)

2014-09-22 Thread Adrian Chadd
On 22 September 2014 13:46, Warner Losh  wrote:
> I have a dozen I can bring to the next bafug I go to :)

But, do you have the pentium class machines with ISA slots that we'd
need to use em? :P


-a
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: [PATCH] Various fixes to wl(4)

2014-09-22 Thread Warner Losh
I have a dozen I can bring to the next bafug I go to :)

Warner


On Sep 22, 2014, at 2:44 PM, Adrian Chadd  wrote:

> Oh yeah, I am.
> 
> but wl likely hasn't been tested in a long time.. I think my last pair
> of wl(4) NICs disappeared in 2001.
> 
> 
> -a
> 
> 
> On 22 September 2014 13:35, John Baldwin  wrote:
>> On Monday, September 22, 2014 12:42:34 PM Adrian Chadd wrote:
>>> On 22 September 2014 12:20, John Baldwin  wrote:
 On Friday, September 19, 2014 03:47:16 PM Warner Losh wrote:
> I got rid of my pre-802.11 WaveLAN cards about 8 years go after not
> having
> them in a system at all for 8 years. And they were about 4 years obsolete
> when I took them out of service… I’m not even sure I have a machine with
> an
> ISA slot to test the card, even if I still had it.
> 
> Sorry I can’t help more :)
 
 If no one tests them then I will happily toss the driver into the dustbin,
 just giving folks a chance to test patches before I do so.  (I'm secretly
 hoping I can purge several old drivers during the current round of
 timeout() purging.)
>>> 
>>> The wavelan/prism driver no longer works out of the box and hasn't
>>> since I took over the net80211 stack.
>>> 
>>> TL;DR - some changes from sam and others a few years ago to do raw
>>> 802.11 frame transmit just doesn't work on all the wavelan cards that
>>> are in use. I've asked for someone interested to go through the
>>> changelog and back out those changes, making the driver again a
>>> straight 802.3 transmit driver - but noone has. :(
>>> 
>>> So yes, you have a +1 to disconnect the wavelan driver from the build.
>> 
>> I think you are referring to wi(4)?
>> 
>> --
>> John Baldwin



signature.asc
Description: Message signed with OpenPGP using GPGMail


Re: [PATCH] Various fixes to wl(4)

2014-09-22 Thread Adrian Chadd
Oh yeah, I am.

but wl likely hasn't been tested in a long time.. I think my last pair
of wl(4) NICs disappeared in 2001.


-a


On 22 September 2014 13:35, John Baldwin  wrote:
> On Monday, September 22, 2014 12:42:34 PM Adrian Chadd wrote:
>> On 22 September 2014 12:20, John Baldwin  wrote:
>> > On Friday, September 19, 2014 03:47:16 PM Warner Losh wrote:
>> >> I got rid of my pre-802.11 WaveLAN cards about 8 years go after not
>> >> having
>> >> them in a system at all for 8 years. And they were about 4 years obsolete
>> >> when I took them out of service… I’m not even sure I have a machine with
>> >> an
>> >> ISA slot to test the card, even if I still had it.
>> >>
>> >> Sorry I can’t help more :)
>> >
>> > If no one tests them then I will happily toss the driver into the dustbin,
>> > just giving folks a chance to test patches before I do so.  (I'm secretly
>> > hoping I can purge several old drivers during the current round of
>> > timeout() purging.)
>>
>> The wavelan/prism driver no longer works out of the box and hasn't
>> since I took over the net80211 stack.
>>
>> TL;DR - some changes from sam and others a few years ago to do raw
>> 802.11 frame transmit just doesn't work on all the wavelan cards that
>> are in use. I've asked for someone interested to go through the
>> changelog and back out those changes, making the driver again a
>> straight 802.3 transmit driver - but noone has. :(
>>
>> So yes, you have a +1 to disconnect the wavelan driver from the build.
>
> I think you are referring to wi(4)?
>
> --
> John Baldwin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: [PATCH] Various fixes to wl(4)

2014-09-22 Thread John Baldwin
On Monday, September 22, 2014 12:42:34 PM Adrian Chadd wrote:
> On 22 September 2014 12:20, John Baldwin  wrote:
> > On Friday, September 19, 2014 03:47:16 PM Warner Losh wrote:
> >> I got rid of my pre-802.11 WaveLAN cards about 8 years go after not
> >> having
> >> them in a system at all for 8 years. And they were about 4 years obsolete
> >> when I took them out of service… I’m not even sure I have a machine with
> >> an
> >> ISA slot to test the card, even if I still had it.
> >> 
> >> Sorry I can’t help more :)
> > 
> > If no one tests them then I will happily toss the driver into the dustbin,
> > just giving folks a chance to test patches before I do so.  (I'm secretly
> > hoping I can purge several old drivers during the current round of
> > timeout() purging.)
> 
> The wavelan/prism driver no longer works out of the box and hasn't
> since I took over the net80211 stack.
> 
> TL;DR - some changes from sam and others a few years ago to do raw
> 802.11 frame transmit just doesn't work on all the wavelan cards that
> are in use. I've asked for someone interested to go through the
> changelog and back out those changes, making the driver again a
> straight 802.3 transmit driver - but noone has. :(
> 
> So yes, you have a +1 to disconnect the wavelan driver from the build.

I think you are referring to wi(4)?

-- 
John Baldwin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: [PATCH] Various fixes to wl(4)

2014-09-22 Thread Adrian Chadd
On 22 September 2014 12:20, John Baldwin  wrote:
> On Friday, September 19, 2014 03:47:16 PM Warner Losh wrote:
>> I got rid of my pre-802.11 WaveLAN cards about 8 years go after not having
>> them in a system at all for 8 years. And they were about 4 years obsolete
>> when I took them out of service… I’m not even sure I have a machine with an
>> ISA slot to test the card, even if I still had it.
>>
>> Sorry I can’t help more :)
>
> If no one tests them then I will happily toss the driver into the dustbin,
> just giving folks a chance to test patches before I do so.  (I'm secretly
> hoping I can purge several old drivers during the current round of timeout()
> purging.)
>

The wavelan/prism driver no longer works out of the box and hasn't
since I took over the net80211 stack.

TL;DR - some changes from sam and others a few years ago to do raw
802.11 frame transmit just doesn't work on all the wavelan cards that
are in use. I've asked for someone interested to go through the
changelog and back out those changes, making the driver again a
straight 802.3 transmit driver - but noone has. :(

So yes, you have a +1 to disconnect the wavelan driver from the build.



-a
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: [PATCH] Various fixes to wl(4)

2014-09-22 Thread John Baldwin
On Friday, September 19, 2014 03:47:16 PM Warner Losh wrote:
> I got rid of my pre-802.11 WaveLAN cards about 8 years go after not having
> them in a system at all for 8 years. And they were about 4 years obsolete
> when I took them out of service… I’m not even sure I have a machine with an
> ISA slot to test the card, even if I still had it.
> 
> Sorry I can’t help more :)

If no one tests them then I will happily toss the driver into the dustbin, 
just giving folks a chance to test patches before I do so.  (I'm secretly 
hoping I can purge several old drivers during the current round of timeout() 
purging.)

> Warner
> 
> On Sep 19, 2014, at 2:07 PM, John Baldwin  wrote:
> > This patch fixes various issues in wl(4) including:
> > 
> > - Use bus_space instead of inb/outb.
> > - Use device_printf() and if_printf()
> > - Use callout(9) instead of timeout(9)
> > - Don't hold the driver lock across sleeping actions like
> > 
> >   bus_teardown_intr(), subyte(), etc.
> > 
> > - Don't recurse on the driver lock.
> > 
> > The patch is against HEAD but probably applies to 9 and 10 as well.
> > 
> > http://people.freebsd.org/~jhb/patches/wl_cleanup.patch

-- 
John Baldwin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: [PATCH] Various fixes to wl(4)

2014-09-19 Thread Warner Losh
I got rid of my pre-802.11 WaveLAN cards about 8 years go after not having them 
in a system at all for 8 years. And they were about 4 years obsolete when I 
took them out of service… I’m not even sure I have a machine with an ISA slot 
to test the card, even if I still had it.

Sorry I can’t help more :)

Warner

On Sep 19, 2014, at 2:07 PM, John Baldwin  wrote:

> This patch fixes various issues in wl(4) including:
> 
> - Use bus_space instead of inb/outb.
> - Use device_printf() and if_printf()
> - Use callout(9) instead of timeout(9)
> - Don't hold the driver lock across sleeping actions like
>   bus_teardown_intr(), subyte(), etc.
> - Don't recurse on the driver lock.
> 
> The patch is against HEAD but probably applies to 9 and 10 as well.
> 
> http://people.freebsd.org/~jhb/patches/wl_cleanup.patch
> 
> -- 
> John Baldwin



signature.asc
Description: Message signed with OpenPGP using GPGMail