Re: INTR_MPSAFE to network device drivers

2002-12-17 Thread Andrew Gallatin
Kyunghwan Kim writes: > On Wed, Dec 18, 2002 at 04:53:00AM +0900, Kyunghwan Kim wrote: > > On Tue, Dec 17, 2002 at 02:31:31PM -0500, Andrew Gallatin wrote: > > > > mbuf and bpf routines are all mp-safe, so it seems that > > > > it is safe to make network device drivers out of Giant lock. >

Re: INTR_MPSAFE to network device drivers

2002-12-17 Thread Kyunghwan Kim
On Wed, Dec 18, 2002 at 04:53:00AM +0900, Kyunghwan Kim wrote: > On Tue, Dec 17, 2002 at 02:31:31PM -0500, Andrew Gallatin wrote: > > > mbuf and bpf routines are all mp-safe, so it seems that > > > it is safe to make network device drivers out of Giant lock. > > > Or is there any unresolved rela

Re: INTR_MPSAFE to network device drivers

2002-12-17 Thread Kyunghwan Kim
On Tue, Dec 17, 2002 at 02:31:31PM -0500, Andrew Gallatin wrote: > > mbuf and bpf routines are all mp-safe, so it seems that > > it is safe to make network device drivers out of Giant lock. > > Or is there any unresolved related issues? > > Yes, the mbuf allocator must occasionally call kmem_ma

Re: INTR_MPSAFE to network device drivers

2002-12-17 Thread Andrew Gallatin
Kyunghwan Kim writes: > Is it okay to add INTR_MPSAFE for all INTR_TYPE_NET drivers? NO! > mbuf and bpf routines are all mp-safe, so it seems that > it is safe to make network device drivers out of Giant lock. > Or is there any unresolved related issues? Yes, the mbuf allocator must occasio