Re: Patch for critical_enter()/critical_exit() & interrupt assemblyrevamp, please review!

2002-02-26 Thread Terry Lambert
Matthew Dillon wrote: > As it is, I have invested a great > deal of time and effort on this patch and it is damn well going to go > in so I can move on. Too bad you don't have your own P4 branch... then this would not hold you up. (ducks) ;^) -- Terry To Unsubscribe: send mail to

Re: Patch for critical_enter()/critical_exit() & interrupt assemblyrevamp, please review!

2002-02-25 Thread Matthew Dillon
It kinda sounds like the interrupt/trap code that calls into kern/subr_trap.c should be responsible for placing us in a critical section. kern/subr_trap.c has no business making assumptions in regards to cpu_critical_enter()/cpu_critical_exit() (for the same reason that fork_

Re: Patch for critical_enter()/critical_exit() & interrupt assemblyrevamp, please review!

2002-02-25 Thread Matthew Dillon
: :On Mon, 25 Feb 2002, Matthew Dillon wrote: : :> Unless an unforseen problem arises, I am going to commit this tomorrow :> and then start working on a cleanup patch. I have decided to : :Please wait for jhb's opinion on it. He seems to be offline again. :I think he has plans and mayb

Re: Patch for critical_enter()/critical_exit() & interrupt assemblyrevamp, please review!

2002-02-25 Thread Bruce Evans
On Mon, 25 Feb 2002, Matthew Dillon wrote: > Unless an unforseen problem arises, I am going to commit this tomorrow > and then start working on a cleanup patch. I have decided to Please wait for jhb's opinion on it. He seems to be offline again. I think he has plans and maybe even cod

Re: Patch for critical_enter()/critical_exit() & interrupt assemblyrevamp, please review!

2002-02-25 Thread Matthew Dillon
Unless an unforseen problem arises, I am going to commit this tomorrow and then start working on a cleanup patch. I have decided to keep the sysctl instrumentation intact for the moment so people who experience panics or lockups can turn it off to see whether that was the cau

Re: Patch for critical_enter()/critical_exit() & interrupt assemblyrevamp, please review!

2002-02-25 Thread Doug Rabson
On Sun, 24 Feb 2002, Andrew Gallatin wrote: > > I'm not fluent in x86 asm, so can you confirm for me what you're > attempting to do here? > > I think you're making critical_enter()/critical_exit() cheaper by not > actually messing with the interrupt hardware when they're called. > Very much like

Re: Patch for critical_enter()/critical_exit() & interrupt assemblyrevamp, please review!

2002-02-25 Thread Bruce Evans
On Sun, 24 Feb 2002, Matthew Dillon wrote: > ... > :If so, I'm wondering if this is even possible on alpha, where we don't > :have direct access to the hardware. However, according to the psuedo > :code for rti in the Brown book, munging with the saved PSL in > :trapframe to set the IPL should

Re: Patch for critical_enter()/critical_exit() & interrupt assemblyrevamp, please review!

2002-02-24 Thread Bruce Evans
On Sun, 24 Feb 2002, Matthew Dillon wrote: > :On Sun, 24 Feb 2002, Matthew Dillon wrote: > :> * Additional cpu_critical_enter/exit() calls around icu_lock. Since > :> critical_enter() no longer disables interrupts, special care must > :> be taken when dealing with the icu_lock sp

Re: Patch for critical_enter()/critical_exit() & interrupt assemblyrevamp, please review!

2002-02-24 Thread Matthew Dillon
: :On Sun, 24 Feb 2002, Matthew Dillon wrote: : :> * debug.critical_mode sysctl. This will not be in the final commit, :> nor will any of the code that tests the variable. The final commit :> will use code as if the critical_mode were '1'. : :Won't it be needed for longer for no

Re: Patch for critical_enter()/critical_exit() & interrupt assemblyrevamp, please review!

2002-02-24 Thread Bruce Evans
On Sun, 24 Feb 2002, Matthew Dillon wrote: > NOTES: > > I would like to thank Bruce for supplying the sample code that allowed > me to do this in a day instead of several days. Thanks. > * debug.critical_mode sysctl. This will not be in the final commit, > nor will any of the