On Tue, Nov 20, 2001 at 03:43:52PM +0100, Anton Berezin wrote:
> On Tue, Nov 20, 2001 at 04:27:03PM +0200, Ruslan Ermilov wrote:
> > On Tue, Nov 20, 2001 at 03:12:50PM +0100, Anton Berezin wrote:
> > > On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote:
>
> > > > While this is indeed
On Tue, Nov 20, 2001 at 04:27:03PM +0200, Ruslan Ermilov wrote:
> On Tue, Nov 20, 2001 at 03:12:50PM +0100, Anton Berezin wrote:
> > On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote:
> > > While this is indeed a good thing to do, this is completely
> > > unrelated to the above menti
On Tue, Nov 20, 2001 at 03:12:50PM +0100, Anton Berezin wrote:
> On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote:
> > On Mon, Nov 19, 2001 at 10:28:55PM +0600, Max Khon wrote:
>
> > > I asked tobez (he is an originator and he took responsibility on
> > > this PR) and he said that s
On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote:
> On Mon, Nov 19, 2001 at 10:28:55PM +0600, Max Khon wrote:
> > I asked tobez (he is an originator and he took responsibility on
> > this PR) and he said that src/ must be audited also -- he said that
> > some initgroups() callers do
On Mon, Nov 19, 2001 at 10:28:55PM +0600, Max Khon wrote:
> hi, there!
>
> On Mon, Nov 19, 2001 at 06:19:50PM +0200, Ruslan Ermilov wrote:
>
> > > Can setgroups return a positive number? If so, you've just changed
> > > the semantics of the funtion; before, it used to return 0 on 0 or a
> > > p
hi, there!
On Mon, Nov 19, 2001 at 06:19:50PM +0200, Ruslan Ermilov wrote:
> > Can setgroups return a positive number? If so, you've just changed
> > the semantics of the funtion; before, it used to return 0 on 0 or a
> > positive number.
> >
> No. setgroups() is a syscall, and as such return
On Tue, Nov 13, 2001 at 02:28:57PM -0800, Terry Lambert wrote:
> Max Khon wrote:
> >
> > hi, there!
> >
> > Any objections if I will commit the following patch (see PR/15421)?
>
> Can setgroups return a positive number? If so, you've just changed
> the semantics of the funtion; before, it used
On 13-Nov-01 Terry Lambert wrote:
> John Baldwin wrote:
>> >> return (setgruops(ngroups, groups));
>> > return (setgroups(ngroups, groups));
>> >
>> > (avoiding cut-and-paste error).
>>
>> Yes, my mailer eats tabs and sucks as is well documented, the point was the
>> ()'s. :)
>
John Baldwin wrote:
> >> return (setgruops(ngroups, groups));
> > return (setgroups(ngroups, groups));
> >
> > (avoiding cut-and-paste error).
>
> Yes, my mailer eats tabs and sucks as is well documented, the point was the
> ()'s. :)
I didn't fix the tabs; I fixed the typo; I li
On 13-Nov-01 Terry Lambert wrote:
> John Baldwin wrote:
>> > + return setgroups(ngroups, groups);
>> > }
>>
>> Style nit:
>>
>> return (setgruops(ngroups, groups));
>
>
> return (setgroups(ngroups, groups));
>
> (avoiding cut-and-paste error).
Yes, my mailer eats tabs a
John Baldwin wrote:
> > + return setgroups(ngroups, groups);
> > }
>
> Style nit:
>
> return (setgruops(ngroups, groups));
return (setgroups(ngroups, groups));
(avoiding cut-and-paste error).
-- Terry
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe free
Max Khon wrote:
>
> hi, there!
>
> Any objections if I will commit the following patch (see PR/15421)?
Can setgroups return a positive number? If so, you've just changed
the semantics of the funtion; before, it used to return 0 on 0 or a
positive number.
Also, is removing the _warn() really t
On Wed, Nov 14, 2001 at 02:19:56AM +0600, Max Khon wrote:
> Any objections if I will commit the following patch (see PR/15421)?
Does the man page need a note about setting errno?
David.
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the
On 13-Nov-01 Max Khon wrote:
> hi, there!
>
> Any objections if I will commit the following patch (see PR/15421)?
>
> Index: initgroups.c
> ===
> RCS file: /home/ncvs/src/lib/libc/gen/initgroups.c,v
> retrieving revision 1.4
> diff
14 matches
Mail list logo
