Re: patches for [x]install
On Fri, Jun 07, 2002 at 10:08:25PM -0700, J. Mallett wrote: > * From "Steven G. Kargl" <[EMAIL PROTECTED]> > > J. Mallett said: > > > * From "Steven G. Kargl" <[EMAIL PROTECTED]> > > > > J. Mallett said: > > > > > > > > No. The third patch is correct (see below); otherwise I could set > > > > INSTALL to " install -C" QED. > > > > > > And I could set BINOWN to something bogus. > > > > > > Don't protect the user by removing functionality. > > > > Well, if the first patch is acceptable, then we would > > be restoring documented functionality; otherwise, > > rev 1.55 of xinstall.c will remove functionality. > > Add the word "meaningful" before "functionality" in my statement, and realise > that overriding such things should ALWAYS be something you can do. Consider > cross-builds, and so on. > -- I don't really care which patches are applied. One patch fixes install(1) and the other set of patches augments the current breakage in install(1). Either set of patches is acceptable to me, while the current state of affairs is unacceptable in general. -- Steve To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: patches for [x]install
* From "Steven G. Kargl" <[EMAIL PROTECTED]> > J. Mallett said: > > * From "Steven G. Kargl" <[EMAIL PROTECTED]> > > > J. Mallett said: > > > > > > No. The third patch is correct (see below); otherwise I could set > > > INSTALL to " install -C" QED. > > > > And I could set BINOWN to something bogus. > > > > Don't protect the user by removing functionality. > > Well, if the first patch is acceptable, then we would > be restoring documented functionality; otherwise, > rev 1.55 of xinstall.c will remove functionality. Add the word "meaningful" before "functionality" in my statement, and realise that overriding such things should ALWAYS be something you can do. Consider cross-builds, and so on. -- J. Mallett <[EMAIL PROTECTED]>FreeBSD: The Power To Serve "I've coined new words, like, misunderstanding and Hispanically." -- George W. Bush, Radio-Television Correspondents Association dinner, Washington, D.C., March 29, 2001 To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: patches for [x]install
J. Mallett said: > * From "Steven G. Kargl" <[EMAIL PROTECTED]> > > J. Mallett said: > > > > No. The third patch is correct (see below); otherwise I could set > > INSTALL to " install -C" QED. > > And I could set BINOWN to something bogus. > > Don't protect the user by removing functionality. Well, if the first patch is acceptable, then we would be restoring documented functionality; otherwise, rev 1.55 of xinstall.c will remove functionality. -- Steve http://troutmask.apl.washington.edu/~kargl/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: patches for [x]install
* From "Steven G. Kargl" <[EMAIL PROTECTED]> > J. Mallett said: > > * From "Steven G. Kargl" <[EMAIL PROTECTED]> > > > The first patch fixes install(1). The reamining patches > > > correctly document the breakage of rev 1.55 of xinstall.c > > I should have stated that if the first patch isn't > acceptable, then the remaining patches should be > applied. > > > > > The last patch is wrong, the others are good, though a warning about the > > overriding of flags might be nice until this is ACCEPTED behaviour by the > > user community. > > > > The third patch is wrong because there are things other than -C that one > > might want to override INSTALL with, for example an INSTALL that uses a > > replacement program that static relinks an executable being installed > > to a partition where its dynamic dependencies are not satisfied. > > No. The third patch is correct (see below); otherwise I could set > INSTALL to " install -C" QED. And I could set BINOWN to something bogus. Don't protect the user by removing functionality. -- J. Mallett <[EMAIL PROTECTED]>FreeBSD: The Power To Serve "I've coined new words, like, misunderstanding and Hispanically." -- George W. Bush, Radio-Television Correspondents Association dinner, Washington, D.C., March 29, 2001 To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: patches for [x]install
J. Mallett said: > * From "Steven G. Kargl" <[EMAIL PROTECTED]> > > The first patch fixes install(1). The reamining patches > > correctly document the breakage of rev 1.55 of xinstall.c I should have stated that if the first patch isn't acceptable, then the remaining patches should be applied. > > The last patch is wrong, the others are good, though a warning about the > overriding of flags might be nice until this is ACCEPTED behaviour by the > user community. > > The third patch is wrong because there are things other than -C that one > might want to override INSTALL with, for example an INSTALL that uses a > replacement program that static relinks an executable being installed > to a partition where its dynamic dependencies are not satisfied. No. The third patch is correct (see below); otherwise I could set INSTALL to " install -C" QED. > > I've known people to do similar. > > > --- share/mk/sys.mk.origFri Jun 7 18:05:26 2002 > > +++ share/mk/sys.mk Fri Jun 7 18:06:13 2002 > > @@ -67,7 +67,7 @@ > > .endif > > EFLAGS ?= > > > > -INSTALL?= install > > +INSTALL= install > > > > LEX?= lex > > LFLAGS ?= > > -- Steve http://troutmask.apl.washington.edu/~kargl/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: patches for [x]install
* From "Steven G. Kargl" <[EMAIL PROTECTED]>
> The first patch fixes install(1). The reamining patches
> correctly document the breakage of rev 1.55 of xinstall.c
The last patch is wrong, the others are good, though a warning about the
overriding of flags might be nice until this is ACCEPTED behaviour by the
user community.
The third patch is wrong because there are things other than -C that one
might want to override INSTALL with, for example an INSTALL that uses a
replacement program that static relinks an executable being installed
to a partition where its dynamic dependencies are not satisfied.
I've known people to do similar.
> --- usr.bin/xinstall/xinstall.c.orig Thu Jun 6 22:45:29 2002
> +++ usr.bin/xinstall/xinstall.c Fri Jun 7 17:55:44 2002
> @@ -173,8 +173,11 @@
> argv += optind;
>
> /* some options make no sense when creating directories */
> - if ((safecopy || docompare || dostrip) && dodir)
> - usage();
> + if (dodir) {
> + safecopy = 0;
> + docompare = 0;
> + dostrip = 0;
> + }
>
> /* must have at least two arguments, except when creating directories */
> if (argc < 2 && !dodir)
>
>
>
> --- share/examples/etc/make.conf.orig Fri Jun 7 18:01:36 2002
> +++ share/examples/etc/make.conf Fri Jun 7 18:01:58 2002
> @@ -73,9 +73,6 @@
> # be the highest optimization value used.
> #WANT_FORCE_OPTIMIZATION_DOWNGRADE=1
> #
> -# Compare before install
> -#INSTALL=install -C
> -#
> # Mtree will follow symlinks
> #MTREE_FOLLOWS_SYMLINKS= -L
> #
> --- share/man/man5/make.conf.5.orig Fri Jun 7 18:02:30 2002
> +++ share/man/man5/make.conf.5Fri Jun 7 18:03:46 2002
> @@ -130,14 +130,6 @@
> .Dq Li +=
> instead of
> .Dq Li = .
> -.It Va INSTALL
> -.Pq Vt str
> -the default install command.
> -To have commands compared before doing
> -the install, use
> -.Bd -literal -offset indent
> -INSTALL="install -C"
> -.Ed
> .It Va LOCAL_DIRS
> .Pq Vt str
> List any directories that should be entered when doing
> --- share/mk/sys.mk.orig Fri Jun 7 18:05:26 2002
> +++ share/mk/sys.mk Fri Jun 7 18:06:13 2002
> @@ -67,7 +67,7 @@
> .endif
> EFLAGS ?=
>
> -INSTALL ?= install
> +INSTALL = install
>
> LEX ?= lex
> LFLAGS ?=
>
> To Unsubscribe: send mail to [EMAIL PROTECTED]
> with "unsubscribe freebsd-current" in the body of the message
--
J. Mallett <[EMAIL PROTECTED]>FreeBSD: The Power To Serve
"I've coined new words, like, misunderstanding and Hispanically."
-- George W. Bush, Radio-Television Correspondents Association
dinner, Washington, D.C., March 29, 2001
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
patches for [x]install
The first patch fixes install(1). The reamining patches
correctly document the breakage of rev 1.55 of xinstall.c
--
Steve
http://troutmask.apl.washington.edu/~kargl/
--- usr.bin/xinstall/xinstall.c.origThu Jun 6 22:45:29 2002
+++ usr.bin/xinstall/xinstall.c Fri Jun 7 17:55:44 2002
@@ -173,8 +173,11 @@
argv += optind;
/* some options make no sense when creating directories */
- if ((safecopy || docompare || dostrip) && dodir)
- usage();
+ if (dodir) {
+ safecopy = 0;
+ docompare = 0;
+ dostrip = 0;
+ }
/* must have at least two arguments, except when creating directories */
if (argc < 2 && !dodir)
--- share/examples/etc/make.conf.orig Fri Jun 7 18:01:36 2002
+++ share/examples/etc/make.confFri Jun 7 18:01:58 2002
@@ -73,9 +73,6 @@
# be the highest optimization value used.
#WANT_FORCE_OPTIMIZATION_DOWNGRADE=1
#
-# Compare before install
-#INSTALL=install -C
-#
# Mtree will follow symlinks
#MTREE_FOLLOWS_SYMLINKS= -L
#
--- share/man/man5/make.conf.5.orig Fri Jun 7 18:02:30 2002
+++ share/man/man5/make.conf.5 Fri Jun 7 18:03:46 2002
@@ -130,14 +130,6 @@
.Dq Li +=
instead of
.Dq Li = .
-.It Va INSTALL
-.Pq Vt str
-the default install command.
-To have commands compared before doing
-the install, use
-.Bd -literal -offset indent
-INSTALL="install -C"
-.Ed
.It Va LOCAL_DIRS
.Pq Vt str
List any directories that should be entered when doing
--- share/mk/sys.mk.origFri Jun 7 18:05:26 2002
+++ share/mk/sys.mk Fri Jun 7 18:06:13 2002
@@ -67,7 +67,7 @@
.endif
EFLAGS ?=
-INSTALL?= install
+INSTALL= install
LEX?= lex
LFLAGS ?=
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
