[Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361 Guido Falsi changed: What|Removed |Added Status|In Progress |Closed Resolution|--- |FIXED --- Comment #11 from Guido Falsi --- Patch to sqlite3 committed and merged. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-gecko@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-gecko To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
[Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361 --- Comment #10 from Pavel Volkov --- Hello. I approve of the patch. Thank you all. PR can be closed. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-gecko@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-gecko To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
[Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361
--- Comment #9 from commit-h...@freebsd.org ---
A commit references this bug:
Author: madpilot
Date: Thu Aug 10 08:12:47 UTC 2017
New revision: 447666
URL: https://svnweb.freebsd.org/changeset/ports/447666
Log:
MFH: r447626
Add explicit SQLITE_ENABLE_FTS3. This fixes the firefox and thunderburd
ports build.
Due to recent changes in sqlite3 even if this flag is actually
implicitly added to the build when the FTS4 option is enabled, it
is not reported as present via the
sqlite3_compileoption_used("SQLITE_ENABLE_FTS3") API call, which
is used by the gecko ports configure script to check for a suitable
sqlite3 library.
Related upstream change: https://sqlite.org/src/info/9a443397a6b110f6
PR: 221361, 219963
Submitted by: Vladimir Krstulja ,
jbeich@
Approved by: portmgr@ (blanket)
Approved by: portmgr (antoine)
Changes:
_U branches/2017Q3/
branches/2017Q3/databases/sqlite3/Makefile
--
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-gecko@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gecko
To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
[Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361 Jan Beich changed: What|Removed |Added Flags|maintainer-feedback?(gecko@ |maintainer-feedback+ |FreeBSD.org)| --- Comment #8 from Jan Beich --- (In reply to Guido Falsi from comment #7) > We should also align the version of the tcl-sqlite3 port. Should I file a > separate PR for that so the maintainer has a chance to approve? A separate bug is better since it'd be unrelated to gecko@ bustage. There weren't many commits touching TCL interface. https://sqlite.org/src/finfo?name=src/tclsqlite.c&ci=version-3.20.0&n=3 -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-gecko@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-gecko To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
[Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361 Guido Falsi changed: What|Removed |Added Status|Open|In Progress --- Comment #7 from Guido Falsi --- (In reply to Jan Beich from comment #5) > Some discussion happened in bug 219963 comment 13 and later. I took the freedom of committing my quick fix leveraging the fixit blanket, since breaking firefox and thunderbird can have a big fallout. We should also align the version of the tcl-sqlite3 port. Should I file a separate PR for that so the maintainer has a chance to approve? -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-gecko@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-gecko To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
[Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361
--- Comment #6 from commit-h...@freebsd.org ---
A commit references this bug:
Author: madpilot
Date: Wed Aug 9 14:04:03 UTC 2017
New revision: 447626
URL: https://svnweb.freebsd.org/changeset/ports/447626
Log:
Add explicit SQLITE_ENABLE_FTS3. This fixes the firefox and thunderburd
ports build.
Due to recent changes in sqlite3 even if this flag is actually
implicitly added to the build when the FTS4 option is enabled, it
is not reported as present via the
sqlite3_compileoption_used("SQLITE_ENABLE_FTS3") API call, which
is used by the gecko ports configure script to check for a suitable
sqlite3 library.
Related upstream change: https://sqlite.org/src/info/9a443397a6b110f6
PR: 221361, 219963
Submitted by: Vladimir Krstulja ,
jbeich@
Approved by: portmgr@ (blanket)
MFH: 2017Q3
Changes:
head/databases/sqlite3/Makefile
--
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-gecko@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gecko
To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
[Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361 --- Comment #5 from Jan Beich --- Some discussion happened in bug 219963 comment 13 and later. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-gecko@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-gecko To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
[Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361 Vladimir Krstulja changed: What|Removed |Added Severity|Affects Only Me |Affects Some People Keywords||patch --- Comment #4 from Vladimir Krstulja --- I confirm that adding -DSQLITE_ENABLE_FTS3 under FTS4 option's cpp flags of sqlite3, enables Firefox to build now. I was looking at the sqlite3 source to try and find what happened, but couldn't really find what broke. FTS3 should've been set with -DSQLITE_ENABLE_FTS4, source: > /* > ** FTS4 is really an extension for FTS3. It is enabled using the > ** SQLITE_ENABLE_FTS3 macro. But to avoid confusion we also all > ** the SQLITE_ENABLE_FTS4 macro to serve as an alisse for SQLITE_ENABLE_FTS3. > */ > #if defined(SQLITE_ENABLE_FTS4) && !defined(SQLITE_ENABLE_FTS3) > # define SQLITE_ENABLE_FTS3 > #endif * https://www.sqlite.org/src/artifact/eb2502000148e809 -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-gecko@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-gecko To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
[Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361 Guido Falsi changed: What|Removed |Added CC||madpi...@freebsd.org Attachment #185192||maintainer-approval?(paveli Flags||vol...@gmail.com) --- Comment #3 from Guido Falsi --- Created attachment 185192 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=185192&action=edit Proposed fix I have encountered the same problem and added the attached fix, which makes everything work for me. Looks like something changed in how sqlite3 processes it's compile time arguments. Or firefox changed how it checks them. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-gecko@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-gecko To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
[Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361 --- Comment #2 from Vladimir Krstulja --- Created attachment 185191 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=185191&action=edit sqlite3-3.20.0.log Add sqlite3 build log too. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-gecko@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-gecko To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
[Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361 Vladimir Krstulja changed: What|Removed |Added Status|New |Open CC||pavelivol...@gmail.com --- Comment #1 from Vladimir Krstulja --- CC sqlite3 maintainer. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-gecko@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-gecko To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
maintainer-feedback requested: [Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
Vladimir Krstulja has reassigned Bugzilla Automation 's request for maintainer-feedback to ge...@freebsd.org: Bug 221361: www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361 --- Description --- Created attachment 185190 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=185190&action=edit Firefox-55.0,1 build log I'm unable to build Firefox-55.0,1 with Poudriere (11.1, amd64) because it complains that: DEBUG: configure: error: System SQLite library is not compiled with SQLITE_ENABLE_FTS3. But, I have sqlite3-3.20.0 with FTS3_TOKEN and FTS4 options enabled. Help text for FTS4 suggests it enables FTS3/4 module. I've also tried deleting the sqlite3 package from Poudriere's repo directory, and rebuilt everything, which recompiled all ports that depend on sqlite3, but Firefox is still failing with the same error. Attached is the full Firefox build log. Firefox-55.0,1 built fine the other day, but I guess it was with sqlite3-3.19.3,1, as 3.20.0 was bumped to yesterday (2017-08-08). Looking at the commit, only the version was bumped, no other changes were done. ___ freebsd-gecko@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-gecko To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
[Bug 221361] www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221361 Bug ID: 221361 Summary: www/firefox: Unable to build 55.0,1 due to system SQLite not compiled with SQLITE_ENABLE_FTS3 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: regression Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ge...@freebsd.org Reporter: vlad-f...@acheronmedia.com Assignee: ge...@freebsd.org Flags: maintainer-feedback?(ge...@freebsd.org) Created attachment 185190 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=185190&action=edit Firefox-55.0,1 build log I'm unable to build Firefox-55.0,1 with Poudriere (11.1, amd64) because it complains that: DEBUG: configure: error: System SQLite library is not compiled with SQLITE_ENABLE_FTS3. But, I have sqlite3-3.20.0 with FTS3_TOKEN and FTS4 options enabled. Help text for FTS4 suggests it enables FTS3/4 module. I've also tried deleting the sqlite3 package from Poudriere's repo directory, and rebuilt everything, which recompiled all ports that depend on sqlite3, but Firefox is still failing with the same error. Attached is the full Firefox build log. Firefox-55.0,1 built fine the other day, but I guess it was with sqlite3-3.19.3,1, as 3.20.0 was bumped to yesterday (2017-08-08). Looking at the commit, only the version was bumped, no other changes were done. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-gecko@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-gecko To unsubscribe, send any mail to "freebsd-gecko-unsubscr...@freebsd.org"
