Re: [patch] reducing arp locking

2012-11-09 Thread Fabien Thomas
Le 8 nov. 2012 à 11:25, Alexander V. Chernikov a écrit : On 08.11.2012 14:24, Andre Oppermann wrote: On 08.11.2012 00:24, Alexander V. Chernikov wrote: Hello list! Currently we need to acquire 2 read locks to perform simple 6-byte copying from arp record to packet ethernet header. It

Re: [patch] reducing arp locking

2012-11-09 Thread Alexander V. Chernikov
On 09.11.2012 12:51, Fabien Thomas wrote: Le 8 nov. 2012 à 11:25, Alexander V. Chernikov a écrit : On 08.11.2012 14:24, Andre Oppermann wrote: On 08.11.2012 00:24, Alexander V. Chernikov wrote: Hello list! Currently we need to acquire 2 read locks to perform simple 6-byte copying from arp

Re: [patch] reducing arp locking

2012-11-09 Thread Fabien Thomas
Le 9 nov. 2012 à 10:05, Alexander V. Chernikov a écrit : On 09.11.2012 12:51, Fabien Thomas wrote: Le 8 nov. 2012 à 11:25, Alexander V. Chernikov a écrit : On 08.11.2012 14:24, Andre Oppermann wrote: On 08.11.2012 00:24, Alexander V. Chernikov wrote: Hello list! Currently we need to

Re: [patch] reducing arp locking

2012-11-09 Thread Alexander V. Chernikov
On 09.11.2012 13:59, Fabien Thomas wrote: Le 9 nov. 2012 à 10:05, Alexander V. Chernikov a écrit : On 09.11.2012 12:51, Fabien Thomas wrote: Le 8 nov. 2012 à 11:25, Alexander V. Chernikov a écrit : On 08.11.2012 14:24, Andre Oppermann wrote: On 08.11.2012 00:24, Alexander V. Chernikov

Re: [patch] reducing arp locking

2012-11-09 Thread Fabien Thomas
Le 9 nov. 2012 à 12:18, Alexander V. Chernikov a écrit : On 09.11.2012 13:59, Fabien Thomas wrote: Le 9 nov. 2012 à 10:05, Alexander V. Chernikov a écrit : On 09.11.2012 12:51, Fabien Thomas wrote: Le 8 nov. 2012 à 11:25, Alexander V. Chernikov a écrit : On 08.11.2012 14:24, Andre

Re: [patch] reducing arp locking

2012-11-08 Thread Alexander V. Chernikov
On 08.11.2012 14:24, Andre Oppermann wrote: On 08.11.2012 00:24, Alexander V. Chernikov wrote: Hello list! Currently we need to acquire 2 read locks to perform simple 6-byte copying from arp record to packet ethernet header. It seems that acquiring lle lock for fast path (main traffic flow)

Re: [patch] reducing arp locking

2012-11-08 Thread Andre Oppermann
On 08.11.2012 11:25, Alexander V. Chernikov wrote: On 08.11.2012 14:24, Andre Oppermann wrote: On 08.11.2012 00:24, Alexander V. Chernikov wrote: Hello list! Currently we need to acquire 2 read locks to perform simple 6-byte copying from arp record to packet ethernet header. It seems that

Re: [patch] reducing arp locking

2012-11-08 Thread Andre Oppermann
On 08.11.2012 00:24, Alexander V. Chernikov wrote: Hello list! Currently we need to acquire 2 read locks to perform simple 6-byte copying from arp record to packet ethernet header. It seems that acquiring lle lock for fast path (main traffic flow) is not necessary even with current code. My

Re: [patch] reducing arp locking

2012-11-08 Thread Alexander V. Chernikov
On 08.11.2012 03:46, Adrian Chadd wrote: On 7 November 2012 15:24, Alexander V. Chernikovmelif...@freebsd.org wrote: Hello list! Currently we need to acquire 2 read locks to perform simple 6-byte copying from arp record to packet ethernet header. It seems that acquiring lle lock for fast

Re: [patch] reducing arp locking

2012-11-08 Thread Adrian Chadd
On 8 November 2012 13:48, Alexander V. Chernikov melif...@freebsd.org wrote: That's a great catch! How'd you discover it? We have lots of FreeBSD routers doing 10G firewalling, so we're very much concerned with forwarding/firewalling performance, constantly looking for something to optimize

Re: [patch] reducing arp locking

2012-11-08 Thread Ingo Flaschberger
Dear Alexander, If nobody objects I plan to commit this change at the end of next week. LLE_RNLOCK(la); should be LLE_RLOCK(la); in arpresolve Kind regards, Ingo Flaschberger ___ freebsd-hackers@freebsd.org mailing list

[patch] reducing arp locking

2012-11-07 Thread Alexander V. Chernikov
Hello list! Currently we need to acquire 2 read locks to perform simple 6-byte copying from arp record to packet ethernet header. It seems that acquiring lle lock for fast path (main traffic flow) is not necessary even with current code. My tests shows ~10% improvement with this patch

Re: [patch] reducing arp locking

2012-11-07 Thread Adrian Chadd
On 7 November 2012 15:24, Alexander V. Chernikov melif...@freebsd.org wrote: Hello list! Currently we need to acquire 2 read locks to perform simple 6-byte copying from arp record to packet ethernet header. It seems that acquiring lle lock for fast path (main traffic flow) is not necessary