Re: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c
In message 19990702174337.d3...@dragon.nuxi.com David O'Brien writes: : So that makes three of us that believe the check should be agaist no : rather than yes. (setq check-against-no (+ check-against-no 1))
Re: Sv: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c
In message 012801bec4ee$cfb29380$0e00a...@neland.dk Leif Neland writes: : If there was someplace nice to put it: : ERROR! ^G^G^G^G^GFTP_PASSIVE_MODE must be either yes or no I disagree. This breaks the old behavior, while checking explicitly against no preserves all old behavior, except for those crazy people that set it to no expecting to turn it on (rather than off). Warner To Unsubscribe: send mail to majord...@freebsd.org with unsubscribe freebsd-hackers in the body of the message
Re: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c
... compared to the sources as of today. This gives minimal semantic difference from the way it worked before the change (which was that if FTP_PASSIVE_MODE existed, ftp used passive mode). I have to agree with Eivind, I know of people in my lab that have FTP_PASSIVE_MODE defined to nosense values since that is all that was required before. Now what are these poor souls to do when they upgrade to 3.3-R and their environment stops working -- -- David([EMAIL PROTECTED] -or- [EMAIL PROTECTED]) To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c
On Fri, Jul 02, 1999 at 05:15:14PM -0700, Mike Smith wrote: I have to agree with Eivind, I know of people in my lab that have FTP_PASSIVE_MODE defined to nosense values since that is all that was required before. Now what are these poor souls to do when they upgrade to 3.3-R and their environment stops working Unless they were dumb enough to set it to "no", the "right" fix would have it keep working. So that makes three of us that believe the check should be agaist "no" rather than "yes". -- -- David([EMAIL PROTECTED] -or- [EMAIL PROTECTED]) To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Sv: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c
- Original Message - From: David O'Brien [EMAIL PROTECTED] To: Dag-Erling Smorgrav [EMAIL PROTECTED]; Ruslan Ermilov [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Saturday, July 03, 1999 2:15 AM Subject: Re: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c ... compared to the sources as of today. This gives minimal semantic difference from the way it worked before the change (which was that if FTP_PASSIVE_MODE existed, ftp used passive mode). I have to agree with Eivind, I know of people in my lab that have FTP_PASSIVE_MODE defined to nosense values since that is all that was required before. Now what are these poor souls to do when they upgrade to 3.3-R and their environment stops working If there was someplace nice to put it: ERROR! ^G^G^G^G^GFTP_PASSIVE_MODE must be either "yes" or "no" Leif To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c
Four. :) On Fri, Jul 02, 1999 at 05:15:14PM -0700, Mike Smith wrote: I have to agree with Eivind, I know of people in my lab that have FTP_PASSIVE_MODE defined to nosense values since that is all that was required before. Now what are these poor souls to do when they upgrade to 3.3-R and their environment stops working Unless they were dumb enough to set it to "no", the "right" fix would have it keep working. So that makes three of us that believe the check should be agaist "no" rather than "yes". -- -- David([EMAIL PROTECTED] -or- [EMAIL PROTECTED]) To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c
... compared to the sources as of today. This gives minimal semantic difference from the way it worked before the change (which was that if FTP_PASSIVE_MODE existed, ftp used passive mode). I have to agree with Eivind, I know of people in my lab that have FTP_PASSIVE_MODE defined to nosense values since that is all that was required before. Now what are these poor souls to do when they upgrade to 3.3-R and their environment stops working -- -- David(obr...@nuxi.com -or- obr...@freebsd.org) To Unsubscribe: send mail to majord...@freebsd.org with unsubscribe freebsd-hackers in the body of the message
Re: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c
... compared to the sources as of today. This gives minimal semantic difference from the way it worked before the change (which was that if FTP_PASSIVE_MODE existed, ftp used passive mode). I have to agree with Eivind, I know of people in my lab that have FTP_PASSIVE_MODE defined to nosense values since that is all that was required before. Now what are these poor souls to do when they upgrade to 3.3-R and their environment stops working Unless they were dumb enough to set it to no, the right fix would have it keep working. -- \\ The mind's the standard \\ Mike Smith \\ of the man. \\ msm...@freebsd.org \\-- Joseph Merrick \\ msm...@cdrom.com To Unsubscribe: send mail to majord...@freebsd.org with unsubscribe freebsd-hackers in the body of the message
Re: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c
On Fri, Jul 02, 1999 at 05:15:14PM -0700, Mike Smith wrote: I have to agree with Eivind, I know of people in my lab that have FTP_PASSIVE_MODE defined to nosense values since that is all that was required before. Now what are these poor souls to do when they upgrade to 3.3-R and their environment stops working Unless they were dumb enough to set it to no, the right fix would have it keep working. So that makes three of us that believe the check should be agaist no rather than yes. -- -- David(obr...@nuxi.com -or- obr...@freebsd.org) To Unsubscribe: send mail to majord...@freebsd.org with unsubscribe freebsd-hackers in the body of the message
Sv: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c
- Original Message - From: David O'Brien obr...@freebsd.org To: Dag-Erling Smorgrav d...@flood.ping.uio.no; Ruslan Ermilov r...@freebsd.org; hack...@freebsd.org Sent: Saturday, July 03, 1999 2:15 AM Subject: Re: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c ... compared to the sources as of today. This gives minimal semantic difference from the way it worked before the change (which was that if FTP_PASSIVE_MODE existed, ftp used passive mode). I have to agree with Eivind, I know of people in my lab that have FTP_PASSIVE_MODE defined to nosense values since that is all that was required before. Now what are these poor souls to do when they upgrade to 3.3-R and their environment stops working If there was someplace nice to put it: ERROR! ^G^G^G^G^GFTP_PASSIVE_MODE must be either yes or no Leif To Unsubscribe: send mail to majord...@freebsd.org with unsubscribe freebsd-hackers in the body of the message
Re: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c
Four. :) On Fri, Jul 02, 1999 at 05:15:14PM -0700, Mike Smith wrote: I have to agree with Eivind, I know of people in my lab that have FTP_PASSIVE_MODE defined to nosense values since that is all that was required before. Now what are these poor souls to do when they upgrade to 3.3-R and their environment stops working Unless they were dumb enough to set it to no, the right fix would have it keep working. So that makes three of us that believe the check should be agaist no rather than yes. -- -- David(obr...@nuxi.com -or- obr...@freebsd.org) To Unsubscribe: send mail to majord...@freebsd.org with unsubscribe freebsd-hackers in the body of the message To Unsubscribe: send mail to majord...@freebsd.org with unsubscribe freebsd-hackers in the body of the message
Re: cvs commit: src/usr.bin/ftp Makefile fetch.c ftp.1 ftp.c ftp_var.h main.c util.c
On Thu, Jul 01, 1999 at 03:03:12PM +0200, Dag-Erling Smorgrav wrote: Ruslan Ermilov r...@freebsd.org writes: On Thu, Jul 01, 1999 at 01:51:24PM +0200, Eivind Eklund wrote: On Thu, Jul 01, 1999 at 04:33:37AM -0700, Ruslan Ermilov wrote: - separate the pftp and FTP_PASSIVE_MODE tests so gate mode works again PR: bin/12070 - specifically check that FTP_PASSIVE_MODE is set to YES, rather than just checking if it is defined We elected to change our defaults to having passive mode enabled - it sounds to me like it should explicitly check for FTP_PASSIVE_MODE=NO, not vice versa. [for some reason, Eivind's mail hasn't reached me yet] This is because my mail was a private mail to Ruslan, because I didn't feel that the issue was worth filling the committers list with (or really, interesting for anybody but me and the author of the code, which I thought was Ruslan). As it seems Ruslan feels differently, I'm keeping a public Cc:, but moving to -hackers. Eivind: what Ruslan just did was MFC some patches I committed a week or two ago but hadn't come around to MFCing yet (these were the patches I mentioned yesterday). If you had any objections, you should have raised them back then... Sorry; didn't notice back then. * 'unset FTP_PASSIVE_MODE' (or hack login.conf), which always worked * set FTP_PASSIVE_MODE=NO, which didn't work before the patch, because ftp(1) would just notice that FTP_PASSIVE_MODE was defined and assume it meant it should use passive mode. Some may find the second solution more obvious than the first; hence the PR and my patches. Changing ftp(1) to check for FTP_PASSIVE_MODE=NO rather than the reverse would gratuitously change ftp's reaction to its environment. Not at the first point this was done; it would avoid gratiously changing the reaction. Ie: Index: main.c === RCS file: /home/ncvs/src/usr.bin/ftp/main.c,v retrieving revision 1.18 diff -u -r1.18 main.c --- main.c 1999/06/25 14:11:15 1.18 +++ main.c 1999/07/01 14:41:35 @@ -135,7 +135,7 @@ cp = strrchr(argv[0], '/'); cp = (cp == NULL) ? argv[0] : cp + 1; if ((s = getenv(FTP_PASSIVE_MODE)) != NULL -strcasecmp(s, yes) == 0) +strcasecmp(s, no) != 0) passivemode = 1; if (strcmp(cp, pftp) == 0) passivemode = 1; ... compared to the sources as of today. This gives minimal semantic difference from the way it worked before the change (which was that if FTP_PASSIVE_MODE existed, ftp used passive mode). Eivind. To Unsubscribe: send mail to majord...@freebsd.org with unsubscribe freebsd-hackers in the body of the message
