[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-08-27 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 Kubilay Kocak changed: What|Removed |Added Flags|mfc-stable11?, |mfc-stable11+,

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-08-24 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 Cy Schubert changed: What|Removed |Added Resolution|--- |FIXED Status|In

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-08-24 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #41 from commit-h...@freebsd.org --- A commit references this bug: Author: cy Date: Sun Aug 25 04:56:35 UTC 2019 New revision: 351470 URL: https://svnweb.freebsd.org/changeset/base/351470 Log: MFC r350880: r272552 applied

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-08-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #40 from commit-h...@freebsd.org --- A commit references this bug: Author: cy Date: Sun Aug 11 23:54:49 UTC 2019 New revision: 350880 URL: https://svnweb.freebsd.org/changeset/base/350880 Log: r272552 applied the patch from

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-08-10 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 Cy Schubert changed: What|Removed |Added Status|Open|In Progress Flags|

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-08-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 Cy Schubert changed: What|Removed |Added Attachment #206344|0 |1 is obsolete|

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-08-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #37 from Cy Schubert --- No problem. I think there may still be a problem with the patch under certain circumstances. I'll continue to test, after which I will run it in my prod environment for a couple of weeks. Thank you

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-08-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #36 from WHR --- I think this bug is fixed by attachment 206344. Tested with kernel version 13.0-CURRENT r350491. Thanks for your hard work. -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-08-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 Cy Schubert changed: What|Removed |Added Attachment #205851|0 |1 is obsolete|

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-08-04 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #34 from Cy Schubert --- As suspected, only three interfaces of the four can be specified however only two are listed of which only the first is used. -- You are receiving this mail because: You are on the CC list for the

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-08-04 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #33 from Cy Schubert --- Getting back to this PR, I discovered other problems related to this, i.e. only space for 4 fr_ifnames. Put a fifth one in and the resulting structure becomes a mess without an error message. The whole

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-07-20 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #32 from WHR --- (In reply to Cy Schubert from comment #31) Of course 'fr_tifs' and 'fr_dif' are sturcts; but they contains index, in the struct, so you can't compare those indexes directly when comparing rule objects. --

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-07-20 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #31 from Cy Schubert --- fr_tifs and fr_dif are not indexes. frdest_t fr_tifs[2];/* "to"/"reply-to" interface */ frdest_t fr_dif;/* duplicate packet interface */ They're a struct with an IP address

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-07-20 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #30 from WHR --- (In reply to Cy Schubert from comment #29) I think this because your patch (attachment 205851) only fixed comparing indexes in 'fr_ifnames', but not indexes in 'fr_tifs' and 'fr_dif'. The order of strings in

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-07-19 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #29 from Cy Schubert --- I am only able to reproduce this problem when the on argument is moved ahead of the reply-to. root@ipftest:~ # echo "pass in quick reply-to tun0:10.1.1.1 on tun0 proto tcp from any to 10.1.1.11 port =

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-07-18 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #28 from WHR --- This testing OS is installed from the latest 13.0-CURRENT snapshot built image that I downloaded today, specifically,

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-07-18 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #27 from Cy Schubert --- I'm having no such problems as you are. Do you have INVARIANTS and WITNESS enabled in your kernel? Send me a copy of your ipf.conf and ipnat.conf, please. If you use ippool, that too, please. Except

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-07-18 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 --- Comment #26 from WHR --- (In reply to Cy Schubert from comment #23) This patch seems break adding rules: [root@ipfilter-test /usr/obj]# kldload usr/src/amd64.amd64/sys/modules/ipfilter/ipl.ko [root@ipfilter-test /usr/obj]# kldstat

[Bug 238796] ipfilter: failure to detect the same rules when arguments ordered differently

2019-07-18 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796 Cy Schubert changed: What|Removed |Added Summary|ipfilter: fix unremovable |ipfilter: failure to detect