Re: [RFC] Reduce namespace pollution on zlib.h

2010-04-01 Thread Dag-Erling Smørgrav
Xin LI delp...@gmail.com writes: I will merge an upstream change from zlib, which basically unexpose LFS stuff on FreeBSD, and I plan to keep the off_t bits == 64. However, I would highly recommend ports maintainers to push upstream fix for LFS64 definition removal since they are wrong on

Re: [RFC] Reduce namespace pollution on zlib.h

2010-03-31 Thread Pietro Cerutti
On 2010-Mar-27, 02:51, Dag-Erling Smørgrav wrote: Xin LI delp...@delphij.net writes: So... May I consider my import just exposed some existing bugs in other applications and we don't want to workaround these issues? Correct. Just to make it clear so that everyone knows how we're going to

Re: [RFC] Reduce namespace pollution on zlib.h

2010-03-31 Thread Xin LI
I will merge an upstream change from zlib, which basically unexpose LFS stuff on FreeBSD, and I plan to keep the off_t bits == 64. However, I would highly recommend ports maintainers to push upstream fix for LFS64 definition removal since they are wrong on FreeBSD On Mar 31, 2010 3:30 AM, Pietro

Re: [RFC] Reduce namespace pollution on zlib.h

2010-03-31 Thread Pietro Cerutti
On 2010-Mar-31, 03:41, Xin LI wrote: I will merge an upstream change from zlib, which basically unexpose LFS stuff on FreeBSD, and I plan to keep the off_t bits == 64. However, I would highly recommend ports maintainers to push upstream fix for LFS64 definition removal since they are wrong on

Re: [RFC] Reduce namespace pollution on zlib.h

2010-03-27 Thread Andrey Chernov
On Fri, Mar 26, 2010 at 05:26:03PM -0700, Xin LI wrote: This is wrong, FreeBSD has native 64-bit stat() etc. and does not need _LARGEFILE_WHATEVER. Yes we do not need that and it just cause compilation errors. The problem is that some third party software thinks that they need to define

[RFC] Reduce namespace pollution on zlib.h

2010-03-26 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, The recent zlib import has added some assumption that _LARGEFILE_64_SOURCE is only defined on systems with System V style *64 interface. Moreover, I have added _FILE_OFFSET_BITS = 64 definition into zconf.h so that it would pick up the 64 bit

Re: [RFC] Reduce namespace pollution on zlib.h

2010-03-26 Thread Jung-uk Kim
On Friday 26 March 2010 02:34 pm, Xin LI wrote: Hi, The recent zlib import has added some assumption that _LARGEFILE_64_SOURCE is only defined on systems with System V style *64 interface. Moreover, I have added _FILE_OFFSET_BITS = 64 definition into zconf.h so that it would pick up the 64

Re: [RFC] Reduce namespace pollution on zlib.h

2010-03-26 Thread Dag-Erling Smørgrav
Xin LI delp...@delphij.net writes: The recent zlib import has added some assumption that _LARGEFILE_64_SOURCE is only defined on systems with System V style *64 interface. Moreover, I have added _FILE_OFFSET_BITS = 64 definition into zconf.h so that it would pick up the 64 bit interface

Re: [RFC] Reduce namespace pollution on zlib.h

2010-03-26 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2010/03/26 17:02, Dag-Erling Smørgrav wrote: Xin LI delp...@delphij.net writes: The recent zlib import has added some assumption that _LARGEFILE_64_SOURCE is only defined on systems with System V style *64 interface. Moreover, I have added

Re: [RFC] Reduce namespace pollution on zlib.h

2010-03-26 Thread Dag-Erling Smørgrav
Xin LI delp...@delphij.net writes: The problem is that some third party software thinks that they need to define _LARGEFILE64_*, which will break zlib.h on FreeBSD :( Then that third-party software is broken and needs to be fixed. _LARGEFILE64_SOURCE is (supposed to be) used to expose the

Re: [RFC] Reduce namespace pollution on zlib.h

2010-03-26 Thread Dag-Erling Smørgrav
Xin LI delp...@delphij.net writes: The recent zlib import has added some assumption that _LARGEFILE_64_SOURCE is only defined on systems with System V style *64 interface. I forgot to address this point in your original message. Basically, the entire thread boils down to this: that assumption

Re: [RFC] Reduce namespace pollution on zlib.h

2010-03-26 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2010/03/26 17:46, Dag-Erling Smørgrav wrote: Xin LI delp...@delphij.net writes: The problem is that some third party software thinks that they need to define _LARGEFILE64_*, which will break zlib.h on FreeBSD :( Then that third-party software

Re: [RFC] Reduce namespace pollution on zlib.h

2010-03-26 Thread Dag-Erling Smørgrav
Xin LI delp...@delphij.net writes: So... May I consider my import just exposed some existing bugs in other applications and we don't want to workaround these issues? Correct. DES -- Dag-Erling Smørgrav - d...@des.no ___ freebsd-ports@freebsd.org