Re: failed bsd.qt.mk fix...

2011-07-03 Thread Chris Rees
On 2 July 2011 00:36, Alberto Villa avi...@freebsd.org wrote: On Friday 01 July 2011 21:00:07 Rene Ladan wrote: Wouldn't it be better to use ${CC} instead of cc in the above patch so that clang is also (a bit more) supported? no. please, read the whole logic to understand how it works. that

Re: failed bsd.qt.mk fix...

2011-07-03 Thread Alberto Villa
On Sunday 03 July 2011 15:25:09 Chris Rees wrote: As I read it, while it supports a system where cc is a link to clang, it still clobbers whatever ${CC} variable I have set. this is wrong. here is how the logic works: - find if cc is gcc or clang - if CXX is the default c++, then we're using

Re: failed bsd.qt.mk fix...

2011-07-03 Thread Chris Rees
On 3 July 2011 18:08, Alberto Villa avi...@freebsd.org wrote: On Sunday 03 July 2011 15:25:09 Chris Rees wrote: As I read it, while it supports a system where cc is a link to clang, it still clobbers whatever ${CC} variable I have set. this is wrong. here is how the logic works: - find if cc

Re: failed bsd.qt.mk fix...

2011-07-01 Thread Oliver Pinter
after reverting this: http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.qt.mk.diff?r1=1.24;r2=1.25 everything look fine.. On 7/1/11, Oliver Pinter oliver.p...@gmail.com wrote: awk: syntax error at source line 1 context is NR == 1 { gsub(/[()]/, , ) awk: illegal statement at

Re: failed bsd.qt.mk fix...

2011-07-01 Thread Rene Ladan
Op 01-07-2011 20:54, Oliver Pinter schreef: On 7/1/11, Oliver Pinter oliver.p...@gmail.com wrote: after reverting this: http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.qt.mk.diff?r1=1.24;r2=1.25 everything look fine.. or use this patch: op@pandora-d ~ less /tmp/diff --- bsd.qt.mk

Re: failed bsd.qt.mk fix...

2011-07-01 Thread Oliver Pinter
The original (commited patch in ports) is not my patch. I only wrote a fixup to make it usable, after avillas commit breaked the ports. On 7/1/11, Rene Ladan r...@freebsd.org wrote: Op 01-07-2011 20:54, Oliver Pinter schreef: On 7/1/11, Oliver Pinter oliver.p...@gmail.com wrote: after

Re: failed bsd.qt.mk fix...

2011-07-01 Thread Alberto Villa
On Friday 01 July 2011 21:00:07 Rene Ladan wrote: Wouldn't it be better to use ${CC} instead of cc in the above patch so that clang is also (a bit more) supported? no. please, read the whole logic to understand how it works. that check is done to support cc == clang, which means that clang is