Re: Sudden trouble with net/rdesktop

2020-11-15 Thread Carmel NY
On Sun, 15 Nov 2020 13:13:57 +0300, abi via freebsd-ports stated: >I have the same problem, however I'm sure that nothing has changed on >remote side (Windows Update is completely disabled). I updated my >FreeBSD workstation though to 12.2 and all ports. Exactly what goal do you intend to

Re: Sudden trouble with net/rdesktop

2020-11-15 Thread abi via freebsd-ports
On 12.11.2020 19:12, Yuri Pankov wrote: Andrea Venturoli wrote: Hello. After many year of happy usage, since yesterday rdesktop dumps core (12.2/amd64). % rdesktop xx Assertion failed: ((len * 2) < size), function _utils_data_to_hex, file utils.c, line 499. Abort (core dumped)

Re: Sudden trouble with net/rdesktop

2020-11-13 Thread Greg Veldman
On Fri, Nov 13, 2020 at 05:53:06PM +0300, Yuri Pankov wrote: > size is 128 now, so with digest of 256 we fail the ((len * 2) < size) > assertion, 257 works though (or changing the assertion to be <=). The call to gnutls_x509_crt_get_fingerprint adjusts the size of buf. I looked at the size

Re: Sudden trouble with net/rdesktop

2020-11-13 Thread Yuri Pankov
Greg Veldman wrote: On Fri, Nov 13, 2020 at 03:52:54PM +0300, Yuri Pankov wrote: OK, I was able to reproduce this; actually, it hit that assertion for all Windows 10 20H2 installs I have, all are updated to latest patches, so I can't tell when this started to happen. Adding a debug print

Re: Sudden trouble with net/rdesktop

2020-11-13 Thread Greg Veldman
On Fri, Nov 13, 2020 at 03:52:54PM +0300, Yuri Pankov wrote: > OK, I was able to reproduce this; actually, it hit that assertion for > all Windows 10 20H2 installs I have, all are updated to latest patches, > so I can't tell when this started to happen. Adding a debug print > before that

Re: Sudden trouble with net/rdesktop

2020-11-13 Thread Andrea Venturoli
On 11/13/20 1:52 PM, Yuri Pankov wrote: So we need the len of 128 we need size of digest buf to be > 256, the following patch worked for me: You beat me to this :) I compiled rdesktop with DEBUG last night, but still it stripped the debug info. So I was not able to look at it yet. Also

Re: Sudden trouble with net/rdesktop

2020-11-13 Thread Yuri Pankov
Andrea Venturoli wrote: On 11/12/20 5:18 PM, Yuri Pankov wrote: Could it be something that changed on remote side, e.g. any recent updates? Sure. Most targets are Windows 10 machines, so they possibly updated to a newer version, but I don't know. One is Windows 2012, though, so I don't

Re: Sudden trouble with net/rdesktop

2020-11-12 Thread Andrea Venturoli
On 11/12/20 5:18 PM, Yuri Pankov wrote: Could it be something that changed on remote side, e.g. any recent updates? Sure. Most targets are Windows 10 machines, so they possibly updated to a newer version, but I don't know. One is Windows 2012, though, so I don't think that changed that

Re: Sudden trouble with net/rdesktop

2020-11-12 Thread Yuri Pankov
Andrea Venturoli wrote: Hello. After many year of happy usage, since yesterday rdesktop dumps core (12.2/amd64). % rdesktop xx Assertion failed: ((len * 2) < size), function _utils_data_to_hex, file utils.c, line 499. Abort (core dumped) This is systematic with 4 servers out of 5;

Re: Sudden trouble with net/rdesktop

2020-11-12 Thread Yuri Pankov
Yuri Pankov wrote: Andrea Venturoli wrote: Hello. After many year of happy usage, since yesterday rdesktop dumps core (12.2/amd64). % rdesktop xx Assertion failed: ((len * 2) < size), function _utils_data_to_hex, file utils.c, line 499. Abort (core dumped) This is systematic with 4

Sudden trouble with net/rdesktop

2020-11-12 Thread Andrea Venturoli
Hello. After many year of happy usage, since yesterday rdesktop dumps core (12.2/amd64). % rdesktop xx Assertion failed: ((len * 2) < size), function _utils_data_to_hex, file utils.c, line 499. Abort (core dumped) This is systematic with 4 servers out of 5; the 5th still works