Re: Practice of "Sponsored by" in commit messages

2018-05-19 Thread John W. O'Brien
On 2018/05/18 16:32, John W. O'Brien wrote: > On 5/18/18 14:20, Kurt Jaeger wrote: >> Hi! >> >>> The FreeBSD project could help by asking committers to qualify >>> "Sponsored by" lines to indicate which participant(s) is(are) sponsored, >>> in way that is equivalent to the way that the

Re: Practice of "Sponsored by" in commit messages

2018-05-19 Thread Kurt Jaeger
Hi! > You guys are still trying to read and interpret labels on the t-shirts I > think. "Sponsored by: XYZ" in the commit message only means that some > undefined portion of the work has been in some form supported or encouraged > by XYZ. John suggests a way to improve the precision of that "Spon

Re: Practice of "Sponsored by" in commit messages

2018-05-18 Thread Eitan Adler
On 18 May 2018 at 11:20, Kurt Jaeger wrote: > Hi! > >> The FreeBSD project could help by asking committers to qualify >> "Sponsored by" lines to indicate which participant(s) is(are) sponsored, >> in way that is equivalent to the way that the actual work itself is >> customaril

Re: Practice of "Sponsored by" in commit messages

2018-05-18 Thread John W. O'Brien
On 2018/05/18 07:38, John W. O'Brien wrote: > On 2018/05/18 00:15, Kurt Jaeger wrote: >> Hi! >> >>> The FreeBSD project could help by asking committers to qualify >>> "Sponsored by" lines to indicate which participant(s) is(are) sponsored, >>> in way that is equivalent to the way that the actual wo

Re: Practice of "Sponsored by" in commit messages

2018-05-18 Thread John W. O'Brien
On 5/18/18 14:20, Kurt Jaeger wrote: > Hi! > >> The FreeBSD project could help by asking committers to qualify >> "Sponsored by" lines to indicate which participant(s) is(are) sponsored, >> in way that is equivalent to the way that the actual work itself is >> customarily attribute

Re: Practice of "Sponsored by" in commit messages

2018-05-18 Thread Kurt Jaeger
Hi! > The FreeBSD project could help by asking committers to qualify > "Sponsored by" lines to indicate which participant(s) is(are) sponsored, > in way that is equivalent to the way that the actual work itself is > customarily attributed. > >>> This sounds reasonable, so I su

Re: Practice of "Sponsored by" in commit messages

2018-05-18 Thread Eitan Adler
On 18 May 2018 at 04:40, John W. O'Brien wrote: > On 2018/05/18 00:43, Eitan Adler wrote: >> On 17 May 2018 at 21:15, Kurt Jaeger wrote: >>> Hi! >>> The FreeBSD project could help by asking committers to qualify "Sponsored by" lines to indicate which participant(s) is(are) sponsored, >>

Re: Practice of "Sponsored by" in commit messages

2018-05-18 Thread John W. O'Brien
On 2018/05/18 00:43, Eitan Adler wrote: > On 17 May 2018 at 21:15, Kurt Jaeger wrote: >> Hi! >> >>> The FreeBSD project could help by asking committers to qualify >>> "Sponsored by" lines to indicate which participant(s) is(are) sponsored, >>> in way that is equivalent to the way that the actual w

Re: Practice of "Sponsored by" in commit messages

2018-05-18 Thread John W. O'Brien
On 2018/05/18 00:15, Kurt Jaeger wrote: > Hi! > >> The FreeBSD project could help by asking committers to qualify >> "Sponsored by" lines to indicate which participant(s) is(are) sponsored, >> in way that is equivalent to the way that the actual work itself is >> customarily attributed. > > This

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread Eitan Adler
On 17 May 2018 at 21:15, Kurt Jaeger wrote: > Hi! > >> The FreeBSD project could help by asking committers to qualify >> "Sponsored by" lines to indicate which participant(s) is(are) sponsored, >> in way that is equivalent to the way that the actual work itself is >> customarily attributed. > > Th

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread Maxim Sobolev
You guys are still trying to read and interpret labels on the t-shirts I think. "Sponsored by: XYZ" in the commit message only means that some undefined portion of the work has been in some form supported or encouraged by XYZ. It does not mean or imply all work, it does not mean any particular form

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread Kurt Jaeger
Hi! > The FreeBSD project could help by asking committers to qualify > "Sponsored by" lines to indicate which participant(s) is(are) sponsored, > in way that is equivalent to the way that the actual work itself is > customarily attributed. This sounds reasonable, so I suggest that you submit a pa

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread John W. O'Brien
On 2018/05/17 19:36, Maxim Sobolev wrote: > Well, if your  employer feels  slighted it's for him to bring it up with > you (see my previous rant on the amount and scope of the credit and who > parties involved). And then for you to bring it up with me if you feel > brave enough. :) I don't see how

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread Maxim Sobolev
Well, if your employer feels slighted it's for him to bring it up with you (see my previous rant on the amount and scope of the credit and who parties involved). And then for you to bring it up with me if you feel brave enough. :) I don't see how and why FreeBSD project can help in this highly hy

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread John W. O'Brien
On 2018/05/17 19:18, Maxim Sobolev wrote: > John, no, not really, sorry. Work is done, credit is given. The form and > amount of this credit is between whoever does the work and whoever is > being credited. I don't see why is there any third-party to be involved > in governing whether or not this c

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread Maxim Sobolev
John, no, not really, sorry. Work is done, credit is given. The form and amount of this credit is between whoever does the work and whoever is being credited. I don't see why is there any third-party to be involved in governing whether or not this credit is "appropriate", "sufficient" or "all encom

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread John W. O'Brien
On 2018/05/14 20:25, Julian Elischer wrote: > On 15/5/18 7:40 am, John W. O'Brien wrote: >> Hello FreeBSD Ports, >> >> The Committer's Guide section on Commit Log Messages [0], doesn't cover >> the use of the "Sponsored by" key word. As a non-committer contributor, >> it only recently occurred to m

Re: Practice of "Sponsored by" in commit messages

2018-05-17 Thread John W. O'Brien
On 2018/05/14 20:14, Maxim Sobolev wrote: > What's wrong with a current practice. Why is it of any concern to you, > John? Just curious that is not very clear from your message. It is like > someone trying to moderate what people in general or some group in > particular (e.g. freebsd committers) ar

Re: Practice of "Sponsored by" in commit messages

2018-05-14 Thread Dave Horsfall
On Mon, 14 May 2018, Maxim Sobolev wrote: It is like someone trying to moderate what people in general or some group in particular (e.g. freebsd committers) are allowed to put on their t-shirts just because you find it offensive or inappropriate. Now, where did I put that link to the "t-shirt

Re: Practice of "Sponsored by" in commit messages

2018-05-14 Thread Maxim Sobolev
What's wrong with a current practice. Why is it of any concern to you, John? Just curious that is not very clear from your message. It is like someone trying to moderate what people in general or some group in particular (e.g. freebsd committers) are allowed to put on their t-shirts just because yo

Re: Practice of "Sponsored by" in commit messages

2018-05-14 Thread Julian Elischer
On 15/5/18 7:40 am, John W. O'Brien wrote: Hello FreeBSD Ports, The Committer's Guide section on Commit Log Messages [0], doesn't cover the use of the "Sponsored by" key word. As a non-committer contributor, it only recently occurred to me to wonder what work that credit is intended to represent