Re: loader not working with GPT and LOADER_ZFS_SUPPORT

2009-05-28 Thread Kip Macy
MFC'd in 192969

On Wed, May 27, 2009 at 3:31 PM, Artis Caune artis.ca...@gmail.com wrote:
 2009/5/28 Lorenzo Perone lopez.on.the.li...@yellowspace.net:
 Hi, I'm a bit confused:

 I can't find this change (rev 185095) in the stable log, yet stable has some
 other
 recent changes related to the current posts (in turn commited also to
 head)...

 http://svn.freebsd.org/viewvc/base/head/sys/boot/i386/libi386/biosdisk.c?view=log
 http://svn.freebsd.org/viewvc/base/stable/7/sys/boot/i386/libi386/biosdisk.c?view=log

 maybe I'm misunderstanding how things eventually get ingto -stable,
 however, which revision to use now for a peaceful world  boot? :)

 I'll go for the -head version for my next try..


 It's not merged to stable yet. You should apply r185095 diff by hand.
 Just edit sys/boot/i386/libi386/biosdisk.c and change:


 --- sys/boot/i386/libi386/biosdisk.c    (revision 192872)
 +++ sys/boot/i386/libi386/biosdisk.c    (working copy)
 @@ -996,8 +996,10 @@
     od-od_boff = gp-gp_start;

  out:
 -    if (error)
 +    if (error) {
        free(od-od_partitions);
 +       od-od_flags = ~BD_GPTOK;
 +    }
     return (error);
  }

 @@ -1088,7 +1090,7 @@

     switch(rw){
     case F_READ:
 -       DEBUG(read %d from %d to %p, blks, dblk, buf);
 +       DEBUG(read %d from %lld to %p, blks, dblk, buf);

        if (blks  bd_read(od, dblk, blks, buf)) {
            DEBUG(read error);




 --
 Artis Caune

    Everything should be made as simple as possible, but not simpler.




-- 
When bad men combine, the good must associate; else they will fall one
by one, an unpitied sacrifice in a contemptible struggle.

Edmund Burke
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: loader not working with GPT and LOADER_ZFS_SUPPORT

2009-05-28 Thread Ruben van Staveren


On 28 May 2009, at 9:40, Kip Macy wrote:


MFC'd in 192969


Thanks for the explanation and all the hard work!

Kind Regards,
Ruben

___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: loader not working with GPT and LOADER_ZFS_SUPPORT

2009-05-27 Thread Ruben van Staveren

Hi all,

On 26 May 2009, at 18:10, George Hartzell wrote:


Artis Caune writes:

2009/5/26 Philipp Wuensche cryx-free...@h3q.com:

Hi,

I tried booting from a disk with GPT scheme, with a /boot/loader  
build
with LOADER_ZFS_SUPPORT=yes in make.conf. I get the following  
error:


panic: free: guard1 fail @ 0x2fd4a6ac from
/usr/src/sys/boot/i386/libi386/biosdisk.c:1053


Same problem for me. I also tried with MBR scheme, same problem.


Updated kernel + world yesterday, setting LOADER_ZFS_SUPPORT=yes in  
make.conf


Same symptom, had to revert to the old loader for that.

Prior to that I needed to do a cd /usr/src/usr.sbin/btxld  make  
install clean in order to work around the


btxld: zfsboot.ldr: Invalid argument

problem during building world+kernel

Regards,
Ruben
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: loader not working with GPT and LOADER_ZFS_SUPPORT

2009-05-27 Thread Artis Caune
 I tried booting from a disk with GPT scheme, with a /boot/loader build
 with LOADER_ZFS_SUPPORT=yes in make.conf. I get the following error:

 panic: free: guard1 fail @ 0x2fd4a6ac from
 /usr/src/sys/boot/i386/libi386/biosdisk.c:1053


MFC r185095 fixed this problem!

http://svn.freebsd.org/viewvc/base?view=revisionrevision=185095




-- 
Artis Caune

Everything should be made as simple as possible, but not simpler.
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: loader not working with GPT and LOADER_ZFS_SUPPORT

2009-05-27 Thread Andriy Gapon
on 27/05/2009 15:48 Artis Caune said the following:
 
 MFC r185095 fixed this problem!
 
 http://svn.freebsd.org/viewvc/base?view=revisionrevision=185095

I can confirm that this helps!
Thanks for discovering!

-- 
Andriy Gapon
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: loader not working with GPT and LOADER_ZFS_SUPPORT

2009-05-27 Thread Lorenzo Perone


On 27.05.2009, at 14:48, Artis Caune wrote:

I tried booting from a disk with GPT scheme, with a /boot/loader  
build
with LOADER_ZFS_SUPPORT=yes in make.conf. I get the following  
error:


panic: free: guard1 fail @ 0x2fd4a6ac from
/usr/src/sys/boot/i386/libi386/biosdisk.c:1053



MFC r185095 fixed this problem!

http://svn.freebsd.org/viewvc/base?view=revisionrevision=185095


Hi, I'm a bit confused:

I can't find this change (rev 185095) in the stable log, yet stable  
has some other
recent changes related to the current posts (in turn commited also to  
head)...


http://svn.freebsd.org/viewvc/base/head/sys/boot/i386/libi386/biosdisk.c?view=log
http://svn.freebsd.org/viewvc/base/stable/7/sys/boot/i386/libi386/biosdisk.c?view=log

maybe I'm misunderstanding how things eventually get ingto -stable,
however, which revision to use now for a peaceful world  boot? :)

I'll go for the -head version for my next try..

Regards,

Lorenzo


___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: loader not working with GPT and LOADER_ZFS_SUPPORT

2009-05-27 Thread Artis Caune
2009/5/28 Lorenzo Perone lopez.on.the.li...@yellowspace.net:
 Hi, I'm a bit confused:

 I can't find this change (rev 185095) in the stable log, yet stable has some
 other
 recent changes related to the current posts (in turn commited also to
 head)...

 http://svn.freebsd.org/viewvc/base/head/sys/boot/i386/libi386/biosdisk.c?view=log
 http://svn.freebsd.org/viewvc/base/stable/7/sys/boot/i386/libi386/biosdisk.c?view=log

 maybe I'm misunderstanding how things eventually get ingto -stable,
 however, which revision to use now for a peaceful world  boot? :)

 I'll go for the -head version for my next try..


It's not merged to stable yet. You should apply r185095 diff by hand.
Just edit sys/boot/i386/libi386/biosdisk.c and change:


--- sys/boot/i386/libi386/biosdisk.c(revision 192872)
+++ sys/boot/i386/libi386/biosdisk.c(working copy)
@@ -996,8 +996,10 @@
 od-od_boff = gp-gp_start;

 out:
-if (error)
+if (error) {
free(od-od_partitions);
+   od-od_flags = ~BD_GPTOK;
+}
 return (error);
 }

@@ -1088,7 +1090,7 @@

 switch(rw){
 case F_READ:
-   DEBUG(read %d from %d to %p, blks, dblk, buf);
+   DEBUG(read %d from %lld to %p, blks, dblk, buf);

if (blks  bd_read(od, dblk, blks, buf)) {
DEBUG(read error);




-- 
Artis Caune

Everything should be made as simple as possible, but not simpler.
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: loader not working with GPT and LOADER_ZFS_SUPPORT

2009-05-26 Thread Artis Caune
2009/5/26 Philipp Wuensche cryx-free...@h3q.com:
 Hi,

 I tried booting from a disk with GPT scheme, with a /boot/loader build
 with LOADER_ZFS_SUPPORT=yes in make.conf. I get the following error:

 panic: free: guard1 fail @ 0x2fd4a6ac from
 /usr/src/sys/boot/i386/libi386/biosdisk.c:1053

Same problem for me. I also tried with MBR scheme, same problem.




-- 
Artis Caune

Everything should be made as simple as possible, but not simpler.
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: loader not working with GPT and LOADER_ZFS_SUPPORT

2009-05-26 Thread George Hartzell
Artis Caune writes:
  2009/5/26 Philipp Wuensche cryx-free...@h3q.com:
   Hi,
  
   I tried booting from a disk with GPT scheme, with a /boot/loader build
   with LOADER_ZFS_SUPPORT=yes in make.conf. I get the following error:
  
   panic: free: guard1 fail @ 0x2fd4a6ac from
   /usr/src/sys/boot/i386/libi386/biosdisk.c:1053
  
  Same problem for me. I also tried with MBR scheme, same problem.

I had a similar problem (different @ 0x address) with -STABLE over
the weekend.  I just wanted to boot an old fashioned system, MBR and
no ZFS.  I ended up building a loader with

  LOADER_ZFS_SUPPORT=NO
  LOADER_NO_GPT_SUPPORT=YES

and it worked.

g.

___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org