Re: VIMAGE + PF crash in mbuf destructor

2013-07-22 Thread Marko Zec
On Monday 22 July 2013 21:01:31 Adrian Chadd wrote: > Well I'm worried about _other_ stuff causing issues here. > > So - what's the "right" behaviour? Does vnet/vimage make the > assumption that for all the mbuf processing/free operations, the vnet > tag/state is set? To the best of my knowledge,

Re: VIMAGE + PF crash in mbuf destructor

2013-07-22 Thread Craig Rodrigues
On Mon, Jul 22, 2013 at 10:11 AM, Adrian Chadd wrote: > > I don't think the default vnet context is the correct behaviour there. > We'd need to figure out what the vnet context of the mbuf is and set > that. > > What do you think about Marko's suggestion to de-virtualize V_pf_mtag_z? What would

Re: VIMAGE + PF crash in mbuf destructor

2013-07-22 Thread Adrian Chadd
Well I'm worried about _other_ stuff causing issues here. So - what's the "right" behaviour? Does vnet/vimage make the assumption that for all the mbuf processing/free operations, the vnet tag/state is set? -adrian On 22 July 2013 11:59, Craig Rodrigues wrote: > On Mon, Jul 22, 2013 at 10:11 A

Re: VIMAGE + PF crash in mbuf destructor

2013-07-22 Thread Adrian Chadd
On 22 July 2013 08:43, Nikos Vassiliadis wrote: > Hi, > > I think this comes from the eventhandlers pf installs to handle > ifnet events. It seems like a wifi event causes this code to run > and the context is not set. Does the panic happen only when you > use vnet jails? > > Could you try putting

Re: VIMAGE + PF crash in mbuf destructor

2013-07-22 Thread Nikos Vassiliadis
On 07/22/13 09:32, Craig Rodrigues wrote: Hi, I used a kernel config with the following lines: include GENERIC options VIMAGE and compiled a CURRENT kernel from svn://svn.freebsd.org/base/head@253346 . I also have PF enabled on my system. Once in a while I have been getting kernel panics lik

Re: VIMAGE + PF crash in mbuf destructor

2013-07-22 Thread Marko Zec
On Monday 22 July 2013 08:57:43 Craig Rodrigues wrote: > On Sun, Jul 21, 2013 at 11:38 PM, Adrian Chadd wrote: > > hm. There's lots of mbuf free calls in the net80211 TX and RX path; do > > we have to have to set the vnet context during the whole tx/rx path? > > I'm not sure about that. > In src/s

Re: VIMAGE + PF crash in mbuf destructor

2013-07-21 Thread Craig Rodrigues
On Sun, Jul 21, 2013 at 11:38 PM, Adrian Chadd wrote: > hm. There's lots of mbuf free calls in the net80211 TX and RX path; do > we have to have to set the vnet context during the whole tx/rx path? > I'm not sure about that. In src/sys/netpfil/pf/pf.c, we have this in pf_initialize(): 751

Re: VIMAGE + PF crash in mbuf destructor

2013-07-21 Thread Adrian Chadd
hm. There's lots of mbuf free calls in the net80211 TX and RX path; do we have to have to set the vnet context during the whole tx/rx path? -adrian On 21 July 2013 23:32, Craig Rodrigues wrote: > Hi, > > I used a kernel config with the following lines: > > include GENERIC > options VIMAGE > >

VIMAGE + PF crash in mbuf destructor

2013-07-21 Thread Craig Rodrigues
Hi, I used a kernel config with the following lines: include GENERIC options VIMAGE and compiled a CURRENT kernel from svn://svn.freebsd.org/base/head@253346 . I also have PF enabled on my system. Once in a while I have been getting kernel panics like these: =