[Freeciv-Dev] [patch #6104] [Killstack] Patch allows unit to escape instead of been killed

2015-06-05 Thread Sławomir Lach
Follow-up Comment #4, patch #6104 (project freeciv): Had a quick look. I spotted some coding style issues. (See doc/CodingStyle) Don't use tabs. Why start the then and else blocks with an empty line? 1. My editor probably adds tabulators, thanks for information 2. It's because my adult

[Freeciv-Dev] [patch #6105] AI: Being the target of join city is usually good.

2015-06-05 Thread Sveinung Kvilhaugsvik
Update of patch #6105 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #6106] AI: Warn if being a target of a new action isn't handled.

2015-06-05 Thread Sveinung Kvilhaugsvik
Update of patch #6106 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #6107] Unhardcode action success incident causing.

2015-06-05 Thread Sveinung Kvilhaugsvik
Update of patch #6107 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #5539] Idea: Make what actions provides a casus belli ruleset configurable

2015-06-05 Thread Sveinung Kvilhaugsvik
Update of patch #5539 (project freeciv): Depends on: = patch #6099 ___ Follow-up Comment #2: If the victim of an action gets a casus belli when an action is successful and when the actor

[Freeciv-Dev] [patch #5539] Idea: Make what actions provides a casus belli ruleset configurable

2015-06-05 Thread Sveinung Kvilhaugsvik
Update of patch #5539 (project freeciv): Depends on: = patch #6101 ___ Follow-up Comment #3: Getting caught during a diplomatic battle currently don't cause an incident. Should it be

[Freeciv-Dev] [patch #6104] [Killstack] Patch allows unit to escape instead of been killed

2015-06-05 Thread Sławomir Lach
Follow-up Comment #5, patch #6104 (project freeciv): Hi again. I have repaired(I hope) all problems. New patch version also allows to escape into tile, where living only units of the same nation. The one problem is message about unit successfull escape isn't send to unit owner. I have looked at

[Freeciv-Dev] [patch #6104] [Killstack] Patch allows unit to escape instead of been killed

2015-06-05 Thread Sveinung Kvilhaugsvik
Update of patch #6104 (project freeciv): Status:None = In Progress Assigned to:None = sveinung ___ Follow-up Comment #6: _Have I define new