http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
2008/6/22 Jason Dorje Short:
>
> I'd suggest using valgrind to find the exact line where the error occurs
> here and to make sure the fix actually fixes and doesn't just hide the
> error.
Valgrind can show only the point where actual illega
http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
Marko Lindqvist wrote:
> http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
>
> 2008/6/22 Jason Dorje Short <[EMAIL PROTECTED]>:
>> http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
>>
>> How do you trigger this crash?
>
> In theo
http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
2008/6/22 Jason Dorje Short <[EMAIL PROTECTED]>:
>
> http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
>
> How do you trigger this crash?
In theory:
1) Start New Game
2) Observe (become global observer)
3) Pick Nation ( /take - )
http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
How do you trigger this crash?
-jason
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
2008/6/22 Marko Lindqvist:
> There is no game.player_ptr or packet_remove_player in S2_2 and
> TRUNK. This patch only
> - Revert my earlier patch, but uses proper accessor functions instead
> of old implementation
...and one more mistake
http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
Maybe this patch makes more sense.
Crash was caused by adjusting player_idx, and setting bogus
player_ptr, for global observer in game_renumber_players.
S2_1 version:
- Fixes the bug
- Adds sanity check for player number received in pl
http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
> [EMAIL PROTECTED] - Sun Jun 22 07:01:15 2008]:
>
> Marko Lindqvist wrote:
> > http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
> >
> > $subject
> >
> > To be committed soon.
>
> if (game.player_ptr) {
> char *text;
>
http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
Marko Lindqvist wrote:
> http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
>
> $subject
>
> To be committed soon.
if (game.player_ptr) {
char *text;
-if (game.player_ptr->is_ready) {
+if (game.player_ptr == NULL)
http://bugs.freeciv.org/Ticket/Display.html?id=40303 >
$subject
To be committed soon.
- ML
diff -Nurd -X.diff_ignore freeciv/client/gui-gtk-2.0/gui_main.c
freeciv/client/gui-gtk-2.0/gui_main.c
--- freeciv/client/gui-gtk-2.0/gui_main.c 2008-05-16 01:50:17.0
+0300
+++ freeciv
