[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Update of bug #15255 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #16, bug #15255 (project freeciv): I have one little addition to the patch: prevent jungles in case of swamp selection in make_terrains(); no jungles near the poles in TT_TEMPERATE. PLACE_ONE_TYPE(swamps_count, forests_count, -pick_terrain(MG_WET, MG_LAST, M

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #15, bug #15255 (project freeciv): sorry if it was not clear - it is OK for committing. The things listed are only the results of testing lot of freeciv maps. If there will be a patch, it is of low priority and only a cosmetic change. ___

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #14, bug #15255 (project freeciv): So what is your conclusion? Ok for committing, or need again to be improved? ___ Reply to this item at: ___

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #13, bug #15255 (project freeciv): > Will compile the patch now and then test some maps ... I tested the patch and if swamps are allowed in !FROZEN terrains they look fine for the different generators and temperature settings of 30 / 50 / 70 (swamp explanation in bug #15001).

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #12, bug #15255 (project freeciv): > could you please change the following copy & paste error Done. > I forgot to break the lines after 78 characters, sorry! Normally, the maximal number of characters is 77 per line. If we wouldn't make mistakes, we wouldn't be human! (file

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #11, bug #15255 (project freeciv): nitpicking on my own comments in the code: * could you please change the following copy & paste error (line 1309): - /* initialise terrain selection lists used by make_island() */ + /* free terrain selection lists used by make_isla

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #10, bug #15255 (project freeciv): The patch looks good! I think it will also solves bug #15001. Will compile the patch now and then test some maps ... I forgot to break the lines after 78 characters, sorry! ___ Reply t

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #9, bug #15255 (project freeciv): > Do you have a patch file? lol, I forgot to attach it. (file #7977) ___ Additional Item Attachment: File name: trunk_generator.diff Size:25 KB

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #8, bug #15255 (project freeciv): Do you have a patch file? ___ Reply to this item at: ___ Nachricht geschickt von/durch Gna! http://gna.org

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Update of bug #15255 (project freeciv): Status: Postponed => Ready For Test ___ Follow-up Comment #7: Improved version for trunk: (full patch, does not depend of bug# 15001) * Really create swamp t

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Update of bug #15255 (project freeciv): Depends on: => bugs #15001 ___ Reply to this item at: ___ Nachricht g

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #6, bug #15255 (project freeciv): updated patch: update make_island() - generator 3 * complete rework of the function make_island() * definition of the terrain_selection within its own function (island_terrain_init()) * update print_mapgen_map() to print more information (fil

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #5, bug #15255 (project freeciv): > you moved pick_terrain() into the while loop of fill_island()? > this way it will be called in each loop. Precisely to be called each loop and don't fill an island with a very few types. If a ruleset contains tons of terrain types, then the

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #4, bug #15255 (project freeciv): > Could you try to improve this patch yourself? I will work on this patch. Could you tell me the reason why: * you moved pick_terrain() into the while loop of fill_island()? this way it will be called in each loop. * you use tmap_is() and tes

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Update of bug #15255 (project freeciv): Status: Ready For Test => Postponed ___ Follow-up Comment #3: Could you try to improve this patch yourself? ___

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Follow-up Comment #2, bug #15255 (project freeciv): there still are swamps and jungels near the poles I used the server script temperature.serv (attached). The server was started with ./ser -r temperature -d 4:mapgen.c an example result can be seen in map_generator_3.jpg Furthermore there i

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

Update of bug #15255 (project freeciv): Status:None => Ready For Test Assigned to:None => pepeto ___ Follow-up Comment #1: Big improvements a

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

URL: Summary: update make_island() - generator 3 Project: Freeciv Submitted by: syntron Submitted on: Sonntag 31.01.2010 um 23:22 Category: general Severity: 3 - Normal