[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Update of bug #16887 (project freeciv): Planned Release: 2.3.0 => 2.4.0 ___ Reply to this item at: ___ Nachricht g

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Follow-up Comment #15, bug #16887 (project freeciv): This patch is now splitted into two parts: 1. generate a full path from a given relative path * remove all mapimg dependend code * only expansion of ~/ to the home directory on *nix systems 2. add get_mapimg_dirs() * defines the directories

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Follow-up Comment #14, bug #16887 (project freeciv): > ~/.freeciv [and its analog on other platforms] is not perfect, > but in the absence of a better place, i think it'll do. This would mean using get_save_dirs() for the client. Furthermore, the server needs a check of the path for the saved im

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Follow-up Comment #13, bug #16887 (project freeciv): ~/.freeciv [and its analog on other platforms] is not perfect, but in the absence of a better place, i think it'll do. There is a chance for the user to select another directory, right?

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Follow-up Comment #12, bug #16887 (project freeciv): > Just a question more: Is the user expect the image to save in > the current directory or in the home directory (as for logs > e.g.)? I do not know. Perhaps some other opinions are needed. Where do you expect a program to save images? (curre

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Follow-up Comment #11, bug #16887 (project freeciv): Just a question more: Is the user expect the image to save in the current directory or in the home directory (as for logs e.g.)? ___ Reply to this item at:

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Update of bug #16887 (project freeciv): Status: In Progress => Ready For Test ___ Follow-up Comment #10: > > Thus, it should return NULL for all other operating systems. > > Is this OK: > > Yes. Not

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Follow-up Comment #9, bug #16887 (project freeciv): > Thus, it should return NULL for all other operating systems. Is > this OK: Yes. Note that the definition of init should be pushed inside the conditional block to avoid compilation warnings. > This function is used for fileinfolist_infix() wh

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Update of bug #16887 (project freeciv): Status: Ready For Test => In Progress ___ Follow-up Comment #8: > Maybe, I haven't be clear enough. As current_dir() is a part > of the public interface, it mu

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Follow-up Comment #7, bug #16887 (project freeciv): Maybe, I haven't be clear enough. As current_dir() is a part of the public interface, it must work in any environment. If it is used in Windows, it will probably produce an error. #ifdef must be added inside this function. get_current_dir() doe

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Update of bug #16887 (project freeciv): Status: In Progress => Ready For Test ___ Follow-up Comment #6: updated patch: * include get_current_dir() from gna patch #2019 * cleanup #ifdef's (file #108

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Follow-up Comment #5, bug #16887 (project freeciv): If current_dir() is not portable, it should also be conditional. Not that: #ifndef A #ifndef B can be simplified by: #if !defined(A) && !defined(B) ___ Reply to this item at:

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Follow-up Comment #4, bug #16887 (project freeciv): > Why returning as a read-or-write data? Done; see below > Please at least add comment to "if (tok[0] != '/')" that "/" > is not root directory in some environments. (In windows > absolute path would start with letter as in "C:") Done; see be

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Follow-up Comment #3, bug #16887 (project freeciv): Please at least add comment to "if (tok[0] != '/')" that "/" is not root directory in some environments. (In windows absolute path would start with letter as in "C:") Also check that we don't already define such a string as a macro somewhere. II

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Update of bug #16887 (project freeciv): Status: Ready For Test => In Progress ___ Follow-up Comment #2: > Is this really portable? It is _not_ portable. For non-unix systems or systems without the e

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

Follow-up Comment #1, bug #16887 (project freeciv): Is this really portable? Why returning as a read-or-write data? ___ Reply to this item at: ___ Message post

[Freeciv-Dev] [bug #16887] generate a full path from a given relative path

URL: Summary: generate a full path from a given relative path Project: Freeciv Submitted by: syntron Submitted on: Montag 18.10.2010 um 17:08 Category: general Severity: 3 - No