[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Marko Lindqvist
Follow-up Comment #11, bug #24942 (project freeciv): > one would need Debian Wheezy or Ubuntu 12.04 to compile Freeciv without C++11 support. User can still override the std version in CXXFLAGS. I'm more concerned about those users who see their standard version going to older one because of

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Louis Moureaux
Follow-up Comment #10, bug #24942 (project freeciv): (In the code below, #0x050700 should read 0x050700. Habit from CSS: every hex number begins with #... Sorry) ___ Reply to this item at:

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Louis Moureaux
Follow-up Comment #9, bug #24942 (project freeciv): > For the C++11 problem, would something as simple as attached patch work? Such a patch would work. On the other hand, one would need Debian Wheezy or Ubuntu 12.04 to compile Freeciv without C++11 support. This would make it more difficult to

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Marko Lindqvist
Follow-up Comment #8, bug #24942 (project freeciv): For the C++11 problem, would something as simple as attached patch work? That would be something I would be ready accept even to S2_5. Preferring pkg-config is probably a good idea (we've headed towards it in general, and we probably have many

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Louis Moureaux
Follow-up Comment #7, bug #24942 (project freeciv): I checked Kde Neon Developer Edition, which ships Qt 5.7 on a Ubuntu 14.04-based system. The default compiler there is GCC 5.4, which defaults to C++98. With my patch, freeciv configures fine but build fails (in Qt) as if std::nullptr_t == int.

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Marko Lindqvist
Follow-up Comment #6, bug #24942 (project freeciv): > A pc file is provided by Qt itself It didn't back then when we added .m4 files. It's possible that all Qt5 versions have provided them, though. Anyway, compatibility issues with oldest supported (by us) versions need to be checked.

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Louis Moureaux
Follow-up Comment #5, bug #24942 (project freeciv): Devil is in the details. Really works now... (file #28240) ___ Additional Item Attachment: File name: qt-use-pkg-config-2.patch.bz2 Size:1 KB

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Marko Lindqvist
Follow-up Comment #4, bug #24942 (project freeciv): Didn't check the patch yet, but couple of general notes before I forget: 1) pkg-config for Qt should set --std=c++11 if it needs it, so it's bug there if we need to set it separately 2) We have macros to set flags only when used compiler

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Louis Moureaux
Follow-up Comment #3, bug #24942 (project freeciv): Attached patch uses pkg-config to discover Qt and sets --std=c++11 if needed. Besides MSVC, I don't know of compilers using other flags. I didn't use --std=c++0x because it enabled *experimental* C++11 support and is deprecated in recent GCC.

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-08 Thread Louis Moureaux
Follow-up Comment #2, bug #24942 (project freeciv): Would Freeciv need such "system consistency", it should check for it and provide a helpful error message, just like for regular dependencies. So it's not that easy to implement. As Qt needs C++11 for all versions >= 5.7.0, the version alone is

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-08 Thread Marko Lindqvist
Follow-up Comment #1, bug #24942 (project freeciv): > The root of the problem is that Qt >= 5.7 require C++11 support. At the same time you should remember that freeciv does not require Qt >= 5.7, and shouldn't require C++11 support for Qt 5.0. Easy way around this would be to declare that