[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Update of patch #3550 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Follow-up Comment #14, patch #3550 (project freeciv): Well, technically - patch #3469 comment #37. ___ Reply to this item at: ___ Message sent via/by Gna! http

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Update of patch #3550 (project freeciv): Status:Done => Ready For Test Open/Closed: Closed => Open ___ Follow-up Comment #13: > I've missed a t

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Follow-up Comment #12, patch #3550 (project freeciv): I've missed a thing - what about the second patch (file #16748) ? ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Update of patch #3550 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Update of patch #3550 (project freeciv): Status:None => Ready For Test Assigned to:None => cazfi Planned Release: 2.5.0 => 2.4.0, 2.5.0, 2.6.0 _

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Follow-up Comment #7, patch #3550 (project freeciv): Made a minor thinko in file #16747 - corrected now. (file #16752) ___ Additional Item Attachment: File name: 0001-modify-selection-rectangle-drawing.patch Size:2 KB ___

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Follow-up Comment #6, patch #3550 (project freeciv): As noted, I've decided if there's no good way to do it, I'll stick with a model that sort of works. I've still merged the active content of update_rect_at_mouse_pos into the calbacks that used it, but updated the old code in regard of deprecati

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Follow-up Comment #5, patch #3550 (project freeciv): Well, it seems we don't quite understand each other, but OK. I went with the extreme duplication instead. You'll see what I mean once I'll attach updated version of both patches. ___ Repl

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Follow-up Comment #4, patch #3550 (project freeciv): > the problem comes down to a simple thing - the function > signature is 'void update_rect_at_mouse_pos(void)'. That's why I proposed new helper function with proper signature ("taking coordinates as parameters") __

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Follow-up Comment #3, patch #3550 (project freeciv): In case of update_rect_at_mouse_pos, the problem comes down to a simple thing - the function signature is 'void update_rect_at_mouse_pos(*void*)'. The already stated reason comes into play, the same one I was against gdk_display_get_device_manag

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Update of patch #3550 (project freeciv): Planned Release: => 2.5.0 ___ Follow-up Comment #2: I see. How about refactoring this to make separate function taking coordinates as parameters t

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

Follow-up Comment #1, patch #3550 (project freeciv): Well, TBH, there's one major catch here: while things work as-is both in gtk2 and gtk3 clients, technically they only do that due to luck. Even back in gtk2 its devs stressed that *all* of the drawing should be done in 'expose-event' handler. I

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

URL: Summary: Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60) Project: Freeciv Submitted by: cazfi Submitted on: Sun 21 Oct 2012 02:08:41 AM EEST Category: client-gtk-3.0